Changeset 231485 in webkit

Timestamp:

May 8, 2018 9:20:06 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

feTurbulence is not rendered correctly on Retina display
​https://bugs.webkit.org/show_bug.cgi?id=183798

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2018-05-08
Reviewed by Simon Fraser.

Source/WebCore:

On 2x display the feTurbulence filter creates a scaled ImageBuffer but
processes only the unscaled size. This is a remaining work of r168577 and
is very similar to what was done for the feMorphology filter in r188271.

Test: fast/hidpi/filters-turbulence.html

• platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegion const):
(WebCore::FETurbulence::platformApplySoftware):

LayoutTests:

• fast/hidpi/filters-turbulence-expected.html: Added.
• fast/hidpi/filters-turbulence.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/hidpi/filters-turbulence-expected.html (added)
• LayoutTests/fast/hidpi/filters-turbulence.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/filters/FETurbulence.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-05-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        feTurbulence is not rendered correctly on Retina display
+        https://bugs.webkit.org/show_bug.cgi?id=183798
+
+        Reviewed by Simon Fraser.
+
+        * fast/hidpi/filters-turbulence-expected.html: Added.
+        * fast/hidpi/filters-turbulence.html: Added.
+
 2018-05-07  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-05-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        feTurbulence is not rendered correctly on Retina display
+        https://bugs.webkit.org/show_bug.cgi?id=183798
+
+        Reviewed by Simon Fraser.
+
+        On 2x display the feTurbulence filter creates a scaled ImageBuffer but
+        processes only the unscaled size. This is a remaining work of r168577 and
+        is very similar to what was done for the feMorphology filter in r188271.
+
+        Test: fast/hidpi/filters-turbulence.html
+
+        * platform/graphics/filters/FETurbulence.cpp:
+        (WebCore::FETurbulence::fillRegion const):
+        (WebCore::FETurbulence::platformApplySoftware):
+
 2018-05-07  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/graphics/filters/FETurbulence.cpp

@@ -371 +371 @@
 
     IntRect filterRegion = absolutePaintRect();
+    filterRegion.scale(filter().filterScale());
     FloatPoint point(0, filterRegion.y() + startY);
     int indexOfPixelChannel = startY * (filterRegion.width() << 2);
@@ -399 +400 @@
         return;
 
-    if (absolutePaintRect().isEmpty()) {
+    IntSize resultSize(absolutePaintRect().size());
+    resultSize.scale(filter().filterScale());
+
+    if (resultSize.isEmpty()) {
         pixelArray->zeroFill();
         return;
@@ -413 +417 @@
     initPaint(paintingData);
 
-    auto area = absolutePaintRect().area();
+    auto area = resultSize.area();
     if (area.hasOverflowed())
         return;
 
-    int height = absolutePaintRect().height();
+    int height = resultSize.height();
 
     unsigned maxNumThreads = height / 8;