Changeset 231552 in webkit

Timestamp:

May 9, 2018 1:53:16 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[MIPS] Use mfhc1 and mthc1 to fix assembler error
​https://bugs.webkit.org/show_bug.cgi?id=185464

Patch by Dominik Infuehr <​dinfuehr@igalia.com> on 2018-05-09
Reviewed by Yusuke Suzuki.

The binutils-assembler started to report failures for copying words between
GP and FP registers for odd FP register indices. Use mfhc1 and mthc1 instead
of mfc1 and mtc1 for conversion.

• offlineasm/mips.rb:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• offlineasm/mips.rb (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-05-09  Dominik Infuehr  <dinfuehr@igalia.com>
+
+        [MIPS] Use mfhc1 and mthc1 to fix assembler error
+        https://bugs.webkit.org/show_bug.cgi?id=185464
+
+        Reviewed by Yusuke Suzuki.
+
+        The binutils-assembler started to report failures for copying words between
+        GP and FP registers for odd FP register indices. Use mfhc1 and mthc1 instead
+        of mfc1 and mtc1 for conversion.
+
+        * offlineasm/mips.rb:
+
 2018-05-08  Dominik Infuehr  <dinfuehr@igalia.com>
 

trunk/Source/JavaScriptCore/offlineasm/mips.rb

@@ -1015 +1015 @@
         when "fii2d"
             $asm.puts "mtc1 #{operands[0].mipsOperand}, #{operands[2].mipsSingleLo}"
-            $asm.puts "mtc1 #{operands[1].mipsOperand}, #{operands[2].mipsSingleHi}"
+            $asm.puts "mthc1 #{operands[1].mipsOperand}, #{operands[2].mipsSingleLo}"
         when "fd2ii"
             $asm.puts "mfc1 #{operands[1].mipsOperand}, #{operands[0].mipsSingleLo}"
-            $asm.puts "mfc1 #{operands[2].mipsOperand}, #{operands[0].mipsSingleHi}"
+            $asm.puts "mfhc1 #{operands[2].mipsOperand}, #{operands[0].mipsSingleLo}"
         when /^bo/
             $asm.puts "bgt #{operands[0].mipsOperand}, #{operands[1].mipsOperand}, #{operands[2].asmLabel}"