Changeset 231818 in webkit

Timestamp:

May 15, 2018, 4:06:28 PM (7 years ago)

Author:

pvollan@apple.com

Message:

Pause display links when window is not visible.
​https://bugs.webkit.org/show_bug.cgi?id=185627
<rdar://problem/39401106>

Reviewed by Simon Fraser.

Pause/resume display links created in the UI process when the window is hidden/shown.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dispatchActivityStateChange):

• UIProcess/mac/DisplayLink.cpp:

(WebKit::DisplayLink::pause):
(WebKit::DisplayLink::resume):

• UIProcess/mac/DisplayLink.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (2 diffs)
• UIProcess/mac/DisplayLink.cpp (modified) (1 diff)
• UIProcess/mac/DisplayLink.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-05-15  Per Arne Vollan  <pvollan@apple.com>
+
+        Pause display links when window is not visible.
+        https://bugs.webkit.org/show_bug.cgi?id=185627
+        <rdar://problem/39401106>
+
+        Reviewed by Simon Fraser.
+
+        Pause/resume display links created in the UI process when the window is hidden/shown.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::dispatchActivityStateChange):
+        * UIProcess/mac/DisplayLink.cpp:
+        (WebKit::DisplayLink::pause):
+        (WebKit::DisplayLink::resume):
+        * UIProcess/mac/DisplayLink.h:
+
 2018-05-15  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -1587 +1587 @@
 
     if (changed & ActivityState::IsVisible) {
-        if (isViewVisible())
+        if (isViewVisible()) {
             m_visiblePageToken = m_process->visiblePageToken();
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
+            if (m_displayLink)
+                m_displayLink->resume();
+#endif
+        }
         else {
             m_visiblePageToken = nullptr;
@@ -1596 +1601 @@
             // stop the unresponsiveness timer here.
             m_process->responsivenessTimer().stop();
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
+            if (m_displayLink)
+                m_displayLink->pause();
+#endif
         }
     }

trunk/Source/WebKit/UIProcess/mac/DisplayLink.cpp

@@ -82 +82 @@
 }
 
+void DisplayLink::pause()
+{
+    if (!CVDisplayLinkIsRunning(m_displayLink))
+        return;
+    CVDisplayLinkStop(m_displayLink);
+}
+
+void DisplayLink::resume()
+{
+    if (CVDisplayLinkIsRunning(m_displayLink))
+        return;
+    CVDisplayLinkStart(m_displayLink);
+}
+
 CVReturn DisplayLink::displayLinkCallback(CVDisplayLinkRef displayLinkRef, const CVTimeStamp*, const CVTimeStamp*, CVOptionFlags, CVOptionFlags*, void* data)
 {

trunk/Source/WebKit/UIProcess/mac/DisplayLink.h

@@ -46 +46 @@
     bool hasObservers() const;
 
+    void pause();
+    void resume();
+    
 private:
     static CVReturn displayLinkCallback(CVDisplayLinkRef, const CVTimeStamp*, const CVTimeStamp*, CVOptionFlags, CVOptionFlags*, void* data);