Changeset 231848 in webkit

Timestamp:

May 16, 2018 9:11:09 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

test262/Runner.pm: save to supplied expectation file if supplied
​https://bugs.webkit.org/show_bug.cgi?id=185660

Patch by Valerie R Young <​valerie@bocoup.com> on 2018-05-16
Reviewed by Michael Saboff.

• Scripts/test262/Runner.pm:

(processCLI):
(main):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/test262/Runner.pm (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-05-16  Valerie R Young  <valerie@bocoup.com>
+
+        test262/Runner.pm: save to supplied expectation file if supplied
+        https://bugs.webkit.org/show_bug.cgi?id=185660
+
+        Reviewed by Michael Saboff.
+
+        * Scripts/test262/Runner.pm:
+        (processCLI):
+        (main):
+
 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Tools/Scripts/test262/Runner.pm

@@ -209 +209 @@
     }
 
-    if (! $ignoreExpectations && $specifiedExpectationsFile) {
+    if ($specifiedExpectationsFile) {
         $expectationsFile = abs_path($specifiedExpectationsFile);
-        if (! -e $expectationsFile) {
-            die "Error: Supplied expectations file $expectationsFile does not exist!";
+        if (! -e $expectationsFile && ! $ignoreExpectations) {
+            print("Warning: Supplied expectations file $expectationsFile does"
+                  . " not exist. Running tests without expectation file.\n");
         }
     }
@@ -390 +391 @@
         print $failcount . " tests failed\n";
     } else {
-        print $failcount . " expected tests failed\n";
+        print $failcount . " tests failed in total\n";
         print $newfailcount . " tests newly fail\n";
         print $newpasscount . " tests newly pass\n";
@@ -928 +929 @@
 =item B<--expectations, -e>
 
-Specify a expectations file.  If not provided, script will load local JSTests/test262/expectations.yaml
+Specify a expectations file for loading and saving.  If not provided, script will load and save to JSTests/test262/expectations.yaml.
 
 =item B<--ignore-expectations, -x>