Changeset 231967 in webkit

Timestamp:

May 18, 2018 11:23:45 AM (6 years ago)

Author:

Wenson Hsieh

Message:

[Extra zoom mode] Clearing text fields should dispatch input events of type "deleteContent"
​https://bugs.webkit.org/show_bug.cgi?id=185769
<rdar://problem/40368261>

Reviewed by Tim Horton.

Source/WebKit:

When setting the text of the currently focused element to the empty string, just delete the text instead of
pretending to insert an empty string. This mimics deleting content using the delete key on macOS, and fires an
input event with inputType "deleteContent" instead of "insertText".

Test: fast/forms/extrazoom/delete-content-in-text-field.html

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setTextAsync):

LayoutTests:

Adds a new test to inspect the input events dispatched as a result of inserting and deleting text in a form
control. The inputTypes should be "insertText" and "deleteContent", respectively; the data values should be the
inserted string and null, respectively.

• fast/forms/extrazoom/delete-content-in-text-field-expected.txt: Added.
• fast/forms/extrazoom/delete-content-in-text-field.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/extrazoom/delete-content-in-text-field-expected.txt (added)
• LayoutTests/fast/forms/extrazoom/delete-content-in-text-field.html (added)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [Extra zoom mode] Clearing text fields should dispatch input events of type "deleteContent"
+        https://bugs.webkit.org/show_bug.cgi?id=185769
+        <rdar://problem/40368261>
+
+        Reviewed by Tim Horton.
+
+        Adds a new test to inspect the input events dispatched as a result of inserting and deleting text in a form
+        control. The inputTypes should be "insertText" and "deleteContent", respectively; the data values should be the
+        inserted string and null, respectively.
+
+        * fast/forms/extrazoom/delete-content-in-text-field-expected.txt: Added.
+        * fast/forms/extrazoom/delete-content-in-text-field.html: Added.
+
 2018-05-18  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [Extra zoom mode] Clearing text fields should dispatch input events of type "deleteContent"
+        https://bugs.webkit.org/show_bug.cgi?id=185769
+        <rdar://problem/40368261>
+
+        Reviewed by Tim Horton.
+
+        When setting the text of the currently focused element to the empty string, just delete the text instead of
+        pretending to insert an empty string. This mimics deleting content using the delete key on macOS, and fires an
+        input event with inputType "deleteContent" instead of "insertText".
+
+        Test: fast/forms/extrazoom/delete-content-in-text-field.html
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::setTextAsync):
+
 2018-05-18  Keith Rollin  <krollin@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

@@ -4620 +4620 @@
         UserTypingGestureIndicator indicator(frame.get());
         frame->selection().selectAll();
-        frame->editor().insertText(text, nullptr, TextEventInputKeyboard);
+        if (text.isEmpty())
+            frame->editor().deleteSelectionWithSmartDelete(false);
+        else
+            frame->editor().insertText(text, nullptr, TextEventInputKeyboard);
         return;
     }