Changeset 231981 in webkit


Ignore:
Timestamp:
May 18, 2018 2:05:08 PM (6 years ago)
Author:
webkit@devinrousso.com
Message:

Web Inspector: Canvas: put hasVisualEffect behind an experimental setting
https://bugs.webkit.org/show_bug.cgi?id=185758

Reviewed by Matt Baker.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/Setting.js:
  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.prototype.process):

  • UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement.prototype.onattach):

  • UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

Location:
trunk/Source/WebInspectorUI
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r231881 r231981  
     12018-05-18  Devin Rousso  <webkit@devinrousso.com>
     2
     3        Web Inspector: Canvas: put `hasVisualEffect` behind an experimental setting
     4        https://bugs.webkit.org/show_bug.cgi?id=185758
     5
     6        Reviewed by Matt Baker.
     7
     8        * Localizations/en.lproj/localizedStrings.js:
     9
     10        * UserInterface/Base/Setting.js:
     11
     12        * UserInterface/Models/RecordingAction.js:
     13        (WI.RecordingAction.prototype.process):
     14
     15        * UserInterface/Views/RecordingActionTreeElement.js:
     16        (WI.RecordingActionTreeElement.prototype.onattach):
     17
     18        * UserInterface/Views/SettingsTabContentView.js:
     19        (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
     20
    1212018-05-16  Devin Rousso  <webkit@devinrousso.com>
    222
  • trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

    r231881 r231981  
    171171localizedStrings["Canvas %s"] = "Canvas %s";
    172172localizedStrings["Canvas Element"] = "Canvas Element";
     173localizedStrings["Canvas:"] = "Canvas:";
    173174localizedStrings["Canvases"] = "Canvases";
    174175localizedStrings["Cap"] = "Cap";
     
    373374localizedStrings["Enable Program"] = "Enable Program";
    374375localizedStrings["Enable Sources Tab"] = "Enable Sources Tab";
     376localizedStrings["Enable Visual Change Detection"] = "Enable Visual Change Detection";
    375377localizedStrings["Enable all breakpoints (%s)"] = "Enable all breakpoints (%s)";
    376378localizedStrings["Enable breakpoints"] = "Enable breakpoints";
  • trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js

    r231881 r231981  
    131131    experimentalEnableNewTabBar: new WI.Setting("experimental-enable-new-tab-bar", false),
    132132    experimentalEnableAccessibilityAuditTab: new WI.Setting("experimental-enable-accessibility-audit-tab", false),
     133    experimentalRecordingHasVisualEffect: new WI.Setting("experimental-recording-has-visual-effect", false),
    133134};
  • trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js

    r231368 r231981  
    140140
    141141        let contentBefore = null;
    142         if (this._valid && this._isVisual)
     142        let shouldCheckHasVisualEffect = WI.settings.experimentalRecordingHasVisualEffect.value && this._valid && this._isVisual;
     143        if (shouldCheckHasVisualEffect)
    143144            contentBefore = getContent();
    144145
    145146        this.apply(context);
    146147
    147         if (this._valid && this._isVisual)
     148        if (shouldCheckHasVisualEffect)
    148149            this._hasVisibleEffect = !Array.shallowEqual(contentBefore, getContent());
    149150
  • trunk/Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js

    r231218 r231981  
    400400        this.element.dataset.index = this._index.toLocaleString();
    401401
    402         if (this.representedObject.valid && this.representedObject.isVisual && !this.representedObject.hasVisibleEffect) {
     402        if (WI.settings.experimentalRecordingHasVisualEffect.value && this.representedObject.valid && this.representedObject.isVisual && !this.representedObject.hasVisibleEffect) {
    403403            this.addClassName("no-visible-effect");
    404404
  • trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

    r230228 r231981  
    260260        experimentalSettingsView.addSeparator();
    261261
     262        experimentalSettingsView.addSetting(WI.UIString("Canvas:"), WI.settings.experimentalRecordingHasVisualEffect, WI.UIString("Enable Visual Change Detection"));
     263        experimentalSettingsView.addSeparator();
     264
    262265        let reloadInspectorButton = document.createElement("button");
    263266        reloadInspectorButton.textContent = WI.UIString("Reload Web Inspector");
Note: See TracChangeset for help on using the changeset viewer.