Changeset 231981 in webkit
- Timestamp:
- May 18, 2018 2:05:08 PM (6 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r231881 r231981 1 2018-05-18 Devin Rousso <webkit@devinrousso.com> 2 3 Web Inspector: Canvas: put `hasVisualEffect` behind an experimental setting 4 https://bugs.webkit.org/show_bug.cgi?id=185758 5 6 Reviewed by Matt Baker. 7 8 * Localizations/en.lproj/localizedStrings.js: 9 10 * UserInterface/Base/Setting.js: 11 12 * UserInterface/Models/RecordingAction.js: 13 (WI.RecordingAction.prototype.process): 14 15 * UserInterface/Views/RecordingActionTreeElement.js: 16 (WI.RecordingActionTreeElement.prototype.onattach): 17 18 * UserInterface/Views/SettingsTabContentView.js: 19 (WI.SettingsTabContentView.prototype._createExperimentalSettingsView): 20 1 21 2018-05-16 Devin Rousso <webkit@devinrousso.com> 2 22 -
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
r231881 r231981 171 171 localizedStrings["Canvas %s"] = "Canvas %s"; 172 172 localizedStrings["Canvas Element"] = "Canvas Element"; 173 localizedStrings["Canvas:"] = "Canvas:"; 173 174 localizedStrings["Canvases"] = "Canvases"; 174 175 localizedStrings["Cap"] = "Cap"; … … 373 374 localizedStrings["Enable Program"] = "Enable Program"; 374 375 localizedStrings["Enable Sources Tab"] = "Enable Sources Tab"; 376 localizedStrings["Enable Visual Change Detection"] = "Enable Visual Change Detection"; 375 377 localizedStrings["Enable all breakpoints (%s)"] = "Enable all breakpoints (%s)"; 376 378 localizedStrings["Enable breakpoints"] = "Enable breakpoints"; -
trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js
r231881 r231981 131 131 experimentalEnableNewTabBar: new WI.Setting("experimental-enable-new-tab-bar", false), 132 132 experimentalEnableAccessibilityAuditTab: new WI.Setting("experimental-enable-accessibility-audit-tab", false), 133 experimentalRecordingHasVisualEffect: new WI.Setting("experimental-recording-has-visual-effect", false), 133 134 }; -
trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js
r231368 r231981 140 140 141 141 let contentBefore = null; 142 if (this._valid && this._isVisual) 142 let shouldCheckHasVisualEffect = WI.settings.experimentalRecordingHasVisualEffect.value && this._valid && this._isVisual; 143 if (shouldCheckHasVisualEffect) 143 144 contentBefore = getContent(); 144 145 145 146 this.apply(context); 146 147 147 if ( this._valid && this._isVisual)148 if (shouldCheckHasVisualEffect) 148 149 this._hasVisibleEffect = !Array.shallowEqual(contentBefore, getContent()); 149 150 -
trunk/Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js
r231218 r231981 400 400 this.element.dataset.index = this._index.toLocaleString(); 401 401 402 if ( this.representedObject.valid && this.representedObject.isVisual && !this.representedObject.hasVisibleEffect) {402 if (WI.settings.experimentalRecordingHasVisualEffect.value && this.representedObject.valid && this.representedObject.isVisual && !this.representedObject.hasVisibleEffect) { 403 403 this.addClassName("no-visible-effect"); 404 404 -
trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
r230228 r231981 260 260 experimentalSettingsView.addSeparator(); 261 261 262 experimentalSettingsView.addSetting(WI.UIString("Canvas:"), WI.settings.experimentalRecordingHasVisualEffect, WI.UIString("Enable Visual Change Detection")); 263 experimentalSettingsView.addSeparator(); 264 262 265 let reloadInspectorButton = document.createElement("button"); 263 266 reloadInspectorButton.textContent = WI.UIString("Reload Web Inspector");
Note: See TracChangeset
for help on using the changeset viewer.