Changeset 232009 in webkit

Timestamp:

May 20, 2018 11:24:52 PM (6 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] MiniBrowser crashes when loading twice quickly
​https://bugs.webkit.org/show_bug.cgi?id=185763

Reviewed by Michael Catanzaro.

This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very
fast and multiple loads are done quickly. The problem is that we use an idle to reset the progress bar, but we
don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one
leaked, it will crash when scheduled if the window has already been destroyed.

• MiniBrowser/gtk/BrowserWindow.c:

(webViewLoadProgressChanged): Stop any pending reset task when progress != 1.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/gtk/BrowserWindow.c (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] MiniBrowser crashes when loading twice quickly
+        https://bugs.webkit.org/show_bug.cgi?id=185763
+
+        Reviewed by Michael Catanzaro.
+
+        This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very
+        fast and multiple loads are done quickly. The problem is that we use an idle to reset the progress bar, but we
+        don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one
+        leaked, it will crash when scheduled if the window has already been destroyed.
+
+        * MiniBrowser/gtk/BrowserWindow.c:
+        (webViewLoadProgressChanged): Stop any pending reset task when progress != 1.
+
 2018-05-19  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Tools/MiniBrowser/gtk/BrowserWindow.c

@@ -178 +178 @@
         window->resetEntryProgressTimeoutId = g_timeout_add(500, (GSourceFunc)resetEntryProgress, window);
         g_source_set_name_by_id(window->resetEntryProgressTimeoutId, "[WebKit] resetEntryProgress");
+    } else if (window->resetEntryProgressTimeoutId) {
+        g_source_remove(window->resetEntryProgressTimeoutId);
+        window->resetEntryProgressTimeoutId = 0;
     }
 }