Changeset 232020 in webkit

Timestamp:

May 21, 2018 10:52:18 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Propagate WebCore system include dirs in WebCoreHeaderInterface
​https://bugs.webkit.org/show_bug.cgi?id=185822

Patch by Olivier Blin <Olivier Blin> on 2018-05-21
Reviewed by Michael Catanzaro.

System include directories from WebCore are not propagated anymore to its users.
For example gcrypt, sqlite and ICU system headers defined in PAL are not properly passed to WebKit build.

This may have been caused partly by the fix in r230385:
[CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library
​https://bugs.webkit.org/show_bug.cgi?id=184127

No new tests, build fix.

• CMakeLists.txt:

Location:

trunk/Source/WebCore

Files:

• CMakeLists.txt (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/WebCore/CMakeLists.txt

@@ -1973 +1973 @@
 add_library(WebCoreHeaderInterface INTERFACE)
 target_include_directories(WebCoreHeaderInterface INTERFACE ${WebCore_INCLUDE_DIRECTORIES})
+target_include_directories(WebCoreHeaderInterface SYSTEM INTERFACE ${WebCore_SYSTEM_INCLUDE_DIRECTORIES})
 target_link_libraries(WebCoreHeaderInterface INTERFACE ${WebCore_LIBRARIES})
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-05-21  Olivier Blin  <olivier.blin@softathome.com>
+
+        Propagate WebCore system include dirs in WebCoreHeaderInterface
+        https://bugs.webkit.org/show_bug.cgi?id=185822
+
+        Reviewed by Michael Catanzaro.
+
+        System include directories from WebCore are not propagated anymore to its users.
+        For example gcrypt, sqlite and ICU system headers defined in PAL are not properly passed to WebKit build.
+
+        This may have been caused partly by the fix in r230385:
+        [CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library
+        https://bugs.webkit.org/show_bug.cgi?id=184127
+
+        No new tests, build fix.
+
+        * CMakeLists.txt:
+
 2018-05-21  Olivier Blin  <olivier.blin@softathome.com>