Changeset 232103 in webkit


Ignore:
Timestamp:
May 22, 2018 8:47:54 PM (6 years ago)
Author:
mmaxfield@apple.com
Message:

Text can wrap between hyphens and commas
https://bugs.webkit.org/show_bug.cgi?id=185899
<rdar://problem/40118983>

Reviewed by Zalan Bujtas.

Source/WebCore:

Chrome, Firefox, and ICU all agree that text shouldn't wrap there.

Test: fast/text/line-break-hyphen-comma.html

  • rendering/BreakLines.cpp:

LayoutTests:

  • fast/text/line-break-hyphen-comma-expected.html: Added.
  • fast/text/line-break-hyphen-comma.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r232091 r232103  
     12018-05-22  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        Text can wrap between hyphens and commas
     4        https://bugs.webkit.org/show_bug.cgi?id=185899
     5        <rdar://problem/40118983>
     6
     7        Reviewed by Zalan Bujtas.
     8
     9        * fast/text/line-break-hyphen-comma-expected.html: Added.
     10        * fast/text/line-break-hyphen-comma.html: Added.
     11
    1122018-05-22  David Fenton  <david_fenton@apple.com>
    213
  • trunk/Source/WebCore/ChangeLog

    r232098 r232103  
     12018-05-22  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        Text can wrap between hyphens and commas
     4        https://bugs.webkit.org/show_bug.cgi?id=185899
     5        <rdar://problem/40118983>
     6
     7        Reviewed by Zalan Bujtas.
     8
     9        Chrome, Firefox, and ICU all agree that text shouldn't wrap there.
     10
     11        Test: fast/text/line-break-hyphen-comma.html
     12
     13        * rendering/BreakLines.cpp:
     14
    1152018-05-22  Simon Fraser  <simon.fraser@apple.com>
    216
  • trunk/Source/WebCore/rendering/BreakLines.cpp

    r204531 r232103  
    6565    { B(0, 0, 0, 0, 0, 0, 0, 1), B(0, 0, 0, 0, 0, 0, 0, 0), 0, B(0, 0, 0, 1, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0) }, // +
    6666    { B(0, 0, 0, 0, 0, 0, 0, 1), B(0, 0, 0, 0, 0, 0, 0, 0), 0, B(0, 0, 0, 1, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0) }, // ,
    67     { B(1, 1, 1, 1, 1, 1, 1, 1), B(1, 1, 1, 1, 1, 0, 1, 0), 0, B(0, 1, 1, 1, 1, 1, 1, 1), F, F, F, B(1, 1, 1, 1, 1, 1, 1, 1), F, F, F, B(1, 1, 1, 1, 1, 1, 1, 1) }, // - Note: breaking before '0'-'9' is handled hard-coded in shouldBreakAfter().
     67    { B(1, 1, 1, 1, 1, 1, 1, 1), B(1, 1, 1, 0, 1, 0, 1, 0), 0, B(0, 1, 1, 1, 1, 1, 1, 1), F, F, F, B(1, 1, 1, 1, 1, 1, 1, 1), F, F, F, B(1, 1, 1, 1, 1, 1, 1, 1) }, // - Note: breaking before '0'-'9' is handled hard-coded in shouldBreakAfter().
    6868    { B(0, 0, 0, 0, 0, 0, 0, 1), B(0, 0, 0, 0, 0, 0, 0, 0), 0, B(0, 0, 0, 1, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0) }, // .
    6969    { B(0, 0, 0, 0, 0, 0, 0, 0), B(0, 0, 0, 0, 0, 0, 0, 0), 0, B(0, 0, 0, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 0, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 0, 0, 0, 0, 0, 0) }, // /
Note: See TracChangeset for help on using the changeset viewer.