Changeset 232184 in webkit

Timestamp:

May 24, 2018, 10:09:33 PM (7 years ago)

Author:

mitz@apple.com

Message:

ProcessLauncherMac.mm contains a couple of meaningless #ifndef directives
​https://bugs.webkit.org/show_bug.cgi?id=185973

Reviewed by Tim Horton.

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): Use #if !ASSERT_DISABLED to guard statements that

are only needed for an assertion, instead of #ifndef _NDEBUG, which is always true.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Launcher/mac/ProcessLauncherMac.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-05-24  Dan Bernstein  <mitz@apple.com>
+
+        ProcessLauncherMac.mm contains a couple of meaningless #ifndef directives
+        https://bugs.webkit.org/show_bug.cgi?id=185973
+
+        Reviewed by Tim Horton.
+
+        * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+        (WebKit::ProcessLauncher::launchProcess): Use #if !ASSERT_DISABLED to guard statements that
+          are only needed for an assertion, instead of #ifndef _NDEBUG, which is always true.
+
 2018-05-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 

trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm

@@ -213 +213 @@
             return;
 
-#ifndef _NDEBUG
+#if !ASSERT_DISABLED
         mach_port_urefs_t sendRightCount = 0;
         mach_port_get_refs(mach_task_self(), listeningPort, MACH_PORT_RIGHT_SEND, &sendRightCount);
@@ -250 +250 @@
             ASSERT(!strcmp(xpc_dictionary_get_string(reply, "message-name"), "process-finished-launching"));
 
-#ifndef _NDEBUG
+#if !ASSERT_DISABLED
             mach_port_urefs_t sendRightCount = 0;
             mach_port_get_refs(mach_task_self(), listeningPort, MACH_PORT_RIGHT_SEND, &sendRightCount);