Changeset 232409 in webkit

Timestamp:

Jun 1, 2018 12:53:56 PM (6 years ago)

Author:

youenn@apple.com

Message:

http/tests/appcache/deferred-events.html is flaky due to console log messages
​https://bugs.webkit.org/show_bug.cgi?id=185543

Reviewed by Chris Dumez.

Update the test to wait for the onerror callback.
At that time, all console logging should be done.

• http/tests/appcache/deferred-events-expected.txt:
• http/tests/appcache/deferred-events.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/appcache/deferred-events-expected.txt (modified) (1 diff)
• http/tests/appcache/deferred-events.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-06-01  Youenn Fablet  <youenn@apple.com>
+
+        http/tests/appcache/deferred-events.html is flaky due to console log messages
+        https://bugs.webkit.org/show_bug.cgi?id=185543
+
+        Reviewed by Chris Dumez.
+
+        Update the test to wait for the onerror callback.
+        At that time, all console logging should be done.
+
+        * http/tests/appcache/deferred-events-expected.txt:
+        * http/tests/appcache/deferred-events.html:
+
 2018-05-29  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/LayoutTests/http/tests/appcache/deferred-events-expected.txt

@@ -2 +2 @@
 CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
 Test that AppicationCache events are deferred until after onload has been fired.
-SUCCESS
+PASS

trunk/LayoutTests/http/tests/appcache/deferred-events.html

@@ -3 +3 @@
   <script type="text/javascript">
     var onloadHasBeenCalled = false;
+    var oncheckingAfterOnload = false;
 
     if (window.testRunner) {
@@ -10 +11 @@
 
     window.applicationCache.onchecking = function() {
-        if (onloadHasBeenCalled)
-            document.getElementById('result').innerHTML = "SUCCESS"
+        oncheckingAfterOnload = onloadHasBeenCalled;
+    }
+
+    window.applicationCache.onerror = function() {
+        document.getElementById('result').innerHTML = oncheckingAfterOnload ? "PASS" : "FAIL";
+        if (window.testRunner)
+            testRunner.notifyDone();
+    }
+
+    window.applicationCache.oncached = function() {
+        document.getElementById('result').innerHTML = "FAIL: oncached event received";
         if (window.testRunner)
             testRunner.notifyDone();