Changeset 232520 in webkit


Ignore:
Timestamp:
Jun 5, 2018 1:58:14 PM (6 years ago)
Author:
Darin Adler
Message:

[Cocoa] More preparation for ARC, focusing on WebKit and smart pointers
https://bugs.webkit.org/show_bug.cgi?id=186314

Reviewed by Anders Carlsson.

Source/WebKit:

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa): Use bridge for cast.

  • NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::overrideSystemProxies): Ditto.
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost): Ditto.

  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::sendMessage): Ditto.
(IPC::readFromMachPort): Ditto.

  • Platform/mac/StringUtilities.mm:

(WebKit::formattedPhoneNumberString): Use bridge for cast and
CFBridgingRelease instead of an explicit autorelease.

  • Shared/API/Cocoa/_WKRemoteObjectInterface.mm:

(initializeMethods): Use auto instead of an explicit type so that we get
the correct type for the result of protocol_copyProtocolList.

  • Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:

(-[_WKRemoteObjectRegistry _sendInvocation:interface:]): Added a
bridging cast to void* because that's needed to call _Block_signature
under ARC and harmless outside ARC.

  • Shared/API/c/cf/WKStringCF.mm:

(WKStringCreateWithCFString): Use bridge for cast.

  • Shared/API/c/cf/WKURLCF.mm:

(WKURLCreateWithCFURL): Ditto.

  • Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:

(WebKit::AuthenticationManager::initializeConnection): Ditto.

  • Shared/Cocoa/DataDetectionResult.mm:

(WebKit::DataDetectionResult::encode const): Ditto.
(WebKit::DataDetectionResult::decode): Ditto.

  • Shared/Cocoa/WKNSError.mm:

(-[WKNSError _web_createTarget]): Ditto.

  • Shared/Cocoa/WKNSURLExtras.mm:

(-[NSURL _web_originalDataAsWTFString]): Ditto.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer): Removed balanced calls to both
adoptOSObject and xpc_retain and instead rely on the assignment
operator just added to OSObjectPtr.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceEventHandler): Use bridge for cast.

  • Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer): Ditto.

  • Shared/cf/ArgumentCodersCF.cpp:

(IPC::decode): Ditto.

  • Shared/mac/ArgumentCodersMac.mm:

(IPC::isSerializableValue): Ditto.
(IPC::encode): Ditto.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::encodeNSError): Ditto. Also use CFSTR("")" instead of @""
when we need a CFString.
(IPC::decodeNSError): Ditto.
(IPC::ArgumentCoder<ProtectionSpace>::encodePlatformData): Ditto.
(IPC::ArgumentCoder<ProtectionSpace>::decodePlatformData): Ditto.
(IPC::ArgumentCoder<Credential>::encodePlatformData): Ditto.
(IPC::ArgumentCoder<Credential>::decodePlatformData): Ditto.
(IPC::ArgumentCoder<ContentFilterUnblockHandler>::encode): Ditto.
(IPC::ArgumentCoder<ContentFilterUnblockHandler>::decode): Ditto.
(IPC::ArgumentCoder<MediaPlaybackTargetContext>::encodePlatformData): Ditto.
(IPC::ArgumentCoder<MediaPlaybackTargetContext>::decodePlatformData): Ditto.

  • Shared/mac/WebHitTestResultData.mm:

(WebKit::WebHitTestResultData::platformEncode const): Ditto.
(WebKit::WebHitTestResultData::platformDecode): Ditto.

  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextIsPlugInUpdateAvailable): Ditto.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController certificateChain]): Ditto.
(didStartProvisionalLoadForFrame): Ditto.
(didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
(didFailProvisionalLoadWithErrorForFrame): Ditto.
(didCommitLoadForFrame): Ditto.
(didFinishLoadForFrame): Ditto.
(didFailLoadWithErrorForFrame): Ditto.
(canAuthenticateAgainstProtectionSpaceInFrame): Ditto.
(didReceiveAuthenticationChallengeInFrame): Ditto.
(didStartProgress): Ditto.
(didChangeProgress): Ditto.
(didFinishProgress): Ditto.
(didChangeBackForwardList): Ditto.
(processDidCrash): Ditto.
(setUpPageLoaderClient): Ditto.
(setUpPagePolicyClient): Ditto.

  • UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:

(createWKArray): Ditto.
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]): Ditto.
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]): Ditto.

  • UIProcess/API/Cocoa/WKConnection.mm:

(didReceiveMessage): Ditto.
(didClose): Ditto.
(setUpClient): Ditto.

  • UIProcess/API/Cocoa/WKProcessGroup.mm:

(didCreateConnection): Ditto.
(getInjectedBundleInitializationUserData): Ditto.
(setUpInjectedBundleClient): Ditto.
(-[WKProcessGroup _setAllowsSpecificHTTPSCertificate:forHost:]): Ditto.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _setAllowsSpecificHTTPSCertificate:forHost:]): Ditto.

  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _setProxyConfiguration:]): Ditto.
(-[WKWebsiteDataStore _proxyConfiguration]): Ditto.

  • UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView _didTakeSnapshot:]): Ditto.

  • UIProcess/API/Cocoa/_WKUserContentFilter.mm: Added a missing include.
  • UIProcess/Authentication/mac/WebCredentialMac.mm:

(WebKit::chain): Use bridge for cast.

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::legacyPlatformDefaultNetworkCacheDirectory):
Use CFBridgingRelease instead of adoptNS.
(WebKit::privateBrowsingSession): Use bridge for cast.

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::provideDataForPasteboard): Use bridge for cast.

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::pluginPathsInDirectory): Ditto.

  • UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::recursivelyMapIOSurfaceBackingStore): Ditto.

  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::beginSwipeGesture): Ditto.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]): Ditto.

  • UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::showPopupMenu): Ditto.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

(didCreatePage): Ditto.
(willDestroyPage): Ditto.
(setUpBundleClient): Ditto.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(didStartProvisionalLoadForFrame): Ditto.
(didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
(didFinishLoadForFrame): Ditto.
(globalObjectIsAvailableForFrame): Ditto.
(didRemoveFrameFromHierarchy): Ditto.
(didCommitLoadForFrame): Ditto.
(didFinishDocumentLoadForFrame): Ditto.
(didFailProvisionalLoadWithErrorForFrame): Ditto.
(didFailLoadWithErrorForFrame): Ditto.
(didSameDocumentNavigationForFrame): Ditto.
(didLayoutForFrame): Ditto.
(didReachLayoutMilestone): Ditto.
(didFirstVisuallyNonEmptyLayoutForFrame): Ditto.
(didHandleOnloadEventsForFrame): Ditto.
(userAgentForURL): Ditto.
(setUpPageLoaderClient): Ditto.
(willSendRequestForFrame): Ditto.
(didInitiateLoadForResource): Ditto.
(didFinishLoadForResource): Ditto.
(didFailLoadForResource): Ditto.
(setUpResourceLoadClient): Ditto.

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::initialize): Ditto.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::popUpContextMenu): Ditto.

  • WebProcess/Plugins/PDF/PDFPlugin.h: Put functions that return NSData inside

an #ifdef OBJC and use bridge for cast.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteDragImage): Use bridge for cast.

  • WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:

(WebKit::PlatformCALayerRemoteCustom::contents const): Added a bridging cast.
(WebKit::PlatformCALayerRemoteCustom::setContents): Use bridge for cast.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom): Ditto.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::setTopOverhangImage): Ditto.
(WebKit::WebPage::setBottomOverhangImage): Ditto.

Source/WTF:

  • wtf/BlockPtr.h: Put Block_copy/release calls into #if since they are

not needed under ARC.

  • wtf/OSObjectPtr.h: Added constructor and assignment operator so we can

work with OS objects without adopting them.

Location:
trunk/Source
Files:
49 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WTF/ChangeLog

    r232519 r232520  
     12018-06-05  Darin Adler  <darin@apple.com>
     2
     3        [Cocoa] More preparation for ARC, focusing on WebKit and smart pointers
     4        https://bugs.webkit.org/show_bug.cgi?id=186314
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * wtf/BlockPtr.h: Put Block_copy/release calls into #if since they are
     9        not needed under ARC.
     10
     11        * wtf/OSObjectPtr.h: Added constructor and assignment operator so we can
     12        work with OS objects without adopting them.
     13
    1142018-06-05  Darin Adler  <darin@apple.com>
    215
  • trunk/Source/WTF/wtf/BlockPtr.h

    r224545 r232520  
    9898        new (&block->f) F { std::move(function) };
    9999
     100#if defined(__OBJC__) && __has_feature(objc_arc)
     101        BlockPtr blockPtr { (__bridge_transfer BlockType)block };
     102#else
    100103        BlockPtr blockPtr;
    101104        blockPtr.m_block = reinterpret_cast<BlockType>(block);
     105#endif
    102106
    103107        return blockPtr;
     
    110114
    111115    BlockPtr(BlockType block)
     116#if defined(__OBJC__) && __has_feature(objc_arc)
     117        : m_block(block)
     118#else
    112119        : m_block(Block_copy(block))
     120#endif
    113121    {
    114122    }
    115123
    116124    BlockPtr(const BlockPtr& other)
     125#if defined(__OBJC__) && __has_feature(objc_arc)
     126        : m_block(other.m_block)
     127#else
    117128        : m_block(Block_copy(other.m_block))
     129#endif
    118130    {
    119131    }
     
    126138    ~BlockPtr()
    127139    {
     140#if !defined(__OBJC__) || !__has_feature(objc_arc)
    128141        Block_release(m_block);
     142#endif
    129143    }
    130144
    131145    BlockPtr& operator=(const BlockPtr& other)
    132146    {
     147#if defined(__OBJC__) && __has_feature(objc_arc)
     148        m_block = other.m_block;
     149#else
    133150        if (this != &other) {
    134151            Block_release(m_block);
    135152            m_block = Block_copy(other.m_block);
    136153        }
    137        
     154#endif
     155
    138156        return *this;
    139157    }
     
    143161        ASSERT(this != &other);
    144162
     163#if !defined(__OBJC__) || !__has_feature(objc_arc)
    145164        Block_release(m_block);
     165#endif
    146166        m_block = std::exchange(other.m_block, nullptr);
    147167
     
    175195using WTF::BlockPtr;
    176196using WTF::makeBlockPtr;
    177 
  • trunk/Source/WTF/wtf/OSObjectPtr.h

    r232509 r232520  
    8686    }
    8787
     88    OSObjectPtr(T ptr)
     89        : m_ptr(ptr)
     90    {
     91        if (m_ptr)
     92            retainOSObject(m_ptr);
     93    }
     94
    8895    OSObjectPtr& operator=(const OSObjectPtr& other)
    8996    {
     
    106113        m_ptr = nullptr;
    107114
     115        return *this;
     116    }
     117
     118    OSObjectPtr& operator=(T other)
     119    {
     120        OSObjectPtr ptr = other;
     121        swap(ptr);
    108122        return *this;
    109123    }
  • trunk/Source/WebKit/ChangeLog

    r232516 r232520  
     12018-06-05  Darin Adler  <darin@apple.com>
     2
     3        [Cocoa] More preparation for ARC, focusing on WebKit and smart pointers
     4        https://bugs.webkit.org/show_bug.cgi?id=186314
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
     9        (WebKit::NetworkSessionCocoa::NetworkSessionCocoa): Use __bridge for cast.
     10        * NetworkProcess/mac/NetworkProcessMac.mm:
     11        (WebKit::overrideSystemProxies): Ditto.
     12        (WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost): Ditto.
     13        * Platform/IPC/mac/ConnectionMac.mm:
     14        (IPC::Connection::sendMessage): Ditto.
     15        (IPC::readFromMachPort): Ditto.
     16
     17        * Platform/mac/StringUtilities.mm:
     18        (WebKit::formattedPhoneNumberString): Use __bridge for cast and
     19        CFBridgingRelease instead of an explicit autorelease.
     20
     21        * Shared/API/Cocoa/_WKRemoteObjectInterface.mm:
     22        (initializeMethods): Use auto instead of an explicit type so that we get
     23        the correct type for the result of protocol_copyProtocolList.
     24
     25        * Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:
     26        (-[_WKRemoteObjectRegistry _sendInvocation:interface:]): Added a
     27        bridging cast to void* because that's needed to call _Block_signature
     28        under ARC and harmless outside ARC.
     29
     30        * Shared/API/c/cf/WKStringCF.mm:
     31        (WKStringCreateWithCFString): Use __bridge for cast.
     32        * Shared/API/c/cf/WKURLCF.mm:
     33        (WKURLCreateWithCFURL): Ditto.
     34        * Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:
     35        (WebKit::AuthenticationManager::initializeConnection): Ditto.
     36        * Shared/Cocoa/DataDetectionResult.mm:
     37        (WebKit::DataDetectionResult::encode const): Ditto.
     38        (WebKit::DataDetectionResult::decode): Ditto.
     39        * Shared/Cocoa/WKNSError.mm:
     40        (-[WKNSError _web_createTarget]): Ditto.
     41        * Shared/Cocoa/WKNSURLExtras.mm:
     42        (-[NSURL _web_originalDataAsWTFString]): Ditto.
     43
     44        * Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
     45        (WebKit::XPCServiceInitializer): Removed balanced calls to both
     46        adoptOSObject and xpc_retain and instead rely on the assignment
     47        operator just added to OSObjectPtr.
     48
     49        * Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
     50        (WebKit::XPCServiceEventHandler): Use __bridge for cast.
     51        * Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
     52        (WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer): Ditto.
     53        * Shared/cf/ArgumentCodersCF.cpp:
     54        (IPC::decode): Ditto.
     55        * Shared/mac/ArgumentCodersMac.mm:
     56        (IPC::isSerializableValue): Ditto.
     57        (IPC::encode): Ditto.
     58        * Shared/mac/WebCoreArgumentCodersMac.mm:
     59        (IPC::encodeNSError): Ditto. Also use CFSTR("")" instead of @""
     60        when we need a CFString.
     61        (IPC::decodeNSError): Ditto.
     62        (IPC::ArgumentCoder<ProtectionSpace>::encodePlatformData): Ditto.
     63        (IPC::ArgumentCoder<ProtectionSpace>::decodePlatformData): Ditto.
     64        (IPC::ArgumentCoder<Credential>::encodePlatformData): Ditto.
     65        (IPC::ArgumentCoder<Credential>::decodePlatformData): Ditto.
     66        (IPC::ArgumentCoder<ContentFilterUnblockHandler>::encode): Ditto.
     67        (IPC::ArgumentCoder<ContentFilterUnblockHandler>::decode): Ditto.
     68        (IPC::ArgumentCoder<MediaPlaybackTargetContext>::encodePlatformData): Ditto.
     69        (IPC::ArgumentCoder<MediaPlaybackTargetContext>::decodePlatformData): Ditto.
     70        * Shared/mac/WebHitTestResultData.mm:
     71        (WebKit::WebHitTestResultData::platformEncode const): Ditto.
     72        (WebKit::WebHitTestResultData::platformDecode): Ditto.
     73        * UIProcess/API/C/mac/WKContextPrivateMac.mm:
     74        (WKContextIsPlugInUpdateAvailable): Ditto.
     75        * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
     76        (-[WKBrowsingContextController certificateChain]): Ditto.
     77        (didStartProvisionalLoadForFrame): Ditto.
     78        (didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
     79        (didFailProvisionalLoadWithErrorForFrame): Ditto.
     80        (didCommitLoadForFrame): Ditto.
     81        (didFinishLoadForFrame): Ditto.
     82        (didFailLoadWithErrorForFrame): Ditto.
     83        (canAuthenticateAgainstProtectionSpaceInFrame): Ditto.
     84        (didReceiveAuthenticationChallengeInFrame): Ditto.
     85        (didStartProgress): Ditto.
     86        (didChangeProgress): Ditto.
     87        (didFinishProgress): Ditto.
     88        (didChangeBackForwardList): Ditto.
     89        (processDidCrash): Ditto.
     90        (setUpPageLoaderClient): Ditto.
     91        (setUpPagePolicyClient): Ditto.
     92        * UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:
     93        (createWKArray): Ditto.
     94        (-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]): Ditto.
     95        (-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]): Ditto.
     96        * UIProcess/API/Cocoa/WKConnection.mm:
     97        (didReceiveMessage): Ditto.
     98        (didClose): Ditto.
     99        (setUpClient): Ditto.
     100        * UIProcess/API/Cocoa/WKProcessGroup.mm:
     101        (didCreateConnection): Ditto.
     102        (getInjectedBundleInitializationUserData): Ditto.
     103        (setUpInjectedBundleClient): Ditto.
     104        (-[WKProcessGroup _setAllowsSpecificHTTPSCertificate:forHost:]): Ditto.
     105        * UIProcess/API/Cocoa/WKProcessPool.mm:
     106        (-[WKProcessPool _setAllowsSpecificHTTPSCertificate:forHost:]): Ditto.
     107        * UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
     108        (-[WKWebsiteDataStore _setProxyConfiguration:]): Ditto.
     109        (-[WKWebsiteDataStore _proxyConfiguration]): Ditto.
     110        * UIProcess/API/Cocoa/_WKThumbnailView.mm:
     111        (-[_WKThumbnailView _didTakeSnapshot:]): Ditto.
     112
     113        * UIProcess/API/Cocoa/_WKUserContentFilter.mm: Added a missing include.
     114
     115        * UIProcess/Authentication/mac/WebCredentialMac.mm:
     116        (WebKit::chain): Use __bridge for cast.
     117
     118        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
     119        (WebKit::WebProcessPool::legacyPlatformDefaultNetworkCacheDirectory):
     120        Use CFBridgingRelease instead of adoptNS.
     121        (WebKit::privateBrowsingSession): Use __bridge for cast.
     122
     123        * UIProcess/Cocoa/WebViewImpl.mm:
     124        (WebKit::WebViewImpl::provideDataForPasteboard): Use __bridge for cast.
     125        * UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
     126        (WebKit::PluginInfoStore::pluginPathsInDirectory): Ditto.
     127        * UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
     128        (WebKit::recursivelyMapIOSurfaceBackingStore): Ditto.
     129        * UIProcess/mac/ViewGestureControllerMac.mm:
     130        (WebKit::ViewGestureController::beginSwipeGesture): Ditto.
     131        * UIProcess/mac/WKFullScreenWindowController.mm:
     132        (-[WKFullScreenWindowController enterFullScreen:]): Ditto.
     133        * UIProcess/mac/WebPopupMenuProxyMac.mm:
     134        (WebKit::WebPopupMenuProxyMac::showPopupMenu): Ditto.
     135        * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
     136        (didCreatePage): Ditto.
     137        (willDestroyPage): Ditto.
     138        (setUpBundleClient): Ditto.
     139        * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
     140        (didStartProvisionalLoadForFrame): Ditto.
     141        (didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
     142        (didFinishLoadForFrame): Ditto.
     143        (globalObjectIsAvailableForFrame): Ditto.
     144        (didRemoveFrameFromHierarchy): Ditto.
     145        (didCommitLoadForFrame): Ditto.
     146        (didFinishDocumentLoadForFrame): Ditto.
     147        (didFailProvisionalLoadWithErrorForFrame): Ditto.
     148        (didFailLoadWithErrorForFrame): Ditto.
     149        (didSameDocumentNavigationForFrame): Ditto.
     150        (didLayoutForFrame): Ditto.
     151        (didReachLayoutMilestone): Ditto.
     152        (didFirstVisuallyNonEmptyLayoutForFrame): Ditto.
     153        (didHandleOnloadEventsForFrame): Ditto.
     154        (userAgentForURL): Ditto.
     155        (setUpPageLoaderClient): Ditto.
     156        (willSendRequestForFrame): Ditto.
     157        (didInitiateLoadForResource): Ditto.
     158        (didFinishLoadForResource): Ditto.
     159        (didFailLoadForResource): Ditto.
     160        (setUpResourceLoadClient): Ditto.
     161        * WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
     162        (WebKit::InjectedBundle::initialize): Ditto.
     163        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
     164        (WebKit::NetscapePlugin::popUpContextMenu): Ditto.
     165
     166        * WebProcess/Plugins/PDF/PDFPlugin.h: Put functions that return NSData inside
     167        an #ifdef __OBJC__ and use __bridge for cast.
     168
     169        * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
     170        (WebKit::WebDragClient::declareAndWriteDragImage): Use __bridge for cast.
     171
     172        * WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:
     173        (WebKit::PlatformCALayerRemoteCustom::contents const): Added a bridging cast.
     174        (WebKit::PlatformCALayerRemoteCustom::setContents): Use __bridge for cast.
     175        * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
     176        (WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom): Ditto.
     177        * WebProcess/WebPage/mac/WebPageMac.mm:
     178        (WebKit::WebPage::setTopOverhangImage): Ditto.
     179        (WebKit::WebPage::setBottomOverhangImage): Ditto.
     180
    11812018-06-05  Youenn Fablet  <youenn@apple.com>
    2182
  • trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

    r232352 r232520  
    678678
    679679    if (auto& data = globalSourceApplicationAuditTokenData())
    680         configuration._sourceApplicationAuditTokenData = (NSData *)data.get();
     680        configuration._sourceApplicationAuditTokenData = (__bridge NSData *)data.get();
    681681
    682682    auto& sourceApplicationBundleIdentifier = globalSourceApplicationBundleIdentifier();
  • trunk/Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm

    r232303 r232520  
    9898
    9999    if ([proxySettings count] > 0)
    100         _CFNetworkSetOverrideSystemProxySettings((CFDictionaryRef)proxySettings);
     100        _CFNetworkSetOverrideSystemProxySettings((__bridge CFDictionaryRef)proxySettings);
    101101}
    102102
     
    116116void NetworkProcess::allowSpecificHTTPSCertificateForHost(const CertificateInfo& certificateInfo, const String& host)
    117117{
    118     [NSURLRequest setAllowsSpecificHTTPSCertificate:(NSArray *)certificateInfo.certificateChain() forHost:(NSString *)host];
     118    [NSURLRequest setAllowsSpecificHTTPSCertificate:(__bridge NSArray *)certificateInfo.certificateChain() forHost:(NSString *)host];
    119119}
    120120
  • trunk/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm

    r232239 r232520  
    269269
    270270    default:
    271         WebKit::setCrashReportApplicationSpecificInformation((CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x, message '%s::%s'", kr, message->messageReceiverName().data(), message->messageName().data()]);
     271        WebKit::setCrashReportApplicationSpecificInformation((__bridge CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x, message '%s::%s'", kr, message->messageReceiverName().data(), message->messageName().data()]);
    272272        CRASH();
    273273    }
     
    502502    if (kr != MACH_MSG_SUCCESS) {
    503503#if !ASSERT_DISABLED
    504         WebKit::setCrashReportApplicationSpecificInformation((CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x from mach_msg, receive port is %x", kr, machPort]);
     504        WebKit::setCrashReportApplicationSpecificInformation((__bridge CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x from mach_msg, receive port is %x", kr, machPort]);
    505505#endif
    506506        ASSERT_NOT_REACHED();
  • trunk/Source/WebKit/Platform/mac/StringUtilities.mm

    r228218 r232520  
    6363    NSString *countryCode = [[[NSLocale currentLocale] objectForKey:NSLocaleCountryCode] lowercaseString];
    6464
    65     RetainPtr<CFPhoneNumberRef> phoneNumber = adoptCF(CFPhoneNumberCreate(kCFAllocatorDefault, (CFStringRef)originalPhoneNumber, (CFStringRef)countryCode));
     65    RetainPtr<CFPhoneNumberRef> phoneNumber = adoptCF(CFPhoneNumberCreate(kCFAllocatorDefault, (__bridge CFStringRef)originalPhoneNumber, (__bridge CFStringRef)countryCode));
    6666    if (!phoneNumber)
    6767        return originalPhoneNumber;
     
    7171        phoneNumberString = CFPhoneNumberCopyUnformattedRepresentation(phoneNumber.get());
    7272
    73     return [(NSString *)phoneNumberString autorelease];
     73    return CFBridgingRelease(phoneNumberString);
    7474}
    7575
  • trunk/Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectInterface.mm

    r223238 r232520  
    163163{
    164164    unsigned conformingProtocolCount;
    165     Protocol** conformingProtocols = protocol_copyProtocolList(interface->_protocol, &conformingProtocolCount);
     165    auto conformingProtocols = protocol_copyProtocolList(interface->_protocol, &conformingProtocolCount);
    166166
    167167    for (unsigned i = 0; i < conformingProtocolCount; ++i) {
    168         Protocol* conformingProtocol = conformingProtocols[i];
    169 
     168        auto conformingProtocol = conformingProtocols[i];
    170169        if (conformingProtocol == @protocol(NSObject))
    171170            continue;
    172 
    173171        initializeMethods(interface, conformingProtocol);
    174172    }
  • trunk/Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm

    r211736 r232520  
    148148            [NSException raise:NSInvalidArgumentException format:@"A NULL reply block was passed into a message. (%s)", sel_getName(invocation.selector)];
    149149
    150         const char* replyBlockSignature = _Block_signature(replyBlock);
     150        const char* replyBlockSignature = _Block_signature((__bridge void*)replyBlock);
    151151
    152152        if (strcmp([NSMethodSignature signatureWithObjCTypes:replyBlockSignature].methodReturnType, "v"))
  • trunk/Source/WebKit/Shared/API/c/cf/WKStringCF.mm

    r167114 r232520  
    5151#if WK_API_ENABLED
    5252    // Since WKNSString is an internal class with no subclasses, we can do a simple equality check.
    53     if (object_getClass((NSString *)cfString) == wkNSStringClass())
     53    if (object_getClass((__bridge NSString *)cfString) == wkNSStringClass())
    5454        return toAPI(static_cast<API::String*>(&[(WKNSString *)[(NSString *)cfString retain] _apiObject]));
    5555#endif
  • trunk/Source/WebKit/Shared/API/c/cf/WKURLCF.mm

    r167114 r232520  
    5555#if WK_API_ENABLED
    5656    // Since WKNSURL is an internal class with no subclasses, we can do a simple equality check.
    57     if (object_getClass((NSURL *)cfURL) == wkNSURLClass())
     57    if (object_getClass((__bridge NSURL *)cfURL) == wkNSURLClass())
    5858        return toAPI(static_cast<API::URL*>(&[(WKNSURL *)[(NSURL *)cfURL retain] _apiObject]));
    5959#endif
  • trunk/Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm

    r232165 r232520  
    8484                if (!certificate)
    8585                    return;
    86                 [certificates addObject:(id)certificate.get()];
     86                [certificates addObject:(__bridge id)certificate.get()];
    8787            }
    8888        }
  • trunk/Source/WebKit/Shared/Cocoa/DataDetectionResult.mm

    r227550 r232520  
    4444    auto archiver = secureArchiver();
    4545    [archiver encodeObject:results.get() forKey:@"dataDetectorResults"];
    46     IPC::encode(encoder, reinterpret_cast<CFDataRef>(archiver.get().encodedData));
     46    IPC::encode(encoder, (__bridge CFDataRef)archiver.get().encodedData);
    4747}
    4848
     
    5353        return false;
    5454
    55     auto unarchiver = secureUnarchiverFromData((NSData *)data.get());
     55    auto unarchiver = secureUnarchiverFromData((__bridge NSData *)data.get());
    5656    @try {
    5757        result.results = [unarchiver decodeObjectOfClasses:[NSSet setWithArray:@[ [NSArray class], getDDScannerResultClass()] ] forKey:@"dataDetectorResults"];
  • trunk/Source/WebKit/Shared/Cocoa/WKNSError.mm

    r160971 r232520  
    3535- (NSObject *)_web_createTarget
    3636{
    37     return [(NSError *)static_cast<API::Error*>(&self._apiObject)->platformError().cfError() copy];
     37    return [(__bridge NSError *)static_cast<API::Error*>(&self._apiObject)->platformError().cfError() copy];
    3838}
    3939
  • trunk/Source/WebKit/Shared/Cocoa/WKNSURLExtras.mm

    r232281 r232520  
    5151{
    5252    CString originalData;
    53     getURLBytes((CFURLRef)self, originalData);
     53    getURLBytes((__bridge CFURLRef)self, originalData);
    5454    return String::fromUTF8(originalData);
    5555}
  • trunk/Source/WebKit/Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h

    r226308 r232520  
    8484    ChildProcessInitializationParameters parameters;
    8585    if (priorityBoostMessage)
    86         parameters.priorityBoostMessage = adoptOSObject(xpc_retain(priorityBoostMessage));
     86        parameters.priorityBoostMessage = priorityBoostMessage;
    8787
    8888    if (!delegate.getConnectionIdentifier(parameters.connectionIdentifier))
  • trunk/Source/WebKit/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm

    r230714 r232520  
    6060                InitializerFunction initializerFunctionPtr = reinterpret_cast<InitializerFunction>(CFBundleGetFunctionPointerForName(webKitBundle, entryPointFunctionName));
    6161                if (!initializerFunctionPtr) {
    62                     NSLog(@"Unable to find entry point in WebKit.framework with name: %@", (NSString *)entryPointFunctionName);
     62                    NSLog(@"Unable to find entry point in WebKit.framework with name: %@", (__bridge NSString *)entryPointFunctionName);
    6363                    exit(EXIT_FAILURE);
    6464                }
  • trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm

    r230269 r232520  
    412412        case LayerContentsType::CAMachPort:
    413413            ASSERT(m_frontBufferSendRight);
    414             layer.contents = (id)adoptCF(CAMachPortCreate(m_frontBufferSendRight.leakSendRight())).get();
     414            layer.contents = (__bridge id)adoptCF(CAMachPortCreate(m_frontBufferSendRight.leakSendRight())).get();
    415415            break;
    416416        }
     
    420420
    421421    ASSERT(!acceleratesDrawing());
    422     layer.contents = (id)m_frontBuffer.bitmap->makeCGImageCopy().get();
     422    layer.contents = (__bridge id)m_frontBuffer.bitmap->makeCGImageCopy().get();
    423423}
    424424
  • trunk/Source/WebKit/Shared/cf/ArgumentCodersCF.cpp

    r231264 r232520  
    625625        // CFURL can't hold an empty URL, unlike NSURL.
    626626        // FIXME: This discards base URL, which seems incorrect.
    627         result = reinterpret_cast<CFURLRef>([NSURL URLWithString:@""]);
     627        result = (__bridge CFURLRef)[NSURL URLWithString:@""];
    628628        return true;
    629629    }
  • trunk/Source/WebKit/Shared/mac/ArgumentCodersMac.mm

    r225811 r232520  
    244244    auto fontClass = [UIFont class];
    245245#endif
    246     return ![value isKindOfClass:fontClass] || isSerializableFont(reinterpret_cast<CTFontRef>(value));
     246    return ![value isKindOfClass:fontClass] || isSerializableFont((__bridge CTFontRef)value);
    247247}
    248248
     
    426426void encode(Encoder& encoder, NSNumber *number)
    427427{
    428     encode(encoder, (CFNumberRef)number);
     428    encode(encoder, (__bridge CFNumberRef)number);
    429429}
    430430
     
    441441void encode(Encoder& encoder, NSString *string)
    442442{
    443     encode(encoder, (CFStringRef)string);
     443    encode(encoder, (__bridge CFStringRef)string);
    444444}
    445445
     
    493493void encode(Encoder& encoder, NSDate *date)
    494494{
    495     encode(encoder, (CFDateRef)date);
     495    encode(encoder, (__bridge CFDateRef)date);
    496496}
    497497
     
    508508void encode(Encoder& encoder, NSData *data)
    509509{
    510     encode(encoder, (CFDataRef)data);
     510    encode(encoder, (__bridge CFDataRef)data);
    511511}
    512512
     
    523523void encode(Encoder& encoder, NSURL *URL)
    524524{
    525     encode(encoder, (CFURLRef)URL);
     525    encode(encoder, (__bridge CFURLRef)URL);
    526526}
    527527
  • trunk/Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm

    r230893 r232520  
    322322    [userInfo enumerateKeysAndObjectsUsingBlock:^(id key, id value, BOOL*) {
    323323        if ([value isKindOfClass:[NSString class]] || [value isKindOfClass:[NSURL class]] || [value isKindOfClass:[NSNumber class]])
    324             CFDictionarySetValue(filteredUserInfo.get(), key, value);
     324            CFDictionarySetValue(filteredUserInfo.get(), (__bridge CFTypeRef)key, (__bridge CFTypeRef)value);
    325325    }];
    326326
     
    329329        ASSERT(^{
    330330            for (id object in clientIdentityAndCertificates) {
    331                 if (CFGetTypeID(object) != SecIdentityGetTypeID() && CFGetTypeID(object) != SecCertificateGetTypeID())
     331                if (CFGetTypeID((__bridge CFTypeRef)object) != SecIdentityGetTypeID() && CFGetTypeID((__bridge CFTypeRef)object) != SecCertificateGetTypeID())
    332332                    return false;
    333333            }
     
    338338        id clientCertificates = [NSMutableArray arrayWithCapacity:clientIdentityAndCertificates.count];
    339339        for (id object in clientIdentityAndCertificates) {
    340             if (CFGetTypeID(object) != SecIdentityGetTypeID()) {
     340            if (CFGetTypeID((__bridge CFTypeRef)object) != SecIdentityGetTypeID()) {
    341341                [clientCertificates addObject:object];
    342342                continue;
     
    352352                break;
    353353            }
    354             [clientCertificates addObject:(id)certificate];
     354            [clientCertificates addObject:(__bridge id)certificate];
    355355        }
    356         CFDictionarySetValue(filteredUserInfo.get(), @"NSErrorClientCertificateChainKey", clientCertificates);
     356        CFDictionarySetValue(filteredUserInfo.get(), CFSTR("NSErrorClientCertificateChainKey"), (__bridge CFTypeRef)clientCertificates);
    357357    }
    358358
    359359    id peerCertificateChain = [userInfo objectForKey:@"NSErrorPeerCertificateChainKey"];
    360360    if (!peerCertificateChain) {
    361         if (SecTrustRef peerTrust = (SecTrustRef)[userInfo objectForKey:NSURLErrorFailingURLPeerTrustErrorKey]) {
     361        if (SecTrustRef peerTrust = (__bridge SecTrustRef)[userInfo objectForKey:NSURLErrorFailingURLPeerTrustErrorKey]) {
    362362            CFIndex count = SecTrustGetCertificateCount(peerTrust);
    363363            peerCertificateChain = [NSMutableArray arrayWithCapacity:count];
    364364            for (CFIndex i = 0; i < count; ++i)
    365                 [peerCertificateChain addObject:(id)SecTrustGetCertificateAtIndex(peerTrust, i)];
     365                [peerCertificateChain addObject:(__bridge id)SecTrustGetCertificateAtIndex(peerTrust, i)];
    366366        }
    367367    }
    368368    ASSERT(!peerCertificateChain || [peerCertificateChain isKindOfClass:[NSArray class]]);
    369369    if (peerCertificateChain)
    370         CFDictionarySetValue(filteredUserInfo.get(), @"NSErrorPeerCertificateChainKey", peerCertificateChain);
     370        CFDictionarySetValue(filteredUserInfo.get(), CFSTR("NSErrorPeerCertificateChainKey"), (__bridge CFTypeRef)peerCertificateChain);
    371371
    372372#if HAVE(SEC_TRUST_SERIALIZATION)
    373     if (SecTrustRef peerTrust = (SecTrustRef)[userInfo objectForKey:NSURLErrorFailingURLPeerTrustErrorKey])
    374         CFDictionarySetValue(filteredUserInfo.get(), NSURLErrorFailingURLPeerTrustErrorKey, peerTrust);
     373    if (SecTrustRef peerTrust = (__bridge SecTrustRef)[userInfo objectForKey:NSURLErrorFailingURLPeerTrustErrorKey])
     374        CFDictionarySetValue(filteredUserInfo.get(), (__bridge CFStringRef)NSURLErrorFailingURLPeerTrustErrorKey, peerTrust);
    375375#endif
    376376
     
    414414
    415415        auto mutableUserInfo = adoptCF(CFDictionaryCreateMutableCopy(kCFAllocatorDefault, CFDictionaryGetCount(userInfo.get()) + 1, userInfo.get()));
    416         CFDictionarySetValue(mutableUserInfo.get(), NSUnderlyingErrorKey, underlyingNSError.get());
     416        CFDictionarySetValue(mutableUserInfo.get(), (__bridge CFStringRef)NSUnderlyingErrorKey, (__bridge CFTypeRef)underlyingNSError.get());
    417417        userInfo = WTFMove(mutableUserInfo);
    418418    }
    419419
    420     nsError = adoptNS([[NSError alloc] initWithDomain:domain code:code userInfo:(NSDictionary *)userInfo.get()]);
     420    nsError = adoptNS([[NSError alloc] initWithDomain:domain code:code userInfo:(__bridge NSDictionary *)userInfo.get()]);
    421421    return true;
    422422}
     
    436436    auto archiver = secureArchiver();
    437437    [archiver encodeObject:space.nsSpace() forKey:@"protectionSpace"];
    438     IPC::encode(encoder, reinterpret_cast<CFDataRef>(archiver.get().encodedData));
     438    IPC::encode(encoder, (__bridge CFDataRef)archiver.get().encodedData);
    439439}
    440440
     
    445445        return false;
    446446
    447     auto unarchiver = secureUnarchiverFromData((NSData *)data.get());
     447    auto unarchiver = secureUnarchiverFromData((__bridge NSData *)data.get());
    448448    @try {
    449449        if (RetainPtr<NSURLProtectionSpace> nsSpace = [unarchiver decodeObjectOfClass:[NSURLProtectionSpace class] forKey:@"protectionSpace"])
     
    468468        if (NSArray *certificates = nsCredential.certificates) {
    469469            encoder << true;
    470             IPC::encode(encoder, reinterpret_cast<CFArrayRef>(certificates));
     470            IPC::encode(encoder, (__bridge CFArrayRef)certificates);
    471471        } else
    472472            encoder << false;
     
    480480    auto archiver = secureArchiver();
    481481    [archiver encodeObject:nsCredential forKey:@"credential"];
    482     IPC::encode(encoder, reinterpret_cast<CFDataRef>(archiver.get().encodedData));
     482    IPC::encode(encoder, (__bridge CFArrayRef)archiver.get().encodedData);
    483483}
    484484
     
    508508            return false;
    509509
    510         credential = Credential(adoptNS([[NSURLCredential alloc] initWithIdentity:identity.get() certificates:(NSArray *)certificates.get() persistence:(NSURLCredentialPersistence)persistence]).get());
     510        credential = Credential(adoptNS([[NSURLCredential alloc] initWithIdentity:identity.get() certificates:(__bridge NSArray *)certificates.get() persistence:(NSURLCredentialPersistence)persistence]).get());
    511511        return true;
    512512    }
     
    516516        return false;
    517517
    518     auto unarchiver = secureUnarchiverFromData((NSData *)data.get());
     518    auto unarchiver = secureUnarchiverFromData((__bridge NSData *)data.get());
    519519    @try {
    520520        if (RetainPtr<NSURLCredential> nsCredential = [unarchiver decodeObjectOfClass:[NSURLCredential class] forKey:@"credential"])
     
    575575
    576576#if ENABLE(CONTENT_FILTERING)
     577
    577578void ArgumentCoder<ContentFilterUnblockHandler>::encode(Encoder& encoder, const ContentFilterUnblockHandler& contentFilterUnblockHandler)
    578579{
    579580    auto archiver = secureArchiver();
    580581    contentFilterUnblockHandler.encode(archiver.get());
    581     IPC::encode(encoder, reinterpret_cast<CFDataRef>(archiver.get().encodedData));
     582    IPC::encode(encoder, (__bridge CFDataRef)archiver.get().encodedData);
    582583}
    583584
     
    588589        return false;
    589590
    590     auto unarchiver = secureUnarchiverFromData((NSData *)data.get());
     591    auto unarchiver = secureUnarchiverFromData((__bridge NSData *)data.get());
    591592    if (!ContentFilterUnblockHandler::decode(unarchiver.get(), contentFilterUnblockHandler))
    592593        return false;
     
    595596    return true;
    596597}
     598
    597599#endif
    598600
     
    612614        [archiver encodeObject:target.avOutputContext() forKey:deviceContextKey()];
    613615
    614     IPC::encode(encoder, reinterpret_cast<CFDataRef>(archiver.get().encodedData));
     616    IPC::encode(encoder, (__bridge CFDataRef)archiver.get().encodedData);
    615617}
    616618
     
    624626        return false;
    625627
    626     auto unarchiver = secureUnarchiverFromData((NSData *)data.get());
     628    auto unarchiver = secureUnarchiverFromData((__bridge NSData *)data.get());
    627629
    628630    AVOutputContext *context = nil;
     
    639641    return true;
    640642}
     643
    641644#endif
    642645
  • trunk/Source/WebKit/Shared/mac/WebHitTestResultData.mm

    r227550 r232520  
    4949    [archiver encodeObject:detectedDataActionContext.get() forKey:@"actionContext"];
    5050
    51     IPC::encode(encoder, reinterpret_cast<CFDataRef>(archiver.get().encodedData));
     51    IPC::encode(encoder, (__bridge CFDataRef)archiver.get().encodedData);
    5252
    5353    encoder << detectedDataBoundingBox;
     
    7474        return false;
    7575
    76     auto unarchiver = secureUnarchiverFromData((NSData *)data.get());
     76    auto unarchiver = secureUnarchiverFromData((__bridge NSData *)data.get());
    7777    @try {
    7878        hitTestResultData.detectedDataActionContext = [unarchiver decodeObjectOfClass:getDDActionContextClass() forKey:@"actionContext"];
  • trunk/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm

    r204462 r232520  
    5050    return false;
    5151#else
    52     return WebCore::PluginBlacklist::isPluginUpdateAvailable((NSString *)adoptCF(WKStringCopyCFString(kCFAllocatorDefault, plugInBundleIdentifierRef)).get());
     52    return WebCore::PluginBlacklist::isPluginUpdateAvailable((__bridge NSString *)adoptCF(WKStringCopyCFString(kCFAllocatorDefault, plugInBundleIdentifierRef)).get());
    5353#endif
    5454}
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm

    r232082 r232520  
    297297{
    298298    if (WebFrameProxy* mainFrame = _page->mainFrame())
    299         return mainFrame->certificateInfo() ? (NSArray *)mainFrame->certificateInfo()->certificateInfo().certificateChain() : nil;
     299        return mainFrame->certificateInfo() ? (__bridge NSArray *)mainFrame->certificateInfo()->certificateInfo().certificateChain() : nil;
    300300
    301301    return nil;
     
    329329        return;
    330330
    331     WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     331    auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    332332    auto loadDelegate = browsingContext->_loadDelegate.get();
    333333
     
    341341        return;
    342342
    343     WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     343    auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    344344    auto loadDelegate = browsingContext->_loadDelegate.get();
    345345
     
    353353        return;
    354354
    355     WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     355    auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    356356    auto loadDelegate = browsingContext->_loadDelegate.get();
    357357
     
    365365        return;
    366366
    367     WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     367    auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    368368    auto loadDelegate = browsingContext->_loadDelegate.get();
    369369
     
    377377        return;
    378378
    379     WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     379    auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    380380    auto loadDelegate = browsingContext->_loadDelegate.get();
    381381
     
    389389        return;
    390390
    391     WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     391    auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    392392    auto loadDelegate = browsingContext->_loadDelegate.get();
    393393
     
    398398static bool canAuthenticateAgainstProtectionSpaceInFrame(WKPageRef page, WKFrameRef frame, WKProtectionSpaceRef protectionSpace, const void *clientInfo)
    399399{
    400     WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     400    auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    401401    auto loadDelegate = browsingContext->_loadDelegate.get();
    402402
     
    409409static void didReceiveAuthenticationChallengeInFrame(WKPageRef page, WKFrameRef frame, WKAuthenticationChallengeRef authenticationChallenge, const void *clientInfo)
    410410{
    411     WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     411    auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    412412    auto loadDelegate = browsingContext->_loadDelegate.get();
    413413
     
    418418static void didStartProgress(WKPageRef page, const void* clientInfo)
    419419{
    420     WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     420    auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    421421    auto loadDelegate = browsingContext->_loadDelegate.get();
    422422
     
    427427static void didChangeProgress(WKPageRef page, const void* clientInfo)
    428428{
    429     WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     429    auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    430430    auto loadDelegate = browsingContext->_loadDelegate.get();
    431431
     
    436436static void didFinishProgress(WKPageRef page, const void* clientInfo)
    437437{
    438     WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     438    auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    439439    auto loadDelegate = browsingContext->_loadDelegate.get();
    440440
     
    445445static void didChangeBackForwardList(WKPageRef page, WKBackForwardListItemRef addedItem, WKArrayRef removedItems, const void *clientInfo)
    446446{
    447     WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     447    auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    448448    auto loadDelegate = browsingContext->_loadDelegate.get();
    449449
     
    458458static void processDidCrash(WKPageRef page, const void* clientInfo)
    459459{
    460     WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     460    auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    461461    auto loadDelegate = browsingContext->_loadDelegate.get();
    462462
     
    471471
    472472    loaderClient.base.version = 4;
    473     loaderClient.base.clientInfo = browsingContext;
     473    loaderClient.base.clientInfo = (__bridge void*)browsingContext;
    474474    loaderClient.didStartProvisionalLoadForFrame = didStartProvisionalLoadForFrame;
    475475    loaderClient.didReceiveServerRedirectForProvisionalLoadForFrame = didReceiveServerRedirectForProvisionalLoadForFrame;
     
    521521
    522522    policyClient.base.version = 2;
    523     policyClient.base.clientInfo = browsingContext;
     523    policyClient.base.clientInfo = (__bridge void*)browsingContext;
    524524
    525525    policyClient.decidePolicyForNavigationAction = [](WKPageRef page, WKFrameRef frame, WKFrameNavigationType navigationType, WKEventModifiers modifiers, WKEventMouseButton mouseButton, WKFrameRef originatingFrame, WKURLRequestRef originalRequest, WKURLRequestRef request, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo)
    526526    {
    527         WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     527        auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    528528        auto policyDelegate = browsingContext->_policyDelegate.get();
    529529
     
    550550    policyClient.decidePolicyForNewWindowAction = [](WKPageRef page, WKFrameRef frame, WKFrameNavigationType navigationType, WKEventModifiers modifiers, WKEventMouseButton mouseButton, WKURLRequestRef request, WKStringRef frameName, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo)
    551551    {
    552         WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     552        auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    553553        auto policyDelegate = browsingContext->_policyDelegate.get();
    554554
     
    570570    policyClient.decidePolicyForResponse = [](WKPageRef page, WKFrameRef frame, WKURLResponseRef response, WKURLRequestRef request, bool canShowMIMEType, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo)
    571571    {
    572         WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
     572        auto browsingContext = (__bridge WKBrowsingContextController *)clientInfo;
    573573        auto policyDelegate = browsingContext->_policyDelegate.get();
    574574
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.mm

    r216348 r232520  
    125125    for (id entry in array) {
    126126        if ([entry isKindOfClass:[NSString class]])
    127             strings.uncheckedAppend(adoptRef(toImpl(WKStringCreateWithCFString((CFStringRef)entry))));
     127            strings.uncheckedAppend(adoptRef(toImpl(WKStringCreateWithCFString((__bridge CFStringRef)entry))));
    128128    }
    129129
     
    136136        CRASH();
    137137
    138     WKRetainPtr<WKStringRef> wkSource = adoptWK(WKStringCreateWithCFString((CFStringRef)source));
    139     WKRetainPtr<WKURLRef> wkBaseURL = adoptWK(WKURLCreateWithCFURL((CFURLRef)baseURL));
     138    WKRetainPtr<WKStringRef> wkSource = adoptWK(WKStringCreateWithCFString((__bridge CFStringRef)source));
     139    WKRetainPtr<WKURLRef> wkBaseURL = adoptWK(WKURLCreateWithCFURL((__bridge CFURLRef)baseURL));
    140140    auto wkWhitelist = createWKArray(whitelist);
    141141    auto wkBlacklist = createWKArray(blacklist);
     
    155155        CRASH();
    156156
    157     WKRetainPtr<WKStringRef> wkSource = adoptWK(WKStringCreateWithCFString((CFStringRef)source));
    158     WKRetainPtr<WKURLRef> wkBaseURL = adoptWK(WKURLCreateWithCFURL((CFURLRef)baseURL));
     157    WKRetainPtr<WKStringRef> wkSource = adoptWK(WKStringCreateWithCFString((__bridge CFStringRef)source));
     158    WKRetainPtr<WKURLRef> wkBaseURL = adoptWK(WKURLCreateWithCFURL((__bridge CFURLRef)baseURL));
    159159    auto wkWhitelist = createWKArray(whitelist);
    160160    auto wkBlacklist = createWKArray(blacklist);
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm

    r232082 r232520  
    5252static void didReceiveMessage(WKConnectionRef, WKStringRef messageName, WKTypeRef messageBody, const void* clientInfo)
    5353{
    54     WKConnection *connection = (WKConnection *)clientInfo;
     54    auto connection = (__bridge WKConnection *)clientInfo;
    5555    auto delegate = connection->_delegate.get();
    5656
     
    6464static void didClose(WKConnectionRef, const void* clientInfo)
    6565{
    66     WKConnection *connection = (WKConnection *)clientInfo;
     66    auto connection = (__bridge WKConnection *)clientInfo;
    6767    auto delegate = connection->_delegate.get();
    6868
     
    7777
    7878    client.base.version = 0;
    79     client.base.clientInfo = wrapper;
     79    client.base.clientInfo = (__bridge void*)wrapper;
    8080    client.didReceiveMessage = didReceiveMessage;
    8181    client.didClose = didClose;
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.mm

    r232082 r232520  
    6767static void didCreateConnection(WKContextRef, WKConnectionRef connectionRef, const void* clientInfo)
    6868{
    69     WKProcessGroup *processGroup = (WKProcessGroup *)clientInfo;
     69    auto processGroup = (__bridge WKProcessGroup *)clientInfo;
    7070    auto delegate = processGroup->_delegate.get();
    7171
     
    8888static WKTypeRef getInjectedBundleInitializationUserData(WKContextRef, const void* clientInfo)
    8989{
    90     WKProcessGroup *processGroup = (WKProcessGroup *)clientInfo;
     90    auto processGroup = (__bridge WKProcessGroup *)clientInfo;
    9191    auto delegate = processGroup->_delegate.get();
    9292
     
    106106
    107107    injectedBundleClient.base.version = 1;
    108     injectedBundleClient.base.clientInfo = processGroup;
     108    injectedBundleClient.base.clientInfo = (__bridge void*)processGroup;
    109109    injectedBundleClient.getInjectedBundleInitializationUserData = getInjectedBundleInitializationUserData;
    110110
     
    224224- (void)_setAllowsSpecificHTTPSCertificate:(NSArray *)certificateChain forHost:(NSString *)host
    225225{
    226     _processPool->allowSpecificHTTPSCertificateForHost(WebCertificateInfo::create(WebCore::CertificateInfo((CFArrayRef)certificateChain)).ptr(), host);
     226    _processPool->allowSpecificHTTPSCertificateForHost(WebCertificateInfo::create(WebCore::CertificateInfo((__bridge CFArrayRef)certificateChain)).ptr(), host);
    227227}
    228228
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm

    r232082 r232520  
    180180- (void)_setAllowsSpecificHTTPSCertificate:(NSArray *)certificateChain forHost:(NSString *)host
    181181{
    182     _processPool->allowSpecificHTTPSCertificateForHost(WebKit::WebCertificateInfo::create(WebCore::CertificateInfo((CFArrayRef)certificateChain)).ptr(), host);
     182    _processPool->allowSpecificHTTPSCertificateForHost(WebKit::WebCertificateInfo::create(WebCore::CertificateInfo((__bridge CFArrayRef)certificateChain)).ptr(), host);
    183183}
    184184
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm

    r231264 r232520  
    303303- (void)_setProxyConfiguration:(NSDictionary *)configuration
    304304{
    305     _websiteDataStore->websiteDataStore().setProxyConfiguration((CFDictionaryRef)configuration);
     305    _websiteDataStore->websiteDataStore().setProxyConfiguration((__bridge CFDictionaryRef)configuration);
    306306}
    307307
    308308- (NSDictionary *)_proxyConfiguration
    309309{
    310     return (NSDictionary *)_websiteDataStore->websiteDataStore().proxyConfiguration();
     310    return (__bridge NSDictionary *)_websiteDataStore->websiteDataStore().proxyConfiguration();
    311311}
    312312
  • trunk/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm

    r224696 r232520  
    198198    self.layer.sublayers = @[];
    199199    self.layer.contentsGravity = kCAGravityResizeAspectFill;
    200     self.layer.contents = (id)image;
     200    self.layer.contents = (__bridge id)image;
    201201
    202202    // If we got a scale change while snapshotting, we'll take another snapshot once the first one returns.
  • trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentFilter.mm

    r216809 r232520  
    2929#if WK_API_ENABLED
    3030
     31#include "WKContentRuleListInternal.h"
    3132#include "WebCompiledContentRuleList.h"
    3233#include <WebCore/ContentExtensionCompiler.h>
  • trunk/Source/WebKit/UIProcess/Authentication/mac/WebCredentialMac.mm

    r231916 r232520  
    6868    ASSERT(certificateInfo.type() == CertificateInfo::Type::CertificateChain);
    6969    CFIndex chainCount = CFArrayGetCount(certificateInfo.certificateChain());
    70     return chainCount > 1 ? [(NSArray *)certificateInfo.certificateChain() subarrayWithRange:NSMakeRange(1, chainCount - 1)] : nil;
     70    return chainCount > 1 ? [(__bridge NSArray *)certificateInfo.certificateChain() subarrayWithRange:NSMakeRange(1, chainCount - 1)] : nil;
    7171}
    7272
  • trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm

    r232312 r232520  
    481481String WebProcessPool::legacyPlatformDefaultNetworkCacheDirectory()
    482482{
    483     RetainPtr<NSString> cachePath = adoptNS((NSString *)_CFURLCacheCopyCacheDirectory([[NSURLCache sharedURLCache] _CFURLCache]));
     483    NSString *cachePath = CFBridgingRelease(_CFURLCacheCopyCacheDirectory([[NSURLCache sharedURLCache] _CFURLCache]));
    484484    if (!cachePath)
    485485        cachePath = @"~/Library/Caches/com.apple.WebKit.WebProcess";
     
    591591    dispatch_once(&once, ^{
    592592        NSString *identifier = [NSString stringWithFormat:@"%@.PrivateBrowsing", [[NSBundle mainBundle] bundleIdentifier]];
    593 
    594         session = createPrivateStorageSession((CFStringRef)identifier);
     593        session = createPrivateStorageSession((__bridge CFStringRef)identifier);
    595594    });
    596595
  • trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm

    r232239 r232520  
    38963896
    38973897    if ([type isEqual:WebCore::legacyTIFFPasteboardType()] && m_promisedImage) {
    3898         [pasteboard setData:(NSData *)m_promisedImage->tiffRepresentation() forType:WebCore::legacyTIFFPasteboardType()];
     3898        [pasteboard setData:(__bridge NSData *)m_promisedImage->tiffRepresentation() forType:WebCore::legacyTIFFPasteboardType()];
    38993899        m_promisedImage = nullptr;
    39003900    }
  • trunk/Source/WebKit/UIProcess/Plugins/mac/PluginInfoStoreMac.mm

    r232169 r232520  
    6161
    6262    RetainPtr<CFStringRef> directoryCFString = directory.createCFString();
    63     NSArray *filenames = [[NSFileManager defaultManager] contentsOfDirectoryAtPath:(NSString *)directoryCFString.get() error:nil];
     63    NSArray *filenames = [[NSFileManager defaultManager] contentsOfDirectoryAtPath:(__bridge NSString *)directoryCFString.get() error:nil];
    6464    for (NSString *filename in filenames)
    65         pluginPaths.append([(NSString *)directoryCFString.get() stringByAppendingPathComponent:filename]);
     65        pluginPaths.append([(__bridge NSString *)directoryCFString.get() stringByAppendingPathComponent:filename]);
    6666   
    6767    return pluginPaths;
  • trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm

    r230730 r232520  
    295295{
    296296    if (layer.contents && CFGetTypeID(layer.contents) == CAMachPortGetTypeID()) {
    297         MachSendRight port = MachSendRight::create(CAMachPortGetPort((CAMachPortRef)layer.contents));
     297        MachSendRight port = MachSendRight::create(CAMachPortGetPort((__bridge CAMachPortRef)layer.contents));
    298298        auto surface = WebCore::IOSurface::createFromSendRight(WTFMove(port), sRGBColorSpaceRef());
    299299        layer.contents = surface ? surface->asLayerContents() : nil;
  • trunk/Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm

    r232416 r232520  
    616616        [m_swipeShadowLayer setName:@"Gesture Swipe Shadow Layer"];
    617617        [m_swipeShadowLayer setColors:@[
    618             (id)adoptCF(CGColorCreateGenericGray(0, 1.)).get(),
    619             (id)adoptCF(CGColorCreateGenericGray(0, 0.99)).get(),
    620             (id)adoptCF(CGColorCreateGenericGray(0, 0.98)).get(),
    621             (id)adoptCF(CGColorCreateGenericGray(0, 0.95)).get(),
    622             (id)adoptCF(CGColorCreateGenericGray(0, 0.92)).get(),
    623             (id)adoptCF(CGColorCreateGenericGray(0, 0.82)).get(),
    624             (id)adoptCF(CGColorCreateGenericGray(0, 0.71)).get(),
    625             (id)adoptCF(CGColorCreateGenericGray(0, 0.46)).get(),
    626             (id)adoptCF(CGColorCreateGenericGray(0, 0.35)).get(),
    627             (id)adoptCF(CGColorCreateGenericGray(0, 0.25)).get(),
    628             (id)adoptCF(CGColorCreateGenericGray(0, 0.17)).get(),
    629             (id)adoptCF(CGColorCreateGenericGray(0, 0.11)).get(),
    630             (id)adoptCF(CGColorCreateGenericGray(0, 0.07)).get(),
    631             (id)adoptCF(CGColorCreateGenericGray(0, 0.04)).get(),
    632             (id)adoptCF(CGColorCreateGenericGray(0, 0.01)).get(),
    633             (id)adoptCF(CGColorCreateGenericGray(0, 0.)).get(),
     618            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 1.)).get(),
     619            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.99)).get(),
     620            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.98)).get(),
     621            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.95)).get(),
     622            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.92)).get(),
     623            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.82)).get(),
     624            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.71)).get(),
     625            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.46)).get(),
     626            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.35)).get(),
     627            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.25)).get(),
     628            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.17)).get(),
     629            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.11)).get(),
     630            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.07)).get(),
     631            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.04)).get(),
     632            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.01)).get(),
     633            (__bridge id)adoptCF(CGColorCreateGenericGray(0, 0.)).get(),
    634634        ]];
    635635        [m_swipeShadowLayer setLocations:@[
  • trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm

    r231811 r232520  
    250250    }
    251251    [_webViewPlaceholder setTarget:nil];
    252     [_webViewPlaceholder setContents:(id)webViewContents.get()];
     252    [_webViewPlaceholder setContents:(__bridge id)webViewContents.get()];
    253253    self.savedConstraints = _webView.superview.constraints;
    254254    [self _replaceView:_webView with:_webViewPlaceholder.get()];
  • trunk/Source/WebKit/UIProcess/mac/WebPopupMenuProxyMac.mm

    r231980 r232520  
    103103    NSFont *font;
    104104    if (data.fontInfo.fontAttributeDictionary) {
    105         NSFontDescriptor *fontDescriptor = [NSFontDescriptor fontDescriptorWithFontAttributes:(NSDictionary *)data.fontInfo.fontAttributeDictionary.get()];
     105        NSFontDescriptor *fontDescriptor = [NSFontDescriptor fontDescriptorWithFontAttributes:(__bridge NSDictionary *)data.fontInfo.fontAttributeDictionary.get()];
    106106        font = [NSFont fontWithDescriptor:fontDescriptor size:((pageScaleFactor != 1) ? [fontDescriptor pointSize] * pageScaleFactor : 0)];
    107107    } else
  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm

    r218319 r232520  
    5555static void didCreatePage(WKBundleRef bundle, WKBundlePageRef page, const void* clientInfo)
    5656{
    57     WKWebProcessPlugInController *plugInController = (WKWebProcessPlugInController *)clientInfo;
     57    auto plugInController = (__bridge WKWebProcessPlugInController *)clientInfo;
    5858    id <WKWebProcessPlugIn> principalClassInstance = plugInController->_principalClassInstance.get();
    5959
     
    6464static void willDestroyPage(WKBundleRef bundle, WKBundlePageRef page, const void* clientInfo)
    6565{
    66     WKWebProcessPlugInController *plugInController = (WKWebProcessPlugInController *)clientInfo;
     66    auto plugInController = (__bridge WKWebProcessPlugInController *)clientInfo;
    6767    id <WKWebProcessPlugIn> principalClassInstance = plugInController->_principalClassInstance.get();
    6868
     
    7777
    7878    bundleClient.base.version = 1;
    79     bundleClient.base.clientInfo = plugInController;
     79    bundleClient.base.clientInfo = (__bridge void*)plugInController;
    8080    bundleClient.didCreatePage = didCreatePage;
    8181    bundleClient.willDestroyPage = willDestroyPage;
  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm

    r232082 r232520  
    8585static void didStartProvisionalLoadForFrame(WKBundlePageRef page, WKBundleFrameRef frame, WKTypeRef* userDataRef, const void *clientInfo)
    8686{
    87     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     87    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    8888    auto loadDelegate = pluginContextController->_loadDelegate.get();
    8989
     
    9494static void didReceiveServerRedirectForProvisionalLoadForFrame(WKBundlePageRef page, WKBundleFrameRef frame, WKTypeRef *userDataRef, const void *clientInfo)
    9595{
    96     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     96    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    9797    auto loadDelegate = pluginContextController->_loadDelegate.get();
    9898
     
    103103static void didFinishLoadForFrame(WKBundlePageRef page, WKBundleFrameRef frame, WKTypeRef* userData, const void *clientInfo)
    104104{
    105     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     105    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    106106    auto loadDelegate = pluginContextController->_loadDelegate.get();
    107107
     
    112112static void globalObjectIsAvailableForFrame(WKBundlePageRef page, WKBundleFrameRef frame, WKBundleScriptWorldRef scriptWorld, const void* clientInfo)
    113113{
    114     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     114    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    115115    auto loadDelegate = pluginContextController->_loadDelegate.get();
    116116
     
    121121static void didRemoveFrameFromHierarchy(WKBundlePageRef page, WKBundleFrameRef frame, WKTypeRef* userData, const void* clientInfo)
    122122{
    123     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     123    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    124124    auto loadDelegate = pluginContextController->_loadDelegate.get();
    125125
     
    130130static void didCommitLoadForFrame(WKBundlePageRef page, WKBundleFrameRef frame, WKTypeRef* userData, const void *clientInfo)
    131131{
    132     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     132    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    133133    auto loadDelegate = pluginContextController->_loadDelegate.get();
    134134
     
    139139static void didFinishDocumentLoadForFrame(WKBundlePageRef page, WKBundleFrameRef frame, WKTypeRef* userData, const void *clientInfo)
    140140{
    141     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     141    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    142142    auto loadDelegate = pluginContextController->_loadDelegate.get();
    143143
     
    148148static void didFailProvisionalLoadWithErrorForFrame(WKBundlePageRef page, WKBundleFrameRef frame, WKErrorRef wkError, WKTypeRef* userData, const void *clientInfo)
    149149{
    150     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     150    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    151151    auto loadDelegate = pluginContextController->_loadDelegate.get();
    152152
     
    157157static void didFailLoadWithErrorForFrame(WKBundlePageRef page, WKBundleFrameRef frame, WKErrorRef wkError, WKTypeRef* userData, const void *clientInfo)
    158158{
    159     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     159    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    160160    auto loadDelegate = pluginContextController->_loadDelegate.get();
    161161
     
    166166static void didSameDocumentNavigationForFrame(WKBundlePageRef page, WKBundleFrameRef frame, WKSameDocumentNavigationType type, WKTypeRef* userData, const void *clientInfo)
    167167{
    168     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     168    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    169169    auto loadDelegate = pluginContextController->_loadDelegate.get();
    170170
     
    180180static void didLayoutForFrame(WKBundlePageRef page, WKBundleFrameRef frame, const void* clientInfo)
    181181{
    182     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     182    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    183183    auto loadDelegate = pluginContextController->_loadDelegate.get();
    184184
     
    189189static void didReachLayoutMilestone(WKBundlePageRef page, WKLayoutMilestones milestones, WKTypeRef* userData, const void *clientInfo)
    190190{
    191     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     191    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    192192    auto loadDelegate = pluginContextController->_loadDelegate.get();
    193193
     
    198198static void didFirstVisuallyNonEmptyLayoutForFrame(WKBundlePageRef page, WKBundleFrameRef frame, WKTypeRef* userData, const void *clientInfo)
    199199{
    200     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     200    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    201201    auto loadDelegate = pluginContextController->_loadDelegate.get();
    202202
     
    207207static void didHandleOnloadEventsForFrame(WKBundlePageRef page, WKBundleFrameRef frame, const void* clientInfo)
    208208{
    209     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     209    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    210210    auto loadDelegate = pluginContextController->_loadDelegate.get();
    211211
     
    216216static WKStringRef userAgentForURL(WKBundleFrameRef frame, WKURLRef url, const void* clientInfo)
    217217{
    218     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     218    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    219219    auto loadDelegate = pluginContextController->_loadDelegate.get();
    220220   
     
    225225            return nullptr;
    226226
    227         WKStringRef wkString = WKStringCreateWithCFString((CFStringRef)string);
    228         return wkString;
     227        return WKStringCreateWithCFString((__bridge CFStringRef)string);
    229228    }
    230229   
     
    238237
    239238    client.base.version = 8;
    240     client.base.clientInfo = contextController;
     239    client.base.clientInfo = (__bridge void*)contextController;
    241240    client.didStartProvisionalLoadForFrame = didStartProvisionalLoadForFrame;
    242241    client.didReceiveServerRedirectForProvisionalLoadForFrame = didReceiveServerRedirectForProvisionalLoadForFrame;
     
    261260static WKURLRequestRef willSendRequestForFrame(WKBundlePageRef, WKBundleFrameRef frame, uint64_t resourceIdentifier, WKURLRequestRef request, WKURLResponseRef redirectResponse, const void* clientInfo)
    262261{
    263     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     262    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    264263    auto loadDelegate = pluginContextController->_loadDelegate.get();
    265264
     
    286285static void didInitiateLoadForResource(WKBundlePageRef, WKBundleFrameRef frame, uint64_t resourceIdentifier, WKURLRequestRef request, bool pageIsProvisionallyLoading, const void* clientInfo)
    287286{
    288     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     287    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    289288    auto loadDelegate = pluginContextController->_loadDelegate.get();
    290289
     
    299298static void didFinishLoadForResource(WKBundlePageRef, WKBundleFrameRef frame, uint64_t resourceIdentifier, const void* clientInfo)
    300299{
    301     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     300    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    302301    auto loadDelegate = pluginContextController->_loadDelegate.get();
    303302
     
    311310static void didFailLoadForResource(WKBundlePageRef, WKBundleFrameRef frame, uint64_t resourceIdentifier, WKErrorRef error, const void* clientInfo)
    312311{
    313     WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
     312    auto pluginContextController = (__bridge WKWebProcessPlugInBrowserContextController *)clientInfo;
    314313    auto loadDelegate = pluginContextController->_loadDelegate.get();
    315314
     
    328327
    329328    client.base.version = 1;
    330     client.base.clientInfo = contextController;
     329    client.base.clientInfo = (__bridge void*) contextController;
    331330    client.willSendRequestForFrame = willSendRequestForFrame;
    332331    client.didInitiateLoadForResource = didInitiateLoadForResource;
  • trunk/Source/WebKit/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm

    r231598 r232520  
    7474    }
    7575
    76     m_platformBundle = [[NSBundle alloc] initWithURL:(NSURL *)bundleURL.get()];
     76    m_platformBundle = [[NSBundle alloc] initWithURL:(__bridge NSURL *)bundleURL.get()];
    7777    if (!m_platformBundle) {
    7878        WTFLogAlways("InjectedBundle::load failed - Could not create the bundle.\n");
  • trunk/Source/WebKit/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm

    r230269 r232520  
    168168        ASSERT_NOT_REACHED();
    169169
    170     _NSPopUpCarbonMenu3(reinterpret_cast<NSMenu *>(npMenu), nil, nil, NSMakePoint(screenX, screenY), -1, nil, 0, nil, NSPopUpMenuTypeContext, nil);
     170    _NSPopUpCarbonMenu3((__bridge NSMenu *)npMenu, nil, nil, NSMakePoint(screenX, screenY), -1, nil, 0, nil, NSPopUpMenuTypeContext, nil);
    171171    return NPERR_NO_ERROR;
    172172}
  • trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h

    r227214 r232520  
    250250    void setPDFDocumentSize(WebCore::IntSize size) { m_pdfDocumentSize = size; }
    251251
     252#ifdef __OBJC__
    252253    NSData *liveData() const;
    253     NSData *rawData() const { return (NSData *)m_data.get(); }
     254    NSData *rawData() const { return (__bridge NSData *)m_data.get(); }
     255#endif
    254256
    255257    WebFrame* webFrame() const { return m_frame; }
  • trunk/Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm

    r230211 r232520  
    155155    size_t archiveSize = 0;
    156156    if (data) {
    157         RefPtr<SharedBuffer> archiveBuffer = SharedBuffer::create((NSData *)data.get());
     157        auto archiveBuffer = SharedBuffer::create((__bridge NSData *)data.get());
    158158        RefPtr<SharedMemory> archiveSharedMemoryBuffer = SharedMemory::allocate(archiveBuffer->size());
    159159        if (!archiveSharedMemoryBuffer)
  • trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm

    r221537 r232520  
    138138CFTypeRef PlatformCALayerRemoteCustom::contents() const
    139139{
    140     return [m_platformLayer contents];
     140    return (__bridge CFTypeRef)[m_platformLayer contents];
    141141}
    142142
    143143void PlatformCALayerRemoteCustom::setContents(CFTypeRef contents)
    144144{
    145     [m_platformLayer setContents:(id)contents];
     145    [m_platformLayer setContents:(__bridge id)contents];
    146146}
    147147
  • trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm

    r231097 r232520  
    846846        [shadowPositionAnimation setToValue:[NSValue valueWithPoint:shadowLayerPositionForFrame(frameView, constrainedOrigin)]];
    847847        RetainPtr<CABasicAnimation> shadowPathAnimation = transientZoomSnapAnimationForKeyPath("shadowPath");
    848         [shadowPathAnimation setToValue:(id)shadowPath.get()];
     848        [shadowPathAnimation setToValue:(__bridge id)shadowPath.get()];
    849849
    850850        [shadowCALayer addAnimation:shadowBoundsAnimation.get() forKey:@"transientZoomCommitShadowBounds"];
  • trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

    r232239 r232520  
    735735    layer->setSize(image->size());
    736736    layer->setPosition(FloatPoint(0, -image->size().height()));
    737     layer->platformLayer().contents = (id)image->bitmap().makeCGImageCopy().get();
     737    layer->platformLayer().contents = (__bridge id)image->bitmap().makeCGImageCopy().get();
    738738}
    739739
     
    749749
    750750    layer->setSize(image->size());
    751     layer->platformLayer().contents = (id)image->bitmap().makeCGImageCopy().get();
     751    layer->platformLayer().contents = (__bridge id)image->bitmap().makeCGImageCopy().get();
    752752}
    753753
Note: See TracChangeset for help on using the changeset viewer.