Changeset 232789 in webkit

Timestamp:

Jun 13, 2018 3:50:29 AM (6 years ago)

Author:

clopez@igalia.com

Message:

[JSCOnly] Add a MIPS32el JSCOnly EWS (follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=186523

Unreviewed follow-up fix after r232748

• Scripts/webkitpy/common/config/ports.py:

(JscOnlyPort.build_jsc_command): It is needed to pass a --jsc-only argument to the build-jsc script.

• Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_jsconly_port):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/config/ports.py (modified) (1 diff)
• Scripts/webkitpy/common/config/ports_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-06-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
+
+        [JSCOnly] Add a MIPS32el JSCOnly EWS (follow-up fix)
+        https://bugs.webkit.org/show_bug.cgi?id=186523
+
+        Unreviewed follow-up fix after r232748
+
+        * Scripts/webkitpy/common/config/ports.py:
+        (JscOnlyPort.build_jsc_command): It is needed to pass a --jsc-only argument to the build-jsc script.
+        * Scripts/webkitpy/common/config/ports_unittest.py:
+        (DeprecatedPortTest.test_jsconly_port):
+
 2018-06-12  Thibault Saunier  <tsaunier@igalia.com>
 

trunk/Tools/Scripts/webkitpy/common/config/ports.py

@@ -239 +239 @@
     def build_jsc_command(self, build_style=None):
         command = self.script_shell_command("build-jsc")
-        return self._append_build_style_flag(command, build_style)
+        command.append("--jsc-only")
+        return self._append_build_style_flag(command, build_style)

trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py

@@ -65 +65 @@
     def test_jsconly_port(self):
         self.assertEqual(JscOnlyPort().flag(), "--port=jsc-only")
-        self.assertEqual(JscOnlyPort().build_jsc_command(), DeprecatedPort().script_shell_command("build-jsc"))
-        self.assertEqual(JscOnlyPort().build_jsc_command(build_style="release"), DeprecatedPort().script_shell_command("build-jsc") + ["--release"])
-        self.assertEqual(JscOnlyPort().build_jsc_command(build_style="debug"), DeprecatedPort().script_shell_command("build-jsc") + ["--debug"])
+        self.assertEqual(JscOnlyPort().build_jsc_command(), DeprecatedPort().script_shell_command("build-jsc") + ["--jsc-only"])
+        self.assertEqual(JscOnlyPort().build_jsc_command(build_style="release"), DeprecatedPort().script_shell_command("build-jsc") + ["--jsc-only", "--release"])
+        self.assertEqual(JscOnlyPort().build_jsc_command(build_style="debug"), DeprecatedPort().script_shell_command("build-jsc") + ["--jsc-only", "--debug"])