Changeset 232854 in webkit

Timestamp:

Jun 14, 2018 2:41:07 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Test262-Runner: Add more information in the summarized stats
​https://bugs.webkit.org/show_bug.cgi?id=185749

Patch by Leo Balter <Leo Balter> on 2018-06-14
Reviewed by Michael Saboff.

This patch adds extra information in the summarized stats for the given results for each run.
This includes a total of files, a total of executed files and a time information per path and feature.

• Scripts/test262/Runner.pm:

(summarizeResults):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/test262/Runner.pm (modified) (5 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-06-14  Leo Balter  <leonardo.balter@gmail.com>
+
+        Test262-Runner: Add more information in the summarized stats
+        https://bugs.webkit.org/show_bug.cgi?id=185749
+
+        Reviewed by Michael Saboff.
+
+        This patch adds extra information in the summarized stats for the given results for each run.
+        This includes a total of files, a total of executed files and a time information per path and feature.
+        * Scripts/test262/Runner.pm:
+        (summarizeResults):
+
 2018-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 

trunk/Tools/Scripts/test262/Runner.pm

@@ -842 +842 @@
 
                 if (not exists $byfeature{$feature}) {
-                    $byfeature{$feature} = [0, 0, 0]
+                    $byfeature{$feature} = [0, 0, 0, 0];
                 }
 
@@ -854 +854 @@
                     $byfeature{$feature}->[2]++;
                 }
+
+                if ($test->{time}) {
+                    $byfeature{$feature}->[3] += $test->{time};
+                }
             }
         }
@@ -862 +866 @@
 
             if (not exists $bypath{$partialpath}) {
-                $bypath{$partialpath} = [0, 0, 0];
+                $bypath{$partialpath} = [0, 0, 0, 0];
             }
 
@@ -874 +878 @@
                 $bypath{$partialpath}->[2]++;
             }
+
+            if ($test->{time}) {
+                $bypath{$partialpath}->[3] += $test->{time};
+            }
         }
 
@@ -880 +888 @@
     open(my $sfh, '>', $summaryTxtFile) or die $!;
 
-    print $sfh sprintf("%-6s %-6s %-6s %-6s %s\n", '%PASS', 'PASS', 'FAIL', 'SKIP', 'FOLDER');
+    print $sfh sprintf("%-6s %-6s %-6s %-6s %-6s %-6s %-7s %-6s %s\n", 'TOTAL', 'RAN', 'PASS-%', 'PASS', 'FAIL', 'SKIP', 'TIME', 'AVG', 'FOLDER');
     foreach my $key (sort keys %bypath) {
-        my $per = ($bypath{$key}->[0] / (
-            $bypath{$key}->[0]
-            + $bypath{$key}->[1]
-            + $bypath{$key}->[2])) * 100;
-
-        $per = sprintf("%.0f", $per) . "%";
-
-        print $sfh sprintf("%-6s %-6d %-6d %-6d %s \n", $per,
+        my $totalFilesRan = $bypath{$key}->[0] + $bypath{$key}->[1];
+        my $totalFiles = $totalFilesRan + $bypath{$key}->[2];
+
+        my $per = sprintf("%.0f", ($bypath{$key}->[0] / $totalFiles) * 100) . "%";
+
+        my $time = sprintf("%.1f", $bypath{$key}->[3]) . "s";
+        my $avgTime;
+
+        if ($totalFilesRan) {
+            $avgTime = sprintf("%.2f", $bypath{$key}->[3] / $totalFilesRan) . "s";
+        } else {
+            $avgTime = "0s";
+        }
+
+        print $sfh sprintf("%-6s %-6s %-6s %-6d %-6d %-6d %-7s %-6s %s\n",
+                           $totalFiles,
+                           $totalFilesRan,
+                           $per,
                            $bypath{$key}->[0],
                            $bypath{$key}->[1],
-                           $bypath{$key}->[2], $key,);
+                           $bypath{$key}->[2],
+                           $time,
+                           $avgTime,
+                           $key);
     }
 
     print $sfh "\n\n";
-    print $sfh sprintf("%-6s %-6s %-6s %-6s %s\n", '%PASS', 'PASS', 'FAIL', 'SKIP', 'FEATURE');
+    print $sfh sprintf("%-6s %-6s %-6s %-6s %-6s %-6s %-7s %-6s %s\n", 'TOTAL', 'RAN', 'PASS-%', 'PASS', 'FAIL', 'SKIP', 'TIME', 'AVG', 'FEATURE');
 
     foreach my $key (sort keys %byfeature) {
-        my $per = ($byfeature{$key}->[0] / (
-            $byfeature{$key}->[0]
-            + $byfeature{$key}->[1]
-            + $byfeature{$key}->[2])) * 100;
-
-        $per = sprintf("%.0f", $per) . "%";
-
-        print $sfh sprintf("%-6s %-6d %-6d %-6d %s\n", $per,
+        my $totalFilesRan = $byfeature{$key}->[0] + $byfeature{$key}->[1];
+        my $totalFiles = $totalFilesRan + $byfeature{$key}->[2];
+
+        my $per = sprintf("%.0f", ($byfeature{$key}->[0] / $totalFiles) * 100) . "%";
+
+        my $time = sprintf("%.1f", $byfeature{$key}->[3]) . "s";
+        my $avgTime;
+
+        if ($totalFilesRan) {
+            $avgTime = sprintf("%.2f", $byfeature{$key}->[3] / $totalFilesRan) . "s";
+        } else {
+            $avgTime = "0s";
+        }
+
+        print $sfh sprintf("%-6s %-6s %-6s %-6d %-6d %-6d %-7s %-6s %s\n",
+                           $totalFiles,
+                           $totalFilesRan,
+                           $per,
                            $byfeature{$key}->[0],
                            $byfeature{$key}->[1],
-                           $byfeature{$key}->[2], $key);
+                           $byfeature{$key}->[2],
+                           $time,
+                           $avgTime,
+                           $key);
     }