Changeset 232872 in webkit

Timestamp:

Jun 15, 2018 9:03:43 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK][WPE]: Avoid using uninitialized launchOptions in getLaunchOptions
​https://bugs.webkit.org/show_bug.cgi?id=185611

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-06-15
Reviewed by Chris Dumez.

Otherwise we might segfault.

• UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::getLaunchOptions):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Plugins/PluginProcessProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-06-15  Thibault Saunier  <tsaunier@igalia.com>
+
+        [GTK][WPE]: Avoid using uninitialized launchOptions in getLaunchOptions
+        https://bugs.webkit.org/show_bug.cgi?id=185611
+
+        Reviewed by Chris Dumez.
+
+        Otherwise we might segfault.
+
+        * UIProcess/Plugins/PluginProcessProxy.cpp:
+        (WebKit::PluginProcessProxy::getLaunchOptions):
+
 2018-06-14  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp

@@ -89 +89 @@
 void PluginProcessProxy::getLaunchOptions(ProcessLauncher::LaunchOptions& launchOptions)
 {
+    platformGetLaunchOptions(launchOptions, m_pluginProcessAttributes);
     ChildProcessProxy::getLaunchOptions(launchOptions);
-    platformGetLaunchOptions(launchOptions, m_pluginProcessAttributes);
 }