Changeset 233076 in webkit

Timestamp:

Jun 22, 2018 6:22:13 AM (6 years ago)

Author:

Carlos Garcia Campos

Message:

[CMake] Generated sources depending on SelectorPseudoClassAndCompatibilityElementMap.in are not regenerated
​https://bugs.webkit.org/show_bug.cgi?id=186911

Reviewed by Michael Catanzaro.

This is causing test fullscreen/fullscreen-env.html to fail since it was added in r233066 in the bots that
didn't start a clean build. The problem is that the CMake command to generate
SelectorPseudoClassAndCompatibilityElementMap.cpp doesn't depend on
SelectorPseudoClassAndCompatibilityElementMap.in.

• CMakeLists.txt:

Location:

trunk/Source/WebCore

Files:

• CMakeLists.txt (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Source/WebCore/CMakeLists.txt

@@ -1741 +1741 @@
 add_custom_command(
     OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoClassAndCompatibilityElementMap.gperf ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoClassAndCompatibilityElementMap.cpp
-    MAIN_DEPENDENCY ${WEBCORE_DIR}/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
+    MAIN_DEPENDENCY ${WEBCORE_DIR}/css/SelectorPseudoClassAndCompatibilityElementMap.in
+    DEPENDS ${WEBCORE_DIR}/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
     WORKING_DIRECTORY ${DERIVED_SOURCES_WEBCORE_DIR}
     COMMAND ${PYTHON_EXECUTABLE} ${WEBCORE_DIR}/css/makeSelectorPseudoClassAndCompatibilityElementMap.py ${WEBCORE_DIR}/css/SelectorPseudoClassAndCompatibilityElementMap.in "${GPERF_EXECUTABLE}" "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}"
@@ -1748 +1749 @@
 add_custom_command(
     OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoElementTypeMap.gperf ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoElementTypeMap.cpp
-    MAIN_DEPENDENCY ${WEBCORE_DIR}/css/makeSelectorPseudoElementsMap.py
+    MAIN_DEPENDENCY ${WEBCORE_DIR}/css/SelectorPseudoElementTypeMap.in
+    DEPENDS ${WEBCORE_DIR}/css/makeSelectorPseudoElementsMap.py
     WORKING_DIRECTORY ${DERIVED_SOURCES_WEBCORE_DIR}
     COMMAND ${PYTHON_EXECUTABLE} ${WEBCORE_DIR}/css/makeSelectorPseudoElementsMap.py ${WEBCORE_DIR}/css/SelectorPseudoElementTypeMap.in "${GPERF_EXECUTABLE}" "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}"

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [CMake] Generated sources depending on SelectorPseudoClassAndCompatibilityElementMap.in are not regenerated
+        https://bugs.webkit.org/show_bug.cgi?id=186911
+
+        Reviewed by Michael Catanzaro.
+
+        This is causing test fullscreen/fullscreen-env.html to fail since it was added in r233066 in the bots that
+        didn't start a clean build. The problem is that the CMake command to generate
+        SelectorPseudoClassAndCompatibilityElementMap.cpp doesn't depend on
+        SelectorPseudoClassAndCompatibilityElementMap.in.
+
+        * CMakeLists.txt:
+
 2018-06-22  Miguel Gomez  <magomez@igalia.com>