Changeset 233246 in webkit

Timestamp:

Jun 26, 2018 10:06:51 PM (6 years ago)

Author:

Wenson Hsieh

Message:

[iPad apps on macOS] Unable to interact with video elements that have started playing
​https://bugs.webkit.org/show_bug.cgi?id=187073
<rdar://problem/40591107>

Reviewed by Tim Horton.

Source/WebCore/PAL:

Define an SPI method on CALayer. See WebKit ChangeLog for more detail.

• pal/spi/cocoa/QuartzCoreSPI.h:

Source/WebKit:

On iOS, we currently force remote hosting contexts to be non-interactive by passing in kCAContextIgnoresHitTest
when creating the CAContext. However, this flag is not respected by CoreAnimation when running iOS apps on macOS.
This means all HID events dispatched over a video that has been played (which causes WebKit to insert a
CALayerHost-backed WKRemoteView in the view hierarchy) will be routed to the context ID of the video's CAContext
rather than the context ID of the key window containing the WKWebView.

This subsequently causes all gesture recognizers (hover, touch, tap, long press) to fail recognition when
running iOS apps on macOS. To address this, we set a flag on WKRemoteView's CALayerHost to prevent hit-testing
to the remote layer. This allows us to avoid routing HID events to the wrong context, and instead target the
main UIWindow.

Manually verified that click, touch, and mouseenter/mouseleave events are dispatched when interacting over a
video element.

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(-[WKRemoteView initWithFrame:contextID:]):

Location:

trunk/Source

Files:

• WebCore/PAL/ChangeLog (modified) (1 diff)
• WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm (modified) (1 diff)

trunk/Source/WebCore/PAL/ChangeLog

@@ +1 @@
+2018-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iPad apps on macOS] Unable to interact with video elements that have started playing
+        https://bugs.webkit.org/show_bug.cgi?id=187073
+        <rdar://problem/40591107>
+
+        Reviewed by Tim Horton.
+
+        Define an SPI method on CALayer. See WebKit ChangeLog for more detail.
+
+        * pal/spi/cocoa/QuartzCoreSPI.h:
+
 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h

@@ -95 +95 @@
 - (void)reloadValueForKeyPath:(NSString *)keyPath;
 @property BOOL allowsGroupBlending;
+@property BOOL allowsHitTesting;
 @property BOOL canDrawConcurrently;
 @property BOOL contentsOpaque;

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iPad apps on macOS] Unable to interact with video elements that have started playing
+        https://bugs.webkit.org/show_bug.cgi?id=187073
+        <rdar://problem/40591107>
+
+        Reviewed by Tim Horton.
+
+        On iOS, we currently force remote hosting contexts to be non-interactive by passing in `kCAContextIgnoresHitTest`
+        when creating the CAContext. However, this flag is not respected by CoreAnimation when running iOS apps on macOS.
+        This means all HID events dispatched over a video that has been played (which causes WebKit to insert a
+        CALayerHost-backed WKRemoteView in the view hierarchy) will be routed to the context ID of the video's CAContext
+        rather than the context ID of the key window containing the WKWebView.
+
+        This subsequently causes all gesture recognizers (hover, touch, tap, long press) to fail recognition when
+        running iOS apps on macOS. To address this, we set a flag on WKRemoteView's CALayerHost to prevent hit-testing
+        to the remote layer. This allows us to avoid routing HID events to the wrong context, and instead target the
+        main UIWindow.
+
+        Manually verified that click, touch, and mouseenter/mouseleave events are dispatched when interacting over a
+        video element.
+
+        * UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
+        (-[WKRemoteView initWithFrame:contextID:]):
+
 2018-06-26  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm

@@ -135 +135 @@
 - (instancetype)initWithFrame:(CGRect)frame contextID:(uint32_t)contextID
 {
-    if ((self = [super initWithFrame:frame]))
-        [(CALayerHost *)[self layer] setContextId:contextID];
+    if ((self = [super initWithFrame:frame])) {
+        CALayerHost *layer = (CALayerHost *)self.layer;
+        layer.contextId = contextID;
+#if ENABLE(MINIMAL_SIMULATOR)
+        // When running iOS apps on macOS, kCAContextIgnoresHitTest isn't respected; instead, we avoid
+        // hit-testing to the remote context by disabling hit-testing on its host layer. See
+        // <rdar://problem/40591107> for more details.
+        layer.allowsHitTesting = NO;
+#endif
+    }
     
     return self;