Changeset 233429 in webkit

Timestamp:

Jul 2, 2018 1:45:29 PM (6 years ago)

Author:

graouts@webkit.org

Message:

[Web Animations] Crash in KeyframeEffectReadOnly::applyPendingAcceleratedActions()
​https://bugs.webkit.org/show_bug.cgi?id=187139

Reviewed by Dean Jackson.

Ensure we have a resolved time value before trying to use it.

• animation/KeyframeEffectReadOnly.cpp:

(WebCore::KeyframeEffectReadOnly::applyPendingAcceleratedActions):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• animation/KeyframeEffectReadOnly.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-07-02  Antoine Quint  <graouts@apple.com>
+
+        [Web Animations] Crash in KeyframeEffectReadOnly::applyPendingAcceleratedActions()
+        https://bugs.webkit.org/show_bug.cgi?id=187139
+
+        Reviewed by Dean Jackson.
+
+        Ensure we have a resolved time value before trying to use it.
+
+        * animation/KeyframeEffectReadOnly.cpp:
+        (WebCore::KeyframeEffectReadOnly::applyPendingAcceleratedActions):
+
 2018-07-02  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/animation/KeyframeEffectReadOnly.cpp

@@ -1244 +1244 @@
     auto* compositedRenderer = downcast<RenderBoxModelObject>(renderer);
 
-    auto timeOffset = animation()->currentTime().value().seconds();
+    auto currentTime = animation()->currentTime();
+    if (!currentTime)
+        return;
+
+    auto timeOffset = currentTime->seconds();
     if (timing()->delay() < 0_s)
         timeOffset = -timing()->delay().seconds();