Changeset 233572 in webkit


Ignore:
Timestamp:
Jul 6, 2018 12:48:51 AM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Rename HTMLTreeBuilder::didCreateCustomOrCallbackElement
​https://bugs.webkit.org/show_bug.cgi?id=187317

Patch by Frederic Wang <​fwang@igalia.com> on 2018-07-06
Reviewed by Ryosuke Niwa.

This function is called with a new custom element or the fallback HTMLUnknownElement element
so we rename it didCreateCustomOrFallbackElement.

No new tests, behavior unchanged.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::didCreateCustomOrFallbackElement):
(WebCore::HTMLTreeBuilder::didCreateCustomOrCallbackElement): Deleted.

  • html/parser/HTMLTreeBuilder.h:
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r233571 r233572  
     12018-07-06  Frederic Wang  <fwang@igalia.com>
     2
     3        Rename HTMLTreeBuilder::didCreateCustomOrCallbackElement
     4        https://bugs.webkit.org/show_bug.cgi?id=187317
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        This function is called with a new custom element or the fallback HTMLUnknownElement element
     9        so we rename it didCreateCustomOrFallbackElement.
     10
     11        No new tests, behavior unchanged.
     12
     13        * html/parser/HTMLDocumentParser.cpp:
     14        (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
     15        * html/parser/HTMLTreeBuilder.cpp:
     16        (WebCore::HTMLTreeBuilder::didCreateCustomOrFallbackElement):
     17        (WebCore::HTMLTreeBuilder::didCreateCustomOrCallbackElement): Deleted.
     18        * html/parser/HTMLTreeBuilder.h:
     19
    1202018-07-05  Ryosuke Niwa  <rniwa@webkit.org>
    221

  • trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp

    r223047 r233572  
    201201        auto& elementInterface = constructionData->elementInterface.get();
    202202        auto newElement = elementInterface.constructElementWithFallback(*document(), constructionData->name);
    203         m_treeBuilder->didCreateCustomOrCallbackElement(WTFMove(newElement), *constructionData);
     203        m_treeBuilder->didCreateCustomOrFallbackElement(WTFMove(newElement), *constructionData);
    204204        return;
    205205    }

  • trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp

    r233122 r233572  
    874874}
    875875
    876 void HTMLTreeBuilder::didCreateCustomOrCallbackElement(Ref<Element>&& element, CustomElementConstructionData& data)
     876void HTMLTreeBuilder::didCreateCustomOrFallbackElement(Ref<Element>&& element, CustomElementConstructionData& data)
    877877{
    878878    m_tree.insertCustomElement(WTFMove(element), data.name, WTFMove(data.attributes));

  • trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h

    r210319 r233572  
    6767
    6868    std::unique_ptr<CustomElementConstructionData> takeCustomElementConstructionData() { return WTFMove(m_customElementToConstruct); }
    69     void didCreateCustomOrCallbackElement(Ref<Element>&&, CustomElementConstructionData&);
     69    void didCreateCustomOrFallbackElement(Ref<Element>&&, CustomElementConstructionData&);
    7070
    7171    // Done, close any open tags, etc.
Note: See TracChangeset for help on using the changeset viewer.