Changeset 233674 in webkit

Timestamp:

Jul 9, 2018 6:18:39 PM (6 years ago)

Author:

msaboff@apple.com

Message:

REGRESSION (ICU-62100.0.1): JSC test mozilla-tests.yaml/ecma/String/15.5.4.12-3.js is failing
​https://bugs.webkit.org/show_bug.cgi?id=187495

Reviewed by Saam Barati.

Commented out the Georgian section of this toUpper() test since Unicode 11 added new upper case characters for
most of this range.

• mozilla/ecma/String/15.5.4.12-3.js:

(getTestCases):
(DecimalToHexString):

Location:

trunk/JSTests

Files:

• ChangeLog (modified) (1 diff)
• mozilla/ecma/String/15.5.4.12-3.js (modified) (2 diffs)

trunk/JSTests/ChangeLog

@@ +1 @@
+2018-07-09  Michael Saboff  <msaboff@apple.com>
+
+        REGRESSION (ICU-62100.0.1): JSC test mozilla-tests.yaml/ecma/String/15.5.4.12-3.js is failing
+        https://bugs.webkit.org/show_bug.cgi?id=187495
+
+        Reviewed by Saam Barati.
+
+        Commented out the Georgian section of this toUpper() test since Unicode 11 added new upper case characters for
+        most of this range.
+
+        * mozilla/ecma/String/15.5.4.12-3.js:
+        (getTestCases):
+        (DecimalToHexString):
+
 2018-07-02  Sukolsak Sakshuwong  <sukolsak@gmail.com>
 

trunk/JSTests/mozilla/ecma/String/15.5.4.12-3.js

@@ -55 +55 @@
     var item = 0;
 
+    /*
+     * Unicode 11.0 added special uppercase values for U+10A0..U+10FA & U+10FD..U+10FF and thus toUpper()
+     * support for the Georgian range.  It doesn't make sense to make the test adaptive based on what version of
+     * Unicode is installed.  The simplest thing to do is not test this range.
     // Georgian
     // Range: U+10A0 to U+10FF
     for ( var i = 0x10A0; i <= 0x10FF; i++ ) {
         var U = new Unicode( i );
-/*
         array[item++] = new TestCase(   SECTION,
                                         "var s = new String( String.fromCharCode("+i+") ); s.toUpperCase()",
                                         String.fromCharCode(U.upper),
                                         eval("var s = new String( String.fromCharCode("+i+") ); s.toUpperCase()") );
-*/
         array[item++] = new TestCase(   SECTION,
                                         "var s = new String( String.fromCharCode("+i+") ); s.toUpperCase().charCodeAt(0)",
@@ -71 +73 @@
 
     }
+    */
 
     // Halfwidth and Fullwidth Forms