Changeset 233726 in webkit

Timestamp:

Jul 11, 2018, 1:18:28 AM (7 years ago)

Author:

zandobersek@gmail.com

Message:

[WPE] AC for fixed-position elements is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=187514

Reviewed by Carlos Garcia Campos.

Enable accelerated compositing for fixed-position elements when using
AcceleratedDrawingArea and AC is force-enabled. This effectively enables
this option for the WPE port which is using the AcceleratedDrawingArea
implementation and not DrawingAreaImpl like the GTK+ port.

• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::updatePreferences):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/AcceleratedDrawingArea.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-07-11  Zan Dobersek  <zdobersek@igalia.com>
+
+        [WPE] AC for fixed-position elements is not enabled
+        https://bugs.webkit.org/show_bug.cgi?id=187514
+
+        Reviewed by Carlos Garcia Campos.
+
+        Enable accelerated compositing for fixed-position elements when using
+        AcceleratedDrawingArea and AC is force-enabled. This effectively enables
+        this option for the WPE port which is using the AcceleratedDrawingArea
+        implementation and not DrawingAreaImpl like the GTK+ port.
+
+        * WebProcess/WebPage/AcceleratedDrawingArea.cpp:
+        (WebKit::AcceleratedDrawingArea::updatePreferences):
+
 2018-07-11  Christopher Reid  <chris.reid@sony.com>
 

trunk/Source/WebKit/WebProcess/WebPage/AcceleratedDrawingArea.cpp

@@ -152 +152 @@
 void AcceleratedDrawingArea::updatePreferences(const WebPreferencesStore& store)
 {
-    m_webPage.corePage()->settings().setForceCompositingMode(store.getBoolValueForKey(WebPreferencesKey::forceCompositingModeKey()));
+    Settings& settings = m_webPage.corePage()->settings();
+    bool forceCompositiongMode = store.getBoolValueForKey(WebPreferencesKey::forceCompositingModeKey());
+    settings.setForceCompositingMode(forceCompositiongMode);
+    settings.setAcceleratedCompositingForFixedPositionEnabled(forceCompositiongMode);
     if (!m_layerTreeHost)
         enterAcceleratedCompositingMode(nullptr);