Changeset 233808 in webkit
- Timestamp:
- Jul 13, 2018 11:47:18 AM (6 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r233807 r233808 1 2018-07-13 Chris Dumez <cdumez@apple.com> 2 3 Add more threading release assertions 4 https://bugs.webkit.org/show_bug.cgi?id=187647 5 6 Reviewed by Alex Christensen. 7 8 Add more threading release assertions to help debug <rdar://problem/39265927>. 9 10 * NetworkProcess/NetworkConnectionToWebProcess.cpp: 11 (WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess): 12 (WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess): 13 * UIProcess/WebProcessProxy.cpp: 14 (WebKit::m_isInPrewarmedPool): 15 (WebKit::WebProcessProxy::~WebProcessProxy): 16 (WebKit::WebProcessProxy::shutDown): 17 (WebKit::WebProcessProxy::didFinishLaunching): 18 1 19 2018-07-13 Christopher Reid <chris.reid@sony.com> 2 20 -
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
r233801 r233808 75 75 #endif 76 76 { 77 RELEASE_ASSERT(RunLoop::isMain()); 77 78 m_connection->open(); 78 79 } … … 80 81 NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess() 81 82 { 83 RELEASE_ASSERT(RunLoop::isMain()); 84 82 85 m_connection->invalidate(); 83 86 #if USE(LIBWEBRTC) -
trunk/Source/WebKit/Platform/IPC/Connection.cpp
r233783 r233808 937 937 void Connection::dispatchMessage(Decoder& decoder) 938 938 { 939 ASSERT(isValid());939 RELEASE_ASSERT(isValid()); 940 940 m_client.didReceiveMessage(*this, decoder); 941 941 } -
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
r233751 r233808 129 129 , m_isInPrewarmedPool(isInPrewarmedPool == IsInPrewarmedPool::Yes) 130 130 { 131 RELEASE_ASSERT(RunLoop::isMain()); 132 131 133 auto result = allProcesses().add(coreProcessIdentifier(), this); 132 134 ASSERT_UNUSED(result, result.isNewEntry); … … 137 139 WebProcessProxy::~WebProcessProxy() 138 140 { 141 RELEASE_ASSERT(RunLoop::isMain()); 139 142 ASSERT(m_pageURLRetainCountMap.isEmpty()); 140 143 … … 208 211 void WebProcessProxy::shutDown() 209 212 { 213 RELEASE_ASSERT(RunLoop::isMain()); 214 210 215 shutDownProcess(); 211 216 … … 752 757 void WebProcessProxy::didFinishLaunching(ProcessLauncher* launcher, IPC::Connection::Identifier connectionIdentifier) 753 758 { 759 RELEASE_ASSERT(RunLoop::isMain()); 760 754 761 ChildProcessProxy::didFinishLaunching(launcher, connectionIdentifier); 755 762 … … 765 772 } 766 773 774 RELEASE_ASSERT(!m_webConnection); 767 775 m_webConnection = WebConnectionToWebProcess::create(this); 768 776
Note: See TracChangeset
for help on using the changeset viewer.