Changeset 233808 in webkit


Ignore:
Timestamp:
Jul 13, 2018 11:47:18 AM (6 years ago)
Author:
Chris Dumez
Message:

Add more threading release assertions
https://bugs.webkit.org/show_bug.cgi?id=187647

Reviewed by Alex Christensen.

Add more threading release assertions to help debug <rdar://problem/39265927>.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::m_isInPrewarmedPool):
(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::shutDown):
(WebKit::WebProcessProxy::didFinishLaunching):

Location:
trunk/Source/WebKit
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r233807 r233808  
     12018-07-13  Chris Dumez  <cdumez@apple.com>
     2
     3        Add more threading release assertions
     4        https://bugs.webkit.org/show_bug.cgi?id=187647
     5
     6        Reviewed by Alex Christensen.
     7
     8        Add more threading release assertions to help debug <rdar://problem/39265927>.
     9
     10        * NetworkProcess/NetworkConnectionToWebProcess.cpp:
     11        (WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
     12        (WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess):
     13        * UIProcess/WebProcessProxy.cpp:
     14        (WebKit::m_isInPrewarmedPool):
     15        (WebKit::WebProcessProxy::~WebProcessProxy):
     16        (WebKit::WebProcessProxy::shutDown):
     17        (WebKit::WebProcessProxy::didFinishLaunching):
     18
    1192018-07-13  Christopher Reid  <chris.reid@sony.com>
    220
  • trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp

    r233801 r233808  
    7575#endif
    7676{
     77    RELEASE_ASSERT(RunLoop::isMain());
    7778    m_connection->open();
    7879}
     
    8081NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess()
    8182{
     83    RELEASE_ASSERT(RunLoop::isMain());
     84
    8285    m_connection->invalidate();
    8386#if USE(LIBWEBRTC)
  • trunk/Source/WebKit/Platform/IPC/Connection.cpp

    r233783 r233808  
    937937void Connection::dispatchMessage(Decoder& decoder)
    938938{
    939     ASSERT(isValid());
     939    RELEASE_ASSERT(isValid());
    940940    m_client.didReceiveMessage(*this, decoder);
    941941}
  • trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp

    r233751 r233808  
    129129    , m_isInPrewarmedPool(isInPrewarmedPool == IsInPrewarmedPool::Yes)
    130130{
     131    RELEASE_ASSERT(RunLoop::isMain());
     132
    131133    auto result = allProcesses().add(coreProcessIdentifier(), this);
    132134    ASSERT_UNUSED(result, result.isNewEntry);
     
    137139WebProcessProxy::~WebProcessProxy()
    138140{
     141    RELEASE_ASSERT(RunLoop::isMain());
    139142    ASSERT(m_pageURLRetainCountMap.isEmpty());
    140143
     
    208211void WebProcessProxy::shutDown()
    209212{
     213    RELEASE_ASSERT(RunLoop::isMain());
     214
    210215    shutDownProcess();
    211216
     
    752757void WebProcessProxy::didFinishLaunching(ProcessLauncher* launcher, IPC::Connection::Identifier connectionIdentifier)
    753758{
     759    RELEASE_ASSERT(RunLoop::isMain());
     760
    754761    ChildProcessProxy::didFinishLaunching(launcher, connectionIdentifier);
    755762
     
    765772    }
    766773
     774    RELEASE_ASSERT(!m_webConnection);
    767775    m_webConnection = WebConnectionToWebProcess::create(this);
    768776
Note: See TracChangeset for help on using the changeset viewer.