Changeset 233909 in webkit

Timestamp:

Jul 18, 2018 3:20:21 AM (6 years ago)

Author:

zandobersek@gmail.com

Message:

[CoordGraphics] Start tracking Nicosia layers in CoordinatedGraphicsState
​https://bugs.webkit.org/show_bug.cgi?id=187751

Reviewed by Carlos Garcia Campos.

Start including the Nicosia::CompositionLayer objects in the
CoordinatedGraphicsState struct, under a separate NicosiaState struct.
References to all the layers in a given scene are kept in a HashSet,
and a separate reference to the root layer kept in a separate member
variable.

Source/WebCore:

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::compositionLayer const):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Add the getter method that returns internal Nicosia::CompositionLayer
object. This can't be defined in the class definition because of
WEBCORE_EXPORT used on the CoordinatedGraphicsLayer class.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

Source/WebKit:

CompositingCoordinator now takes care of adding or removing the
Nicosia::CompositionLayer objects to the NicosiaState's HashSet, as well
as setting the root layer object when it's being initialized. Additions
and removals of Nicosia::CompositionLayer correspond to the additions
and removals of CoordinatedGraphicsLayer objects to the coordinator's
m_registeredLayers HashMap.

Upon each state commit that's done in CoordinatedGraphicsScene, the
NicosiaState object will be copied into the member variable. Nothing is
done yet with that state object, but in the near future it will be used
to finally commit all the state details into the TextureMapper layers.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::commitSceneState):

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
(WebKit::CompositingCoordinator::createGraphicsLayer):
(WebKit::CompositingCoordinator::detachLayer):
(WebKit::CompositingCoordinator::attachLayer):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp (modified) (1 diff)
• WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h (modified) (1 diff)
• WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h (modified) (2 diffs)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp (modified) (1 diff)
• WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h (modified) (1 diff)
• WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-07-18  Zan Dobersek  <zdobersek@igalia.com>
+
+        [CoordGraphics] Start tracking Nicosia layers in CoordinatedGraphicsState
+        https://bugs.webkit.org/show_bug.cgi?id=187751
+
+        Reviewed by Carlos Garcia Campos.
+
+        Start including the Nicosia::CompositionLayer objects in the
+        CoordinatedGraphicsState struct, under a separate NicosiaState struct.
+        References to all the layers in a given scene are kept in a HashSet,
+        and a separate reference to the root layer kept in a separate member
+        variable.
+
+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
+        (WebCore::CoordinatedGraphicsLayer::compositionLayer const):
+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
+        Add the getter method that returns internal Nicosia::CompositionLayer
+        object. This can't be defined in the class definition because of
+        WEBCORE_EXPORT used on the CoordinatedGraphicsLayer class.
+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
+
 2018-07-18  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp

@@ -1112 +1112 @@
 }
 
+const RefPtr<Nicosia::CompositionLayer>& CoordinatedGraphicsLayer::compositionLayer() const
+{
+    return m_nicosia.layer;
+}
+
 void CoordinatedGraphicsLayer::setNeedsVisibleRectAdjustment()
 {

trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h

@@ -135 +135 @@
     void purgeBackingStores();
 
+    const RefPtr<Nicosia::CompositionLayer>& compositionLayer() const;
+
 private:
     bool isCoordinatedGraphicsLayer() const override { return true; }

trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h

@@ -38 +38 @@
 #include "IntSize.h"
 #include "NicosiaBuffer.h"
+#include "NicosiaPlatformLayer.h"
 #include "SurfaceUpdateInfo.h"
 #include "TextureMapperAnimation.h"
@@ -175 +176 @@
 
 struct CoordinatedGraphicsState {
+    struct NicosiaState {
+        HashSet<RefPtr<Nicosia::CompositionLayer>> layers;
+        RefPtr<Nicosia::CompositionLayer> rootLayer;
+    } nicosia;
+
     uint32_t rootCompositingLayer;
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-07-18  Zan Dobersek  <zdobersek@igalia.com>
+
+        [CoordGraphics] Start tracking Nicosia layers in CoordinatedGraphicsState
+        https://bugs.webkit.org/show_bug.cgi?id=187751
+
+        Reviewed by Carlos Garcia Campos.
+
+        Start including the Nicosia::CompositionLayer objects in the
+        CoordinatedGraphicsState struct, under a separate NicosiaState struct.
+        References to all the layers in a given scene are kept in a HashSet,
+        and a separate reference to the root layer kept in a separate member
+        variable.
+
+        CompositingCoordinator now takes care of adding or removing the
+        Nicosia::CompositionLayer objects to the NicosiaState's HashSet, as well
+        as setting the root layer object when it's being initialized. Additions
+        and removals of Nicosia::CompositionLayer correspond to the additions
+        and removals of CoordinatedGraphicsLayer objects to the coordinator's
+        m_registeredLayers HashMap.
+
+        Upon each state commit that's done in CoordinatedGraphicsScene, the
+        NicosiaState object will be copied into the member variable. Nothing is
+        done yet with that state object, but in the near future it will be used
+        to finally commit all the state details into the TextureMapper layers.
+
+        * Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
+        (WebKit::CoordinatedGraphicsScene::commitSceneState):
+        * Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
+        * WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
+        (WebKit::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
+        (WebKit::CompositingCoordinator::createGraphicsLayer):
+        (WebKit::CompositingCoordinator::detachLayer):
+        (WebKit::CompositingCoordinator::attachLayer):
+
 2018-07-17  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp

@@ -432 +432 @@
         return;
 
+    m_nicosia = state.nicosia;
+    // FIXME: Start using the Nicosia layer state for updates.
+
     CommitScope commitScope;
 

trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h

@@ -143 +143 @@
 #endif
 
+    WebCore::CoordinatedGraphicsState::NicosiaState m_nicosia;
+
     std::unique_ptr<WebCore::TextureMapper> m_textureMapper;
 

trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp

@@ -172 +172 @@
         return;
 
-    m_state.rootCompositingLayer = downcast<CoordinatedGraphicsLayer>(*m_rootLayer).id();
+    auto& rootLayer = downcast<CoordinatedGraphicsLayer>(*m_rootLayer);
+    m_state.nicosia.rootLayer = rootLayer.compositionLayer();
+    m_state.rootCompositingLayer = rootLayer.id();
     m_didInitializeRootCompositingLayer = true;
     m_shouldSyncFrame = true;
@@ -262 +264 @@
     CoordinatedGraphicsLayer* layer = new CoordinatedGraphicsLayer(layerType, client);
     layer->setCoordinator(this);
+    m_state.nicosia.layers.add(layer->compositionLayer());
     m_registeredLayers.add(layer->id(), layer);
     m_state.layersToCreate.append(layer->id());
@@ -302 +305 @@
         return;
 
+    m_state.nicosia.layers.remove(layer->compositionLayer());
     m_registeredLayers.remove(layer->id());
 
@@ -317 +321 @@
 {
     layer->setCoordinator(this);
+    m_state.nicosia.layers.add(layer->compositionLayer());
     m_registeredLayers.add(layer->id(), layer);
     m_state.layersToCreate.append(layer->id());