Changeset 233914 in webkit


Ignore:
Timestamp:
Jul 18, 2018 9:04:33 AM (6 years ago)
Author:
cturner@igalia.com
Message:

[WPE] Update WPEBackend in flatpak
​https://bugs.webkit.org/show_bug.cgi?id=187753

r233763 updated WPEBackend for the jhbuild, but not the flatpak. This
caused WPE_BACKEND_CHECK_VERSION to not be defined, triggering a bug
in the version guard,

#if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)

This doesn't work as intended, since the C preprocessor first expands
all macro arguments in the #if expression before evaluating the
expression. When WPE_BACKEND_CHECK_VERSION is not defined, this will
lead to a syntax error and some head scratching.

A future patch should address the buggy macro check, when it is
decided whether the assume the macro is always defined and bump
the API requirements on WPEBackend, or to move the check into two
conditionals to avoid the expansion problem.

Unreviewed build fix.

  • flatpak/org.webkit.WPE.yaml:
Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r233913 r233914  
     12018-07-18  Charlie Turner  <cturner@igalia.com>
     2
     3        [WPE] Update WPEBackend in flatpak
     4        https://bugs.webkit.org/show_bug.cgi?id=187753
     5
     6        r233763 updated WPEBackend for the jhbuild, but not the flatpak. This
     7        caused WPE_BACKEND_CHECK_VERSION to not be defined, triggering a bug
     8        in the version guard,
     9
     10        #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
     11
     12        This doesn't work as intended, since the C preprocessor first expands
     13        all macro arguments in the #if expression before evaluating the
     14        expression. When WPE_BACKEND_CHECK_VERSION is not defined, this will
     15        lead to a syntax error and some head scratching.
     16
     17        A future patch should address the buggy macro check, when it is
     18        decided whether the assume the macro is always defined and bump
     19        the API requirements on WPEBackend, or to move the check into two
     20        conditionals to avoid the expansion problem.
     21
     22        Unreviewed build fix.
     23       
     24        * flatpak/org.webkit.WPE.yaml:
     25
    1262018-07-18  Simon Fraser  <simon.fraser@apple.com>
    227

  • trunk/Tools/flatpak/org.webkit.WPE.yaml

    r233362 r233914  
    44    - type: git
    55      url: https://github.com/WebPlatformForEmbedded/WPEBackend.git
    6       branch: 761496dff51b6962200294b4fe2bc9529da731a8
     6      branch: 411decf4875e7a5c858489206cdb7705a4bbb581
    77- name: wpebackend-fdo
    88  buildsystem: cmake-ninja
Note: See TracChangeset for help on using the changeset viewer.