Changeset 233989 in webkit

Timestamp:

Jul 19, 2018 10:37:17 AM (6 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Dark Mode: poor contrast for Search Tab's "the page's content has changed" message
​https://bugs.webkit.org/show_bug.cgi?id=187792

Reviewed by Brian Burg.

• UserInterface/Views/DarkMode.css:

(@media (prefers-dark-interface)):
(:root):
Make the background color slightly more yellow and less red. This slightly dicreases the contrast
but makes the text look less like an error.

• UserInterface/Views/SearchSidebarPanel.css:

(@media (prefers-dark-interface)):
(.sidebar > .panel.navigation.search.changed > .banner):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DarkMode.css (modified) (1 diff)
• UserInterface/Views/SearchSidebarPanel.css (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-07-19  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Dark Mode: poor contrast for Search Tab's "the page's content has changed" message
+        https://bugs.webkit.org/show_bug.cgi?id=187792
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/DarkMode.css:
+        (@media (prefers-dark-interface)):
+        (:root):
+        Make the background color slightly more yellow and less red. This slightly dicreases the contrast
+        but makes the text look less like an error.
+
+        * UserInterface/Views/SearchSidebarPanel.css:
+        (@media (prefers-dark-interface)):
+        (.sidebar > .panel.navigation.search.changed > .banner):
+
 2018-07-18  Matt Baker  <mattbaker@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DarkMode.css

@@ -94 +94 @@
         --green-highlight-text-color: hsl(80, 75%, 80%);
 
-        --yellow-highlight-background-color: hsl(3, 20%, 26%);
+        --yellow-highlight-background-color: hsl(13, 20%, 26%);
         --yellow-highlight-text-color: hsl(50, 96%, 87%);
 

trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.css

@@ -79 +79 @@
     top: calc(var(--navigation-bar-height) + 40px - 1px);
 }
+
+@media (prefers-dark-interface) {
+    .sidebar > .panel.navigation.search.changed > .banner {
+        background-color: var(--yellow-highlight-background-color);
+        color: var(--yellow-highlight-text-color);
+    }
+}