Changeset 233992 in webkit

Timestamp:

Jul 19, 2018 10:45:14 AM (6 years ago)

Author:

jonlee@apple.com

Message:

Update iOS fullscreen alert text again
​https://bugs.webkit.org/show_bug.cgi?id=187797
rdar://problem/42373783

Reviewed by Jer Noble.

Source/WebCore:

• English.lproj/Localizable.strings:

Source/WebKit:

• UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController _showPhishingAlert]):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/English.lproj/Localizable.strings (modified) (2 diffs)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-07-19  Jon Lee  <jonlee@apple.com>
+
+        Update iOS fullscreen alert text again
+        https://bugs.webkit.org/show_bug.cgi?id=187797
+        rdar://problem/42373783
+
+        Reviewed by Jer Noble.
+
+        * English.lproj/Localizable.strings:
+
 2018-07-19  Keith Rollin  <krollin@apple.com>
 

trunk/Source/WebCore/English.lproj/Localizable.strings

@@ -339 +339 @@
 
 /* Fullscreen Deceptive Website Warning Sheet Title */
-"It looks like you are typing on “%@”" = "It looks like you are typing on “%@”";
+"It looks like you are typing while in full screen" = "It looks like you are typing while in full screen";
 
 /* Italic context menu item */
@@ -765 +765 @@
 
 /* Fullscreen Deceptive Website Warning Sheet Content Text */
-"Typing is not allowed in full screen. This website may be showing a fake keyboard to trick you into disclosing personal or financial information." = "Typing is not allowed in full screen. This website may be showing a fake keyboard to trick you into disclosing personal or financial information.";
+"Typing is not allowed in full screen websites. “%@” may be showing a fake keyboard to trick you into disclosing personal or financial information." = "Typing is not allowed in full screen websites. “%@” may be showing a fake keyboard to trick you into disclosing personal or financial information.";
 
 /* accessibility role description for a URL field. */

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-07-19  Jon Lee  <jonlee@apple.com>
+
+        Update iOS fullscreen alert text again
+        https://bugs.webkit.org/show_bug.cgi?id=187797
+        rdar://problem/42373783
+
+        Reviewed by Jer Noble.
+
+        * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
+        (-[WKFullScreenViewController _showPhishingAlert]):
+
 2018-07-19  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm

@@ -543 +543 @@
 - (void)_showPhishingAlert
 {
-    NSString *alertTitle = [NSString stringWithFormat:WEB_UI_STRING("It looks like you are typing on “%@”", "Fullscreen Deceptive Website Warning Sheet Title"), (NSString *)self.location];
-    NSString *alertMessage = WEB_UI_STRING("Typing is not allowed in full screen. This website may be showing a fake keyboard to trick you into disclosing personal or financial information.", "Fullscreen Deceptive Website Warning Sheet Content Text");
+    NSString *alertTitle = WEB_UI_STRING("It looks like you are typing while in full screen", "Fullscreen Deceptive Website Warning Sheet Title");
+    NSString *alertMessage = [NSString stringWithFormat:WEB_UI_STRING("Typing is not allowed in full screen websites. “%@” may be showing a fake keyboard to trick you into disclosing personal or financial information.", "Fullscreen Deceptive Website Warning Sheet Content Text"), (NSString *)self.location];
     UIAlertController* alert = [UIAlertController alertControllerWithTitle:alertTitle message:alertMessage preferredStyle:UIAlertControllerStyleAlert];