Changeset 234002 in webkit
- Timestamp:
- Jul 19, 2018, 1:48:43 PM (7 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r234000 r234002 1 2018-07-19 Jer Noble <jer.noble@apple.com> 2 3 REGRESSION(r233926): media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html is a TIMEOUT failure 4 https://bugs.webkit.org/show_bug.cgi?id=187813 5 6 Reviewed by Jon Lee. 7 8 In r233926, we changed the behavior of entering PiP to exit fullscreen only after entering PiP completes. The 9 test in question will immediately request "inline" presentation mode once the PiP animation begins, and thus 10 it's asking to "exit fullscreen" when both in standard fullscreen and also in PiP. The fix is not to bail out 11 early if we're in standard (element) fullscreen, but to allow the remaining steps to complete and exit PiP as 12 well. 13 14 * html/HTMLMediaElement.cpp: 15 (WebCore::HTMLMediaElement::exitFullscreen): 16 1 17 2018-07-19 Zalan Bujtas <zalan@apple.com> 2 18 -
trunk/Source/WebCore/html/HTMLMediaElement.cpp
r233982 r234002 5959 5959 if (document().webkitIsFullScreen()) 5960 5960 document().webkitCancelFullScreen(); 5961 return; 5961 5962 if (m_videoFullscreenMode == VideoFullscreenModeStandard) 5963 return; 5962 5964 } 5963 5965 #endif
Note:
See TracChangeset
for help on using the changeset viewer.