Changeset 234107 in webkit
- Timestamp:
- Jul 23, 2018 12:33:13 PM (6 years ago)
- Location:
- trunk/LayoutTests
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r234104 r234107 1 2018-07-23 Chris Dumez <cdumez@apple.com> 2 3 REGRESSION(PSON?): [ WK2 ] http/tests/workers/service/client-*-page-cache.html LayoutTests are flaky 4 https://bugs.webkit.org/show_bug.cgi?id=183705 5 <rdar://problem/42440606> 6 7 Unreviewed, attempting a better fix for http/tests/workers/service/serviceworkerclients-matchAll.https.html. 8 If it fixes the flakiness I'll do the same for the 2 page cache tests. 9 10 * http/tests/workers/service/serviceworkerclients-matchAll-worker.js: 11 (waitFor): 12 (matchAllPromise2): 13 (async.doTestAfterMessage): 14 (matchAllPromise1): Deleted. 15 (then): Deleted. 16 * platform/ios-wk2/TestExpectations: 17 * platform/mac-wk2/TestExpectations: 18 1 19 2018-07-23 Per Arne Vollan <pvollan@apple.com> 2 20 -
trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-matchAll-worker.js
r234061 r234107 1 function waitFor(duration) 2 { 3 return new Promise((resolve) => setTimeout(resolve, duration)); 4 } 5 1 6 function matchAllPromise1() 2 7 { … … 9 14 10 15 var matchedClients; 11 matchAllPromise2 = self.clients.matchAll({ includeUncontrolled : true }).then((c) => { 12 matchedClients = c; 13 return matchedClients.length === 1 ? "PASS" : "FAIL: expected one matched client, got " + matchedClients.length; 14 }, (e) => { 15 return "FAIL: matchAll 2 rejected with " + e; 16 }); 16 function matchAllPromise2() 17 { 18 return self.clients.matchAll({ includeUncontrolled : true }).then((c) => { 19 matchedClients = c; 20 return matchedClients.length === 1 ? "PASS" : "FAIL: expected one matched client, got " + matchedClients.length; 21 }, (e) => { 22 return "FAIL: matchAll 2 rejected with " + e; 23 }); 24 } 17 25 18 26 async function doTestAfterMessage(event) … … 29 37 await waitFor(50); 30 38 result = await matchAllPromise1(); 31 } while (result !== "PASS" && ++tries <= 20 );39 } while (result !== "PASS" && ++tries <= 200); 32 40 33 41 if (result !== "PASS") { … … 36 44 } 37 45 38 var result = await matchAllPromise2; 46 tries = 0; 47 do { 48 if (tries) 49 await waitFor(50); 50 result = await matchAllPromise2(); 51 } while (result !== "PASS" && ++tries <= 200); 52 39 53 if (result !== "PASS") { 40 54 event.source.postMessage(result); -
trunk/LayoutTests/platform/ios-wk2/TestExpectations
r234100 r234107 1359 1359 webkit.org/b/183705 http/tests/workers/service/client-added-to-clients-when-restored-from-page-cache.html [ Pass Failure ] 1360 1360 webkit.org/b/183705 http/tests/workers/service/client-removed-from-clients-while-in-page-cache.html [ Pass Failure ] 1361 webkit.org/b/183705 http/tests/workers/service/serviceworkerclients-matchAll.https.html [ Pass Failure ] -
trunk/LayoutTests/platform/mac-wk2/TestExpectations
r234101 r234107 887 887 webkit.org/b/183705 http/tests/workers/service/client-added-to-clients-when-restored-from-page-cache.html [ Pass Failure ] 888 888 webkit.org/b/183705 http/tests/workers/service/client-removed-from-clients-while-in-page-cache.html [ Pass Failure ] 889 webkit.org/b/183705 http/tests/workers/service/serviceworkerclients-matchAll.https.html [ Pass Failure ]890 889 891 890 webkit.org/b/187658 http/tests/security/bypassing-cors-checks-for-extension-urls.html [ Pass Failure ]
Note: See TracChangeset
for help on using the changeset viewer.