Changeset 234803 in webkit
- Timestamp:
- Aug 13, 2018 9:39:14 AM (6 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r234800 r234803 1 2018-08-13 Said Abou-Hallawa <sabouhallawa@apple.com> 2 3 Followup (r234683): Element::getAttribute() should return the first non-null attribute value 4 https://bugs.webkit.org/show_bug.cgi?id=188419 5 6 Reviewed by Darin Adler. 7 8 * svg/custom/href-svg-namespace-empty-expected.txt: Added. 9 * svg/custom/href-svg-namespace-empty.html: Added. 10 1 11 2018-08-13 Zalan Bujtas <zalan@apple.com> 2 12 -
trunk/Source/WebCore/ChangeLog
r234802 r234803 1 2018-08-13 Said Abou-Hallawa <sabouhallawa@apple.com> 2 3 Followup (r234683): Element::getAttribute() should return the first non-null attribute value 4 https://bugs.webkit.org/show_bug.cgi?id=188419 5 6 Reviewed by Darin Adler. 7 8 Element::getAttribute() should return the first non-null attribute value 9 since an empty string is a legitimate attribute value. 10 11 Test: svg/custom/href-svg-namespace-empty.html 12 13 * dom/Element.h: 14 (WebCore::Element::getAttribute const): 15 1 16 2018-08-13 Michael Catanzaro <mcatanzaro@igalia.com> 2 17 -
trunk/Source/WebCore/dom/Element.h
r234683 r234803 824 824 { 825 825 const AtomicString& value = getAttribute(name); 826 if (!value.is Empty())826 if (!value.isNull()) 827 827 return value; 828 828 return getAttribute(names...);
Note: See TracChangeset
for help on using the changeset viewer.