Changeset 234803 in webkit


Ignore:
Timestamp:
Aug 13, 2018 9:39:14 AM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Followup (r234683): Element::getAttribute() should return the first non-null attribute value
https://bugs.webkit.org/show_bug.cgi?id=188419

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-08-13
Reviewed by Darin Adler.

Source/WebCore:

Element::getAttribute() should return the first non-null attribute value
since an empty string is a legitimate attribute value.

Test: svg/custom/href-svg-namespace-empty.html

  • dom/Element.h:

(WebCore::Element::getAttribute const):

LayoutTests:

  • svg/custom/href-svg-namespace-empty-expected.txt: Added.
  • svg/custom/href-svg-namespace-empty.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r234800 r234803  
     12018-08-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
     2
     3        Followup (r234683): Element::getAttribute() should return the first non-null attribute value
     4        https://bugs.webkit.org/show_bug.cgi?id=188419
     5
     6        Reviewed by Darin Adler.
     7
     8        * svg/custom/href-svg-namespace-empty-expected.txt: Added.
     9        * svg/custom/href-svg-namespace-empty.html: Added.
     10
    1112018-08-13  Zalan Bujtas  <zalan@apple.com>
    212
  • trunk/Source/WebCore/ChangeLog

    r234802 r234803  
     12018-08-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
     2
     3        Followup (r234683): Element::getAttribute() should return the first non-null attribute value
     4        https://bugs.webkit.org/show_bug.cgi?id=188419
     5
     6        Reviewed by Darin Adler.
     7
     8        Element::getAttribute() should return the first non-null attribute value
     9        since an empty string is a legitimate attribute value.
     10
     11        Test: svg/custom/href-svg-namespace-empty.html
     12
     13        * dom/Element.h:
     14        (WebCore::Element::getAttribute const):
     15
    1162018-08-13  Michael Catanzaro  <mcatanzaro@igalia.com>
    217
  • trunk/Source/WebCore/dom/Element.h

    r234683 r234803  
    824824{
    825825    const AtomicString& value = getAttribute(name);
    826     if (!value.isEmpty())
     826    if (!value.isNull())
    827827        return value;
    828828    return getAttribute(names...);
Note: See TracChangeset for help on using the changeset viewer.