Changeset 234915 in webkit
- Timestamp:
- Aug 16, 2018 1:15:54 AM (6 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r234914 r234915 1 2018-08-16 Carlos Garcia Campos <cgarcia@igalia.com> 2 3 [GTK] MiniBrowser: web view doesn't get the focus when new window is created 4 https://bugs.webkit.org/show_bug.cgi?id=188546 5 6 Reviewed by Michael Catanzaro. 7 8 When a new window is created, the first widget of the windo is getting the focus, the toolbar in this case. We 9 always want the WebView to grab the focus. In case of new empty tab, we want to the URL bar to be focused 10 instead. This was causing failures in WebDriver tests that create a popup window with an input element that is 11 filled with send keys command. The input element is marked as focused in the DOM, but the actual focused widget 12 is the toolbar, so key events are sent to the toolbar instead of the web view. 13 14 * MiniBrowser/gtk/BrowserWindow.c: 15 (webViewCreate): 16 (newTabCallback): 17 (openPrivateWindow): 18 (browser_window_get_or_create_web_view_for_automation): 19 1 20 2018-08-16 Carlos Garcia Campos <cgarcia@igalia.com> 2 21 -
trunk/Tools/MiniBrowser/gtk/BrowserWindow.c
r234844 r234915 339 339 GtkWidget *newWindow = browser_window_new(GTK_WINDOW(window), window->webContext); 340 340 browser_window_append_view(BROWSER_WINDOW(newWindow), newWebView); 341 gtk_widget_grab_focus(GTK_WIDGET(newWebView)); 341 342 g_signal_connect(newWebView, "ready-to-show", G_CALLBACK(webViewReadyToShow), newWindow); 342 343 g_signal_connect(newWebView, "run-as-modal", G_CALLBACK(webViewRunAsModal), newWindow); … … 529 530 "is-controlled-by-automation", webkit_web_view_is_controlled_by_automation(webView), 530 531 NULL))); 532 gtk_widget_grab_focus(window->uriEntry); 531 533 gtk_notebook_set_current_page(GTK_NOTEBOOK(window->notebook), -1); 532 534 } … … 549 551 GtkWidget *newWindow = browser_window_new(GTK_WINDOW(window), window->webContext); 550 552 browser_window_append_view(BROWSER_WINDOW(newWindow), newWebView); 553 gtk_widget_grab_focus(GTK_WIDGET(newWebView)); 551 554 gtk_widget_show(GTK_WIDGET(newWindow)); 552 555 } … … 1234 1237 NULL)); 1235 1238 browser_window_append_view(window, newWebView); 1239 gtk_widget_grab_focus(GTK_WIDGET(newWebView)); 1236 1240 return newWebView; 1237 1241 } -
trunk/WebDriverTests/ChangeLog
r234841 r234915 1 2018-08-16 Carlos Garcia Campos <cgarcia@igalia.com> 2 3 [GTK] MiniBrowser: web view doesn't get the focus when new window is created 4 https://bugs.webkit.org/show_bug.cgi?id=188546 5 6 Reviewed by Michael Catanzaro. 7 8 Remove expectations of the tests that pass now. 9 10 * TestExpectations.json: 11 1 12 2018-08-14 Carlos Garcia Campos <cgarcia@igalia.com> 2 13 -
trunk/WebDriverTests/TestExpectations.json
r234841 r234915 479 479 } 480 480 }, 481 "imported/w3c/webdriver/tests/back/back.py": {482 "subtests": {483 "test_dismissed_beforeunload": {484 "expected": {"all": {"status": ["TIMEOUT"], "bug": "webkit.org/b/188546"}}485 }486 }487 },488 481 "imported/w3c/webdriver/tests/close_window/close.py": { 489 482 "subtests": { 490 483 "test_close_last_browsing_context": { 491 484 "expected": {"gtk": {"status": ["FAIL", "PASS"], "bug": "webkit.org/b/188118"}} 492 },493 "test_close_browsing_context_with_dismissed_beforeunload_prompt": {494 "expected": {"all": {"status": ["TIMEOUT"], "bug": "webkit.org/b/188546"}}495 485 } 496 486 } … … 608 598 } 609 599 }, 610 "imported/w3c/webdriver/tests/forward/forward.py": {611 "subtests": {612 "test_dismissed_beforeunload": {613 "expected": {"all": {"status": ["TIMEOUT"], "bug": "webkit.org/b/188546"}}614 }615 }616 },617 600 "imported/w3c/webdriver/tests/element_send_keys/events.py": { 618 601 "subtests": {
Note: See TracChangeset
for help on using the changeset viewer.