Changeset 235236 in webkit

Timestamp:

Aug 23, 2018, 12:51:22 PM (6 years ago)

Author:

mitz@apple.com

Message:

[Cocoa] First scroll gesture in pinned, non-rubber-banding WKWebView may fail to initiate back/forward swipe
​https://bugs.webkit.org/show_bug.cgi?id=188894
<rdar://problem/43651434>

Reviewed by Tim Horton.

• WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent): Set the rubber-band state on the ScrollingTree

synchronously rather than dispatching doing that to the scrolling thread. This is safe to
do because ScrollingTree synchrnoizes access to the rubber-band state with an internal
mutex.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/EventDispatcher.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-08-23  Dan Bernstein  <mitz@apple.com>
+
+        [Cocoa] First scroll gesture in pinned, non-rubber-banding WKWebView may fail to initiate back/forward swipe
+        https://bugs.webkit.org/show_bug.cgi?id=188894
+        <rdar://problem/43651434>
+
+        Reviewed by Tim Horton.
+
+        * WebProcess/WebPage/EventDispatcher.cpp:
+        (WebKit::EventDispatcher::wheelEvent): Set the rubber-band state on the ScrollingTree
+          synchronously rather than dispatching doing that to the scrolling thread. This is safe to
+          do because ScrollingTree synchrnoizes access to the rubber-band state with an internal
+          mutex.
+
 2018-08-23  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp

@@ -120 +120 @@
         // scrolling tree can be notified.
         // We only need to do this at the beginning of the gesture.
-        if (platformWheelEvent.phase() == PlatformWheelEventPhaseBegan) {
-            ScrollingThread::dispatch([scrollingTree, canRubberBandAtLeft, canRubberBandAtRight, canRubberBandAtTop, canRubberBandAtBottom] {
-                scrollingTree->setCanRubberBandState(canRubberBandAtLeft, canRubberBandAtRight, canRubberBandAtTop, canRubberBandAtBottom);
-            });
-        }
+        if (platformWheelEvent.phase() == PlatformWheelEventPhaseBegan)
+            scrollingTree->setCanRubberBandState(canRubberBandAtLeft, canRubberBandAtRight, canRubberBandAtTop, canRubberBandAtBottom);
 
         ScrollingTree::EventResult result = scrollingTree->tryToHandleWheelEvent(platformWheelEvent);