Changeset 235439 in webkit


Ignore:
Timestamp:
Aug 28, 2018, 2:02:34 PM (7 years ago)
Author:
ddkilzer@apple.com
Message:

Fix incorrect use of sourceTree = "<group>"; for built products and frameworks in Xcode projects

Found by tidy-Xcode-project-file script (see Bug 188754).

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

(IOKit.framework): Use sourceTree = "<absolute>"; to match
other frameworks in the project.

  • MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:

(WebKit.framework): Use sourceTree = BUILT_PRODUCTS_DIR; for
built product instead of relative build directory path.

  • jsc-cli/jsc-cli.xcodeproj/project.pbxproj:

(JavaScriptCore.framework): Ditto.

  • lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:

(libWTF.a): Ditto.

Location:
trunk/Tools
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r235434 r235439  
     12018-08-28  David Kilzer  <ddkilzer@apple.com>
     2
     3        Fix incorrect use of `sourceTree = "<group>";` for built products and frameworks in Xcode projects
     4
     5        Found by tidy-Xcode-project-file script (see Bug 188754).
     6
     7        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
     8        (IOKit.framework): Use `sourceTree = "<absolute>";` to match
     9        other frameworks in the project.
     10        * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
     11        (WebKit.framework): Use `sourceTree = BUILT_PRODUCTS_DIR;` for
     12        built product instead of relative build directory path.
     13        * jsc-cli/jsc-cli.xcodeproj/project.pbxproj:
     14        (JavaScriptCore.framework): Ditto.
     15        * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
     16        (libWTF.a): Use `sourceTree = BUILT_PRODUCTS_DIR;` for built
     17        product.
     18
    1192018-08-28  Alex Christensen  <achristensen@webkit.org>
    220

  • trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

    r233412 r235439  
    264264                1A5CC1F3137DD2EC00A5D7E7 /* GetURLWithJavaScriptURL.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = GetURLWithJavaScriptURL.cpp; sourceTree = "<group>"; };
    265265                1A66C34F14576A920099A115 /* ContentsScaleFactor.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ContentsScaleFactor.cpp; sourceTree = "<group>"; };
    266                 1A7961061803454C00FE42CD /* IOKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = IOKit.framework; path = /System/Library/Frameworks/IOKit.framework; sourceTree = "<group>"; };
     266                1A7961061803454C00FE42CD /* IOKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = IOKit.framework; path = /System/Library/Frameworks/IOKit.framework; sourceTree = "<absolute>"; };
    267267                1A8F024C0BB9B056008CFA34 /* TestObject.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TestObject.h; sourceTree = "<group>"; };
    268268                1AC6C77F0D07589B00CD3161 /* main.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = main.cpp; sourceTree = "<group>"; };

  • trunk/Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj

    r225815 r235439  
    8383                CD1DAFBC1D709EF200017CF0 /* WebViewController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebViewController.h; sourceTree = "<group>"; };
    8484                CD1DAFBD1D709EF200017CF0 /* WebViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = WebViewController.m; sourceTree = "<group>"; };
    85                 CD1DAFC11D70E12D00017CF0 /* WebKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = WebKit.framework; path = "../../WebKitBuild/Debug-iphonesimulator/WebKit.framework"; sourceTree = "<group>"; };
     85                CD1DAFC11D70E12D00017CF0 /* WebKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; path = WebKit.framework; sourceTree = BUILT_PRODUCTS_DIR; };
    8686                CD498B3B1D76348000681FA7 /* MobileMiniBrowser.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = MobileMiniBrowser.framework; sourceTree = BUILT_PRODUCTS_DIR; };
    8787                CD498B471D7634C700681FA7 /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };

  • trunk/Tools/jsc-cli/jsc-cli.xcodeproj/project.pbxproj

    r164134 r235439  
    5858       C246592118902EA40029092E /* ScriptInputSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ScriptInputSource.h; sourceTree = "<group>"; };
    5959       C246592218902EA40029092E /* ScriptInputSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ScriptInputSource.m; sourceTree = "<group>"; };
    60        C296621018ADF56000752922 /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = JavaScriptCore.framework; path = ../../WebKitBuild/Debug/JavaScriptCore.framework; sourceTree = "<group>"; };
     60       C296621018ADF56000752922 /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; path = JavaScriptCore.framework; sourceTree = BUILT_PRODUCTS_DIR; };
    6161/* End PBXFileReference section */
    6262

  • trunk/Tools/lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj

    r234063 r235439  
    3434                7C4AB3A11AF0276C003FC8D1 /* lldbWebKitTester */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; path = lldbWebKitTester; sourceTree = BUILT_PRODUCTS_DIR; };
    3535                7CB6844A1AFA7978002B305C /* main.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = main.cpp; sourceTree = SOURCE_ROOT; };
    36                 CE6C3AFE20C0B17B003E33D8 /* libWTF.a */ = {isa = PBXFileReference; lastKnownFileType = archive.ar; path = libWTF.a; sourceTree = "<group>"; };
     36                CE6C3AFE20C0B17B003E33D8 /* libWTF.a */ = {isa = PBXFileReference; lastKnownFileType = archive.ar; path = libWTF.a; sourceTree = BUILT_PRODUCTS_DIR; };
    3737                CE6C3B0020C0C443003E33D8 /* libicucore.dylib */ = {isa = PBXFileReference; lastKnownFileType = "compiled.mach-o.dylib"; name = libicucore.dylib; path = usr/lib/libicucore.dylib; sourceTree = SDKROOT; };
    3838/* End PBXFileReference section */
Note: See TracChangeset for help on using the changeset viewer.