Changeset 235457 in webkit


Ignore:
Timestamp:
Aug 28, 2018 10:05:23 PM (6 years ago)
Author:
don.olmstead@sony.com
Message:

Check for null renderer in canBeScrolledIntoView
​https://bugs.webkit.org/show_bug.cgi?id=188935

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/spatial-navigation/snav-display-contents-crash.html

  • page/SpatialNavigation.cpp:

(WebCore::canBeScrolledIntoView):

LayoutTests:

  • fast/spatial-navigation/snav-display-contents-crash-expected.txt: Added.
  • fast/spatial-navigation/snav-display-contents-crash.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r235453 r235457  
     12018-08-28  Don Olmstead  <don.olmstead@sony.com>
     2
     3        Check for null renderer in canBeScrolledIntoView
     4        https://bugs.webkit.org/show_bug.cgi?id=188935
     5
     6        Reviewed by Simon Fraser.
     7
     8        * fast/spatial-navigation/snav-display-contents-crash-expected.txt: Added.
     9        * fast/spatial-navigation/snav-display-contents-crash.html: Added.
     10
    1112018-08-28  Youenn Fablet  <youenn@apple.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r235456 r235457  
     12018-08-28  Don Olmstead  <don.olmstead@sony.com>
     2
     3        Check for null renderer in canBeScrolledIntoView
     4        https://bugs.webkit.org/show_bug.cgi?id=188935
     5
     6        Reviewed by Simon Fraser.
     7
     8        Test: fast/spatial-navigation/snav-display-contents-crash.html
     9
     10        * page/SpatialNavigation.cpp:
     11        (WebCore::canBeScrolledIntoView):
     12
    1132018-08-28  Youenn Fablet  <youenn@apple.com>
    214

  • trunk/Source/WebCore/page/SpatialNavigation.cpp

    r232018 r235457  
    706706    LayoutRect candidateRect = candidate.rect;
    707707    for (Node* parentNode = candidate.visibleNode->parentNode(); parentNode; parentNode = parentNode->parentNode()) {
     708        if (!parentNode->renderer())
     709            continue;
    708710        LayoutRect parentRect = nodeRectInAbsoluteCoordinates(parentNode);
    709711        if (!candidateRect.intersects(parentRect)) {
Note: See TracChangeset for help on using the changeset viewer.