Changeset 235618 in webkit
- Timestamp:
- Sep 4, 2018 10:28:28 AM (6 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r235616 r235618 1 2018-09-04 Frederic Wang <fwang@igalia.com> 2 3 Bug 189190 - REGRESSION(r235398) ASSERTION failure !m_client.didFinishDocumentLoadForFrame 4 https://bugs.webkit.org/show_bug.cgi?id=189190 5 6 Reviewed by Alex Christensen. 7 8 Assertions to prevent use of the deprecated WKPageSetPageLoaderClient class are hit when 9 running system Safari with the current macOS/iOS releases, making impossible to launch it. 10 This patch conditionally skips these assertions so that they are only verified for 11 macOS > 10.14 or other platforms. 12 13 * UIProcess/API/C/WKPage.cpp: 14 (WKPageSetPageLoaderClient): Only assert on future OS releases. 15 1 16 2018-09-04 Alex Christensen <achristensen@webkit.org> 2 17 -
trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp
r235560 r235618 1044 1044 initialize(client); 1045 1045 1046 #if !PLATFORM(MAC) || __MAC_OS_X_VERSION_MIN_REQUIRED > 101400 1046 1047 // WKPageSetPageLoaderClient is deprecated. Use WKPageSetPageNavigationClient instead. 1047 1048 RELEASE_ASSERT(!m_client.didFinishDocumentLoadForFrame); … … 1076 1077 RELEASE_ASSERT(!m_client.navigationGestureWillEnd); 1077 1078 RELEASE_ASSERT(!m_client.navigationGestureDidEnd); 1079 #endif 1078 1080 } 1079 1081
Note: See TracChangeset
for help on using the changeset viewer.