Changeset 235818 in webkit


Ignore:
Timestamp:
Sep 7, 2018 4:08:34 PM (6 years ago)
Author:
dbates@webkit.org
Message:

[iOS] uiController.typeCharacterUsingHardwareKeyboard("`", ...) dispatches DOM key events for ~
​https://bugs.webkit.org/show_bug.cgi?id=189325

Reviewed by Wenson Hsieh.

Tools:

Fixes an issue where the test infrastructure would incorrectly synthesized a shift key press followed
by a key press (i.e. type '~') when instructed to simulate typing a grave accent (). Typing a
grave accent does not require holding the shift key.

  • WebKitTestRunner/ios/HIDEventGenerator.mm:

(shouldWrapWithShiftKeyEventForCharacter):

LayoutTests:

Add a test to ensure that we dispatch the correct DOM key events when using uiController.typeCharacterUsingHardwareKeyboard("`")
(by way of UIHelper.typeCharacter()).

  • fast/events/ios/keypress-grave-accent-expected.txt: Added.
  • fast/events/ios/keypress-grave-accent.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r235813 r235818  
     12018-09-07  Daniel Bates  <dabates@apple.com>
     2
     3        [iOS] uiController.typeCharacterUsingHardwareKeyboard("`", ...) dispatches DOM key events for ~
     4        https://bugs.webkit.org/show_bug.cgi?id=189325
     5
     6        Reviewed by Wenson Hsieh.
     7
     8        Add a test to ensure that we dispatch the correct DOM key events when using uiController.typeCharacterUsingHardwareKeyboard("`")
     9        (by way of UIHelper.typeCharacter()).
     10
     11        * fast/events/ios/keypress-grave-accent-expected.txt: Added.
     12        * fast/events/ios/keypress-grave-accent.html: Added.
     13
    1142018-09-07  Basuke Suzuki  <Basuke.Suzuki@sony.com>
    215

  • trunk/Tools/ChangeLog

    r235806 r235818  
     12018-09-07  Daniel Bates  <dabates@apple.com>
     2
     3        [iOS] uiController.typeCharacterUsingHardwareKeyboard("`", ...) dispatches DOM key events for ~
     4        https://bugs.webkit.org/show_bug.cgi?id=189325
     5
     6        Reviewed by Wenson Hsieh.
     7
     8        Fixes an issue where the test infrastructure would incorrectly synthesized a shift key press followed
     9        by a ` key press (i.e. type '~') when instructed to simulate typing a grave accent (`). Typing a
     10        grave accent does not require holding the shift key.
     11
     12        * WebKitTestRunner/ios/HIDEventGenerator.mm:
     13        (shouldWrapWithShiftKeyEventForCharacter):
     14
    1152018-09-07  Frederic Wang  <fwang@igalia.com>
    216

  • trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm

    r234599 r235818  
    800800        return true;
    801801    switch (keyCode) {
    802     case '`':
    803802    case '!':
    804803    case '@':
Note: See TracChangeset for help on using the changeset viewer.