Changeset 235857 in webkit

Timestamp:

Sep 10, 2018, 1:39:57 PM (7 years ago)

Author:

mitz@apple.com

Message:

[macOS] Editor::readSelectionFromPasteboard’s MailBlockquoteHandling argument is effectively unused
​https://bugs.webkit.org/show_bug.cgi?id=189480

Reviewed by Anders Carlsson.

No new tests, because this doesn’t change behavior.

• editing/Editor.h: Removed the MailBlockquoteHandling argument from readSelectionFromPasteboard.
• editing/mac/EditorMac.mm:

(WebCore::Editor::readSelectionFromPasteboard): Don’t pass mailBlockquoteHandling to

pasteWithPasteboard. It was always set to RespectBlockquote, which is the latter’s
default.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/Editor.h (modified) (1 diff)
• editing/mac/EditorMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-09-10  Dan Bernstein  <mitz@apple.com>
+
+        [macOS] Editor::readSelectionFromPasteboard’s MailBlockquoteHandling argument is effectively unused
+        https://bugs.webkit.org/show_bug.cgi?id=189480
+
+        Reviewed by Anders Carlsson.
+
+        No new tests, because this doesn’t change behavior.
+
+        * editing/Editor.h: Removed the MailBlockquoteHandling argument from
+          readSelectionFromPasteboard.
+        * editing/mac/EditorMac.mm:
+        (WebCore::Editor::readSelectionFromPasteboard): Don’t pass mailBlockquoteHandling to
+          pasteWithPasteboard. It was always set to RespectBlockquote, which is the latter’s
+          default.
+
 2018-09-10  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/editing/Editor.h

@@ -472 +472 @@
     bool canCopyExcludingStandaloneImages();
     void takeFindStringFromSelection();
-    WEBCORE_EXPORT void readSelectionFromPasteboard(const String& pasteboardName, MailBlockquoteHandling = MailBlockquoteHandling::RespectBlockquote);
+    WEBCORE_EXPORT void readSelectionFromPasteboard(const String& pasteboardName);
     WEBCORE_EXPORT void replaceNodeFromPasteboard(Node*, const String& pasteboardName);
     WEBCORE_EXPORT RefPtr<SharedBuffer> dataSelectionForPasteboard(const String& pasteboardName);

trunk/Source/WebCore/editing/mac/EditorMac.mm

@@ -119 +119 @@
 }
 
-void Editor::readSelectionFromPasteboard(const String& pasteboardName, MailBlockquoteHandling mailBlockquoteHandling)
+void Editor::readSelectionFromPasteboard(const String& pasteboardName)
 {
     Pasteboard pasteboard(pasteboardName);
     if (m_frame.selection().selection().isContentRichlyEditable())
-        pasteWithPasteboard(&pasteboard, true, mailBlockquoteHandling);
+        pasteWithPasteboard(&pasteboard, true);
     else
         pasteAsPlainTextWithPasteboard(pasteboard);