Changeset 236248 in webkit

Timestamp:

Sep 20, 2018 12:43:15 AM (6 years ago)

Author:

Fujii Hironori

Message:

[Win][Clang] JITMathIC.h: error: missing 'template' keyword prior to dependent template name 'retagged'
​https://bugs.webkit.org/show_bug.cgi?id=189730

Reviewed by Saam Barati.

Clang for Windows can't compile the workaround for MSVC quirk in generateOutOfLine.

• jit/JITMathIC.h:

(generateOutOfLine): Append "&& !COMPILER(CLANG)" to "#if COMPILER(MSVC)".

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• jit/JITMathIC.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-09-20  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][Clang] JITMathIC.h: error: missing 'template' keyword prior to dependent template name 'retagged'
+        https://bugs.webkit.org/show_bug.cgi?id=189730
+
+        Reviewed by Saam Barati.
+
+        Clang for Windows can't compile the workaround for MSVC quirk in generateOutOfLine.
+
+        * jit/JITMathIC.h:
+        (generateOutOfLine): Append "&& !COMPILER(CLANG)" to "#if COMPILER(MSVC)".
+
 2018-09-19  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
 

trunk/Source/JavaScriptCore/jit/JITMathIC.h

@@ -145 +145 @@
 
         auto replaceCall = [&] () {
-#if COMPILER(MSVC)
+#if COMPILER(MSVC) && !COMPILER(CLANG)
             ftlThunkAwareRepatchCall(codeBlock, slowPathCallLocation().retagged<JSInternalPtrTag>(), callReplacement);
 #else