Changeset 236302 in webkit

Timestamp:

Sep 20, 2018 7:49:50 PM (6 years ago)

Author:

Fujii Hironori

Message:

[Win][Clang] UNUSED_PARAM(this) causes compilation error of "cannot take the address of an rvalue of type"
​https://bugs.webkit.org/show_bug.cgi?id=189732

Reviewed by Per Arne Vollan.

Clang for Windows can't compile the MSVC workaround of
UNUSED_PARAM which has been introduced for Windows CE and Visual
Studio 10. I think it's safe just to remove it.

• wtf/Compiler.h: Removed the code for COMPILER(MSVC).

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Compiler.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2018-09-20  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][Clang] UNUSED_PARAM(this) causes compilation error of "cannot take the address of an rvalue of type"
+        https://bugs.webkit.org/show_bug.cgi?id=189732
+
+        Reviewed by Per Arne Vollan.
+
+        Clang for Windows can't compile the MSVC workaround of
+        UNUSED_PARAM which has been introduced for Windows CE and Visual
+        Studio 10. I think it's safe just to remove it.
+
+        * wtf/Compiler.h: Removed the code for COMPILER(MSVC).
+
 2018-09-20  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WTF/wtf/Compiler.h

@@ -364 +364 @@
 /* UNUSED_PARAM */
 
-#if !defined(UNUSED_PARAM) && COMPILER(MSVC)
-#define UNUSED_PARAM(variable) (void)&variable
-#endif
-
 #if !defined(UNUSED_PARAM)
 #define UNUSED_PARAM(variable) (void)variable