Changeset 236303 in webkit


Ignore:
Timestamp:
Sep 20, 2018 8:15:36 PM (6 years ago)
Author:
dbates@webkit.org
Message:

Move IOKitSPI.h from TestRunnerShared to PAL
​https://bugs.webkit.org/show_bug.cgi?id=189804

Reviewed by Wenson Hsieh.

Towards fixing <​https://bugs.webkit.org/show_bug.cgi?id=189604> move the IOKit SPI forward
Source/WebCore/PAL:

declarations to PAL so that they can be shared by both WebKit, DumpRenderTree, and WebKitTestRunner.

No functionality changed. So, no new tests.

  • PAL.xcodeproj/project.pbxproj:
  • pal/spi/cocoa/IOKitSPI.h: Renamed from Tools/TestRunnerShared/spi/IOKitSPI.h.

Tools:

declarations to PAL so that they can be shared by WebKit, DumpRenderTree and WebKitTestRunner.

No functionality changed. So, no new tests.

  • TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
  • TestRunnerShared/spi/UIKitTestSPI.h:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/ios/HIDEventGenerator.mm:
Location:
trunk
Files:
7 edited
1 moved

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/PAL/ChangeLog

    r236015 r236303  
     12018-09-20  Daniel Bates  <dabates@apple.com>
     2
     3        Move IOKitSPI.h from TestRunnerShared to PAL
     4        https://bugs.webkit.org/show_bug.cgi?id=189804
     5
     6        Reviewed by Wenson Hsieh.
     7
     8        Towards fixing <https://bugs.webkit.org/show_bug.cgi?id=189604> move the IOKit SPI forward
     9        declarations to PAL so that they can be shared by both WebKit, DumpRenderTree, and WebKitTestRunner.
     10
     11        No functionality changed. So, no new tests.
     12
     13        * PAL.xcodeproj/project.pbxproj:
     14        * pal/spi/cocoa/IOKitSPI.h: Renamed from Tools/TestRunnerShared/spi/IOKitSPI.h.
     15
    1162018-09-14  Eric Carlson  <eric.carlson@apple.com>
    217

  • trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj

    r234172 r236303  
    147147                A3C66CDC1F462D6A009E6EE9 /* SessionID.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A3C66CDA1F462D6A009E6EE9 /* SessionID.cpp */; };
    148148                A3C66CDD1F462D6A009E6EE9 /* SessionID.h in Headers */ = {isa = PBXBuildFile; fileRef = A3C66CDB1F462D6A009E6EE9 /* SessionID.h */; };
     149                CE5673872151A7B9002F92D7 /* IOKitSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CE5673862151A7B9002F92D7 /* IOKitSPI.h */; };
    149150                E5D45D122106A07400D2B738 /* NSColorWellSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = E5D45D112106A07400D2B738 /* NSColorWellSPI.h */; };
    150151                E5D45D142106A18700D2B738 /* NSPopoverColorWellSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = E5D45D132106A18700D2B738 /* NSPopoverColorWellSPI.h */; };
    … …  
    301302                A3C66CDB1F462D6A009E6EE9 /* SessionID.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SessionID.h; sourceTree = "<group>"; };
    302303                C2147A4A1EFD0AA600056FA5 /* CopyPALHeaders.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = CopyPALHeaders.xcconfig; sourceTree = "<group>"; };
     304                CE5673862151A7B9002F92D7 /* IOKitSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IOKitSPI.h; sourceTree = "<group>"; };
    303305                E5D45D112106A07400D2B738 /* NSColorWellSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NSColorWellSPI.h; sourceTree = "<group>"; };
    304306                E5D45D132106A18700D2B738 /* NSPopoverColorWellSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NSPopoverColorWellSPI.h; sourceTree = "<group>"; };
    … …  
    372374                                0C2DA1251F3BEB4900DBC317 /* DataDetectorsCoreSPI.h */,
    373375                                57F12517205787C8001AB8A6 /* DeviceIdentitySPI.h */,
     376                                CE5673862151A7B9002F92D7 /* IOKitSPI.h */,
    374377                                0C2DA1261F3BEB4900DBC317 /* IOPMLibSPI.h */,
    375378                                0C2DA1271F3BEB4900DBC317 /* IOPSLibSPI.h */,
    … …  
    657660                                A39DE74E1F7C443D007BCB00 /* HysteresisActivity.h in Headers */,
    658661                                0C2DA11F1F3BE9E000DBC317 /* ImageIOSPI.h in Headers */,
     662                                CE5673872151A7B9002F92D7 /* IOKitSPI.h in Headers */,
    659663                                0C2DA1421F3BEB4900DBC317 /* IOPMLibSPI.h in Headers */,
    660664                                0C2DA1431F3BEB4900DBC317 /* IOPSLibSPI.h in Headers */,

  • trunk/Source/WebCore/PAL/pal/spi/cocoa/IOKitSPI.h

    r236302 r236303  
    2525
    2626#pragma once
    27 
    28 #import <wtf/Platform.h>
    2927
    3028#if USE(APPLE_INTERNAL_SDK)

  • trunk/Tools/ChangeLog

    r236299 r236303  
     12018-09-20  Daniel Bates  <dabates@apple.com>
     2
     3        Move IOKitSPI.h from TestRunnerShared to PAL
     4        https://bugs.webkit.org/show_bug.cgi?id=189804
     5
     6        Reviewed by Wenson Hsieh.
     7
     8        Towards fixing <https://bugs.webkit.org/show_bug.cgi?id=189604> move the IOKit SPI forward
     9        declarations to PAL so that they can be shared by WebKit, DumpRenderTree and WebKitTestRunner.
     10
     11        No functionality changed. So, no new tests.
     12
     13        * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
     14        * TestRunnerShared/spi/UIKitTestSPI.h:
     15        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
     16        * WebKitTestRunner/ios/HIDEventGenerator.mm:
     17
    1182018-09-20  Thomas Denney  <tdenney@apple.com>
    219

  • trunk/Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm

    r235837 r236303  
    3030
    3131#import "CoreGraphicsTestSPI.h"
    32 #import "IOKitSPI.h"
    3332#import <algorithm>
    3433#import <mach/mach_time.h>
     34#import <pal/spi/cocoa/IOKitSPI.h>
    3535#import <wtf/RetainPtr.h>
    3636

  • trunk/Tools/TestRunnerShared/spi/UIKitTestSPI.h

    r234601 r236303  
    4444#else
    4545
    46 #import "IOKitSPI.h"
     46#import <pal/spi/cocoa/IOKitSPI.h>
    4747
    4848@interface UIApplication ()

  • trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj

    r235099 r236303  
    222222                0FEBF8581BB61DF20028722D /* HIDEventGenerator.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HIDEventGenerator.h; sourceTree = "<group>"; };
    223223                0FEBF8591BB61DF20028722D /* HIDEventGenerator.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = HIDEventGenerator.mm; sourceTree = "<group>"; };
    224                 0FEBF85B1BB62A370028722D /* IOKitSPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = IOKitSPI.h; path = ../TestRunnerShared/spi/IOKitSPI.h; sourceTree = "<group>"; };
    225224                1A3326051B75396500F89F62 /* TestOptions.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = TestOptions.h; sourceTree = "<group>"; };
    226225                1CA211C71BCA107300B2101F /* FontWithFeatures.otf */ = {isa = PBXFileReference; lastKnownFileType = file; path = FontWithFeatures.otf; sourceTree = "<group>"; };
    … …  
    592591                        children = (
    593592                                2DB6187D1D7D58D400978D19 /* CoreGraphicsTestSPI.h */,
    594                                 0FEBF85B1BB62A370028722D /* IOKitSPI.h */,
    595593                                31268EB91EF06A3B001963E2 /* UIKitTestSPI.h */,
    596594                        );

  • trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm

    r236271 r236303  
    2828
    2929#import "GeneratedTouchesDebugWindow.h"
    30 #import "IOKitSPI.h"
    3130#import "UIKitTestSPI.h"
    3231#import <mach/mach_time.h>
     32#import <pal/spi/cocoa/IOKitSPI.h>
    3333#import <wtf/Assertions.h>
    3434#import <wtf/BlockPtr.h>
Note: See TracChangeset for help on using the changeset viewer.