Changeset 236522 in webkit

Timestamp:

Sep 26, 2018 1:33:00 PM (6 years ago)

Author:

rniwa@webkit.org

Message:

Selection should work across shadow boundary when initiated by a mouse drag
​https://bugs.webkit.org/show_bug.cgi?id=151380
<rdar://problem/24363872>

Revert the change that I said I would from r236519.

• editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/VisibleSelection.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Selection should work across shadow boundary when initiated by a mouse drag
+        https://bugs.webkit.org/show_bug.cgi?id=151380
+        <rdar://problem/24363872>
+
+        Revert the change that I said I would from r236519.
+
+        * editing/VisibleSelection.cpp:
+        (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
+
 2018-09-26  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/editing/VisibleSelection.cpp

@@ -539 +539 @@
 
     if (m_baseIsFirst) {
-        m_extent = adjustPositionForEnd(m_end, startNode.ptr());
+        m_extent = adjustPositionForEnd(m_end, m_start.containerNode());
         m_end = m_extent;
     } else {
-        m_extent = adjustPositionForStart(m_start, endNode.ptr());
+        m_extent = adjustPositionForStart(m_start, m_end.containerNode());
         m_start = m_extent;
     }