Changeset 236648 in webkit


Ignore:
Timestamp:
Sep 30, 2018 3:07:45 PM (6 years ago)
Author:
commit-queue@webkit.org
Message:

AudioNode.connect should return passed destination node
​https://bugs.webkit.org/show_bug.cgi?id=188834

Patch by Walker Henderson <​wjahenderson@gmail.com> on 2018-09-30
Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-return-value-expected.txt:

Source/WebCore:

No new tests, rebaselined existing test.

  • Modules/webaudio/AudioBasicInspectorNode.cpp:

(WebCore::AudioBasicInspectorNode::connect): Deleted.

  • Modules/webaudio/AudioBasicInspectorNode.h:
  • Modules/webaudio/AudioNode.cpp:
  • Modules/webaudio/AudioNode.h:
  • Modules/webaudio/AudioNode.idl:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r236643 r236648  
     12018-09-30  Walker Henderson  <wjahenderson@gmail.com>
     2
     3        AudioNode.connect should return passed destination node
     4        https://bugs.webkit.org/show_bug.cgi?id=188834
     5
     6        Reviewed by Eric Carlson.
     7
     8        * web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-return-value-expected.txt:
     9
    1102018-09-29  Oriol Brufau  <obrufau@igalia.com>
    211

  • trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-return-value-expected.txt

    r230353 r236648  
    11
    2 FAIL connect should return the node connected to. assert_equals: expected (object) object "[object GainNode]" but got (undefined) undefined
     2PASS connect should return the node connected to.
    33

  • trunk/Source/WebCore/ChangeLog

    r236646 r236648  
     12018-09-30  Walker Henderson  <wjahenderson@gmail.com>
     2
     3        AudioNode.connect should return passed destination node
     4        https://bugs.webkit.org/show_bug.cgi?id=188834
     5
     6        Reviewed by Eric Carlson.
     7
     8        No new tests, rebaselined existing test.
     9
     10        * Modules/webaudio/AudioBasicInspectorNode.cpp:
     11        (WebCore::AudioBasicInspectorNode::connect): Deleted.
     12        * Modules/webaudio/AudioBasicInspectorNode.h:
     13        * Modules/webaudio/AudioNode.cpp:
     14        * Modules/webaudio/AudioNode.h:
     15        * Modules/webaudio/AudioNode.idl:
     16
    1172018-09-30  Eric Carlson  <eric.carlson@apple.com>
    218

  • trunk/Source/WebCore/Modules/webaudio/AudioBasicInspectorNode.cpp

    r207672 r236648  
    5050}
    5151
    52 ExceptionOr<void> AudioBasicInspectorNode::connect(AudioNode& destination, unsigned outputIndex, unsigned inputIndex)
     52ExceptionOr<AudioNode&> AudioBasicInspectorNode::connect(AudioNode& destination, unsigned outputIndex, unsigned inputIndex)
    5353{
    5454    ASSERT(isMainThread());

  • trunk/Source/WebCore/Modules/webaudio/AudioBasicInspectorNode.h

    r207672 r236648  
    3838private:
    3939    void pullInputs(size_t framesToProcess) override;
    40     ExceptionOr<void> connect(AudioNode&, unsigned outputIndex, unsigned inputIndex) override;
     40    ExceptionOr<AudioNode&> connect(AudioNode&, unsigned outputIndex, unsigned inputIndex) override;
    4141    ExceptionOr<void> disconnect(unsigned outputIndex) override;
    4242    void checkNumberOfChannelsForInput(AudioNodeInput*) override;

  • trunk/Source/WebCore/Modules/webaudio/AudioNode.cpp

    r233122 r236648  
    123123}
    124124
    125 ExceptionOr<void> AudioNode::connect(AudioNode& destination, unsigned outputIndex, unsigned inputIndex)
     125ExceptionOr<AudioNode&> AudioNode::connect(AudioNode& destination, unsigned outputIndex, unsigned inputIndex)
    126126{
    127127    ASSERT(isMainThread());
    … …  
    145145    context().incrementConnectionCount();
    146146
    147     return { };
     147    return destination;
    148148}
    149149

  • trunk/Source/WebCore/Modules/webaudio/AudioNode.h

    r233650 r236648  
    124124
    125125    // Called from main thread by corresponding JavaScript methods.
    126     virtual ExceptionOr<void> connect(AudioNode&, unsigned outputIndex, unsigned inputIndex);
     126    virtual ExceptionOr<AudioNode&> connect(AudioNode&, unsigned outputIndex, unsigned inputIndex);
    127127    ExceptionOr<void> connect(AudioParam&, unsigned outputIndex);
    128128    virtual ExceptionOr<void> disconnect(unsigned outputIndex);

  • trunk/Source/WebCore/Modules/webaudio/AudioNode.idl

    r222429 r236648  
    3535    attribute DOMString channelInterpretation;
    3636
    37     [MayThrowException] void connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0);
     37    [MayThrowException] AudioNode connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0);
    3838    [MayThrowException] void connect(AudioParam destination, optional unsigned long output = 0);
    3939    [MayThrowException] void disconnect(optional unsigned long output = 0);
Note: See TracChangeset for help on using the changeset viewer.