Changeset 236805 in webkit


Ignore:
Timestamp:
Oct 3, 2018, 11:38:11 AM (7 years ago)
Author:
mitz@apple.com
Message:

bmalloc, WTF and JavaScriptCore parts of [Xcode] Update some build settings as recommended by Xcode 10
​https://bugs.webkit.org/show_bug.cgi?id=190250

Reviewed by Alex Christensen.

Source/bmalloc:

  • Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
  • bmalloc.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.

Source/JavaScriptCore:

  • API/tests/Regress141275.mm:

(-[JSTEvaluator _sourcePerform]): Addressed newly-enabled CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF

by making the self-retaining explicit.

  • API/tests/testapi.cpp:

(testCAPIViaCpp): Addressed newly-enabled CLANG_WARN_UNREACHABLE_CODE by breaking out of the

loop instead of returning from the lambda.

  • Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
  • JavaScriptCore.xcodeproj/project.pbxproj: Removed a duplicate reference to UnlinkedFunctionExecutable.h, and let Xcode update the project file.
  • assembler/MacroAssemblerPrinter.cpp:

(JSC::Printer::printAllRegisters): Addressed newly-enabled CLANG_WARN_COMMA by replacing

some commas with semicolons.

Source/WTF:

  • Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
  • WTF.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
  • wtf/MathExtras.h:

(WTF::fastLog2): Addressed newly-enabled CLANG_WARN_COMMA by splitting some comma-separated

expressions into individual statements.

Location:
trunk
Files:
16 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/API/tests/Regress141275.mm

    r180992 r236805  
    307307                if (task.evaluateBlock) {
    308308                    [self _setupEvaluatorThreadContextIfNeeded];
    309                     task.evaluateBlock(_jsContext);
    310                     if (_jsContext.exception) {
    311                         NSLog(@"Did fail on JSContext: %@", _jsContext.name);
    312                         NSDictionary* userInfo = @{ NSLocalizedDescriptionKey : [_jsContext.exception[@"message"] toString] };
     309                    task.evaluateBlock(self->_jsContext);
     310                    if (self->_jsContext.exception) {
     311                        NSLog(@"Did fail on JSContext: %@", self->_jsContext.name);
     312                        NSDictionary* userInfo = @{ NSLocalizedDescriptionKey : [self->_jsContext.exception[@"message"] toString] };
    313313                        error = [NSError errorWithDomain:@"JSTEvaluator" code:1 userInfo:userInfo];
    314                         _jsContext.exception = nil;
     314                        self->_jsContext.exception = nil;
    315315                    }
    316316                }
    … …  
    325325
    326326        dispatch_barrier_sync(_jsSourcePerformQueue, ^{
    327             if ([_jsContext[@"counter"] toInt32] == scriptToEvaluate)
    328                 dispatch_semaphore_signal(_allScriptsDone);
     327            if ([self->_jsContext[@"counter"] toInt32] == scriptToEvaluate)
     328                dispatch_semaphore_signal(self->_allScriptsDone);
    329329        });
    330330    }

  • trunk/Source/JavaScriptCore/API/tests/testapi.cpp

    r236372 r236805  
    521521                        LockHolder locker(lock);
    522522                        if (tasks.isEmpty())
    523                             return;
     523                            break;
    524524                        task = tasks.takeFirst();
    525525                    }

  • trunk/Source/JavaScriptCore/ChangeLog

    r236804 r236805  
     12018-10-03  Dan Bernstein  <mitz@apple.com>
     2
     3        JavaScriptCore part of [Xcode] Update some build settings as recommended by Xcode 10
     4        https://bugs.webkit.org/show_bug.cgi?id=190250
     5
     6        Reviewed by Alex Christensen.
     7
     8        * API/tests/Regress141275.mm:
     9        (-[JSTEvaluator _sourcePerform]): Addressed newly-enabled CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF
     10          by making the self-retaining explicit.
     11
     12        * API/tests/testapi.cpp:
     13        (testCAPIViaCpp): Addressed newly-enabled CLANG_WARN_UNREACHABLE_CODE by breaking out of the
     14          loop instead of returning from the lambda.
     15
     16        * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_UNREACHABLE_CODE,
     17          CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and
     18          CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
     19
     20        * JavaScriptCore.xcodeproj/project.pbxproj: Removed a duplicate reference to
     21          UnlinkedFunctionExecutable.h, and let Xcode update the project file.
     22
     23        * assembler/MacroAssemblerPrinter.cpp:
     24        (JSC::Printer::printAllRegisters): Addressed newly-enabled CLANG_WARN_COMMA by replacing
     25          some commas with semicolons.
     26
    1272018-10-03  Mark Lam  <mark.lam@apple.com>
    228

  • trunk/Source/JavaScriptCore/Configurations/Base.xcconfig

    r235412 r236805  
    3636CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
    3737CLANG_WARN_BOOL_CONVERSION = YES;
     38CLANG_WARN_COMMA = YES;
    3839CLANG_WARN_CONSTANT_CONVERSION = YES;
    3940CLANG_WARN_CXX0X_EXTENSIONS = NO;
    … …  
    4647CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
    4748CLANG_WARN_STRICT_PROTOTYPES = YES;
     49CLANG_WARN_UNREACHABLE_CODE = YES;
    4850CLANG_WARN_SUSPICIOUS_MOVE = YES;
    4951CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
    … …  
    8486GCC_WARN_ABOUT_RETURN_TYPE = YES;
    8587GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
     88CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
    8689GCC_WARN_SIGN_COMPARE = YES;
    8790GCC_WARN_UNDECLARED_SELECTOR = YES;
     91CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
     92CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
    8893GCC_WARN_UNINITIALIZED_AUTOS = YES;
    8994GCC_WARN_UNUSED_FUNCTION = YES;

  • trunk/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

    r236381 r236805  
    794794                14AD91251DCA9FA40014F9FE /* UnlinkedModuleProgramCodeBlock.h in Headers */ = {isa = PBXBuildFile; fileRef = 14AD911F1DCA9FA40014F9FE /* UnlinkedModuleProgramCodeBlock.h */; settings = {ATTRIBUTES = (Private, ); }; };
    795795                14AD91261DCA9FA40014F9FE /* UnlinkedProgramCodeBlock.h in Headers */ = {isa = PBXBuildFile; fileRef = 14AD91201DCA9FA40014F9FE /* UnlinkedProgramCodeBlock.h */; settings = {ATTRIBUTES = (Private, ); }; };
    796                 14AD91271DCA9FA40014F9FE /* UnlinkedFunctionExecutable.h in Headers */ = {isa = PBXBuildFile; fileRef = 14AD91211DCA9FA40014F9FE /* UnlinkedFunctionExecutable.h */; };
    797796                14B723B812D7DA6F003BD5ED /* MachineStackMarker.h in Headers */ = {isa = PBXBuildFile; fileRef = 14B7234012D7D0DA003BD5ED /* MachineStackMarker.h */; settings = {ATTRIBUTES = (Private, ); }; };
    798797                14B8EC720A5652090062BE54 /* CoreFoundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 6560A4CF04B3B3E7008AE952 /* CoreFoundation.framework */; };
    … …  
    11111110                70ECA6091AFDBEA200449739 /* TemplateObjectDescriptor.h in Headers */ = {isa = PBXBuildFile; fileRef = 70ECA6041AFDBEA200449739 /* TemplateObjectDescriptor.h */; settings = {ATTRIBUTES = (Private, ); }; };
    11121111                72AAF7CE1D0D31B3005E60BE /* JSCustomGetterSetterFunction.h in Headers */ = {isa = PBXBuildFile; fileRef = 72AAF7CC1D0D318B005E60BE /* JSCustomGetterSetterFunction.h */; };
     1112                7593C898BE714A64BE93A6E7 /* WasmContextInlines.h in Headers */ = {isa = PBXBuildFile; fileRef = A27958D7FA1142B0AC9E364D /* WasmContextInlines.h */; settings = {ATTRIBUTES = (Private, ); }; };
    11131113                790081391E95A8EC0052D7CD /* WasmModule.h in Headers */ = {isa = PBXBuildFile; fileRef = 790081371E95A8EC0052D7CD /* WasmModule.h */; settings = {ATTRIBUTES = (Private, ); }; };
    11141114                7905BB691D12050E0019FE57 /* InlineAccess.h in Headers */ = {isa = PBXBuildFile; fileRef = 7905BB671D12050E0019FE57 /* InlineAccess.h */; settings = {ATTRIBUTES = (Private, ); }; };
    … …  
    15241524                AD2FCC2D1DB838FD00B3E736 /* WebAssemblyPrototype.h in Headers */ = {isa = PBXBuildFile; fileRef = AD2FCC271DB838C400B3E736 /* WebAssemblyPrototype.h */; settings = {ATTRIBUTES = (Private, ); }; };
    15251525                AD412B341E7B2E9E008AF157 /* WasmContext.h in Headers */ = {isa = PBXBuildFile; fileRef = AD412B321E7B2E8A008AF157 /* WasmContext.h */; settings = {ATTRIBUTES = (Private, ); }; };
    1526                 7593C898BE714A64BE93A6E7 /* WasmContextInlines.h in Headers */ = {isa = PBXBuildFile; fileRef = A27958D7FA1142B0AC9E364D /* WasmContextInlines.h */; settings = {ATTRIBUTES = (Private, ); }; };
    15271526                AD4252511E5D0E14009D2A97 /* FullCodeOrigin.h in Headers */ = {isa = PBXBuildFile; fileRef = AD4252501E5D0DEB009D2A97 /* FullCodeOrigin.h */; };
    15281527                AD4937C41DDBE6140077C807 /* AbstractModuleRecord.h in Headers */ = {isa = PBXBuildFile; fileRef = AD4937C21DDBE60A0077C807 /* AbstractModuleRecord.h */; settings = {ATTRIBUTES = (Private, ); }; };
    … …  
    31683167                14AD911F1DCA9FA40014F9FE /* UnlinkedModuleProgramCodeBlock.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = UnlinkedModuleProgramCodeBlock.h; sourceTree = "<group>"; };
    31693168                14AD91201DCA9FA40014F9FE /* UnlinkedProgramCodeBlock.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = UnlinkedProgramCodeBlock.h; sourceTree = "<group>"; };
    3170                 14AD91211DCA9FA40014F9FE /* UnlinkedFunctionExecutable.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = UnlinkedFunctionExecutable.h; sourceTree = "<group>"; };
    31713169                14AD91281DCAAAB00014F9FE /* UnlinkedEvalCodeBlock.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = UnlinkedEvalCodeBlock.cpp; sourceTree = "<group>"; };
    31723170                14AD91291DCAAAB00014F9FE /* UnlinkedProgramCodeBlock.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = UnlinkedProgramCodeBlock.cpp; sourceTree = "<group>"; };
    … …  
    39943992                A1E0451B1C25B4B100BB663C /* StringPrototype.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = StringPrototype.js; sourceTree = "<group>"; };
    39953993                A1FE1EB01C2C537E00A289FF /* DatePrototype.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = DatePrototype.js; sourceTree = "<group>"; };
     3994                A27958D7FA1142B0AC9E364D /* WasmContextInlines.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WasmContextInlines.h; sourceTree = "<group>"; };
    39963995                A503FA13188E0FAF00110F14 /* JavaScriptCallFrame.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JavaScriptCallFrame.cpp; sourceTree = "<group>"; };
    39973996                A503FA14188E0FAF00110F14 /* JavaScriptCallFrame.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JavaScriptCallFrame.h; sourceTree = "<group>"; };
    … …  
    43474346                AD2FCC321DC4045300B3E736 /* WasmFormat.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WasmFormat.cpp; sourceTree = "<group>"; };
    43484347                AD412B321E7B2E8A008AF157 /* WasmContext.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WasmContext.h; sourceTree = "<group>"; };
    4349                 A27958D7FA1142B0AC9E364D /* WasmContextInlines.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WasmContextInlines.h; sourceTree = "<group>"; };
    43504348                AD412B351E7B57C0008AF157 /* AllowMacroScratchRegisterUsageIf.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AllowMacroScratchRegisterUsageIf.h; sourceTree = "<group>"; };
    43514349                AD4252501E5D0DEB009D2A97 /* FullCodeOrigin.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = FullCodeOrigin.h; sourceTree = "<group>"; };
    … …  
    77807778                                14AD911D1DCA9FA40014F9FE /* UnlinkedFunctionCodeBlock.h */,
    77817779                                14142E541B7973C000F4BF4B /* UnlinkedFunctionExecutable.cpp */,
    7782                                 14AD91211DCA9FA40014F9FE /* UnlinkedFunctionExecutable.h */,
    77837780                                14142E501B796ECE00F4BF4B /* UnlinkedFunctionExecutable.h */,
    77847781                                14AD911C1DCA9FA40014F9FE /* UnlinkedGlobalCodeBlock.h */,
    … …  
    78137810                        isa = PBXGroup;
    78147811                        children = (
    7815                                 99DA00971BD598E000F4575C /* builtins */,
     7812                                99DA00971BD598E000F4575C /* wkbuiltins */,
    78167813                                9959E9271BD17FA0001AA413 /* cssmin.py */,
    78177814                                9959E92F1BD181F6001AA413 /* generate-combined-inspector-json.py */,
    … …  
    95729569                                14AD91241DCA9FA40014F9FE /* UnlinkedEvalCodeBlock.h in Headers */,
    95739570                                14AD91231DCA9FA40014F9FE /* UnlinkedFunctionCodeBlock.h in Headers */,
    9574                                 14AD91271DCA9FA40014F9FE /* UnlinkedFunctionExecutable.h in Headers */,
    95759571                                14142E511B796ECE00F4BF4B /* UnlinkedFunctionExecutable.h in Headers */,
    95769572                                14AD91221DCA9FA40014F9FE /* UnlinkedGlobalCodeBlock.h in Headers */,
    … …  
    99159911                                BuildIndependentTargetsInParallel = YES;
    99169912                                LastSwiftUpdateCheck = 0700;
    9917                                 LastUpgradeCheck = 0700;
     9913                                LastUpgradeCheck = 1000;
    99189914                        };
    99199915                        buildConfigurationList = 149C277108902AFE008A9EFC /* Build configuration list for PBXProject "JavaScriptCore" */;

  • trunk/Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp

    r234426 r236805  
    5454#define INDENT indent()
    5555
    56     INDENT, out.print("cpu: {\n");
     56    INDENT; out.print("cpu: {\n");
    5757
    5858#if USE(JSVALUE32_64)
    … …  
    6464    for (auto id = MacroAssembler::firstRegister(); id <= MacroAssembler::lastRegister(); id = nextID(id)) {
    6565        intptr_t value = static_cast<intptr_t>(cpu.gpr(id));
    66         INDENT, out.printf("    %6s: " INTPTR_HEX_VALUE_FORMAT "  %" PRIdPTR "\n", cpu.gprName(id), value, value);
     66        INDENT; out.printf("    %6s: " INTPTR_HEX_VALUE_FORMAT "  %" PRIdPTR "\n", cpu.gprName(id), value, value);
    6767    }
    6868    for (auto id = MacroAssembler::firstSPRegister(); id <= MacroAssembler::lastSPRegister(); id = nextID(id)) {
    6969        intptr_t value = static_cast<intptr_t>(cpu.spr(id));
    70         INDENT, out.printf("    %6s: " INTPTR_HEX_VALUE_FORMAT "  %" PRIdPTR "\n", cpu.sprName(id), value, value);
     70        INDENT; out.printf("    %6s: " INTPTR_HEX_VALUE_FORMAT "  %" PRIdPTR "\n", cpu.sprName(id), value, value);
    7171    }
    7272    #undef INTPTR_HEX_VALUE_FORMAT
    … …  
    7575        uint64_t u = bitwise_cast<uint64_t>(cpu.fpr(id));
    7676        double d = cpu.fpr(id);
    77         INDENT, out.printf("    %6s: 0x%016" PRIx64 "  %.13g\n", cpu.fprName(id), u, d);
     77        INDENT; out.printf("    %6s: 0x%016" PRIx64 "  %.13g\n", cpu.fprName(id), u, d);
    7878    }
    7979
    80     INDENT, out.print("}\n");
     80    INDENT; out.print("}\n");
    8181#undef INDENT
    8282

  • trunk/Source/WTF/ChangeLog

    r236804 r236805  
     12018-10-03  Dan Bernstein  <mitz@apple.com>
     2
     3        WTF part of [Xcode] Update some build settings as recommended by Xcode 10
     4        https://bugs.webkit.org/show_bug.cgi?id=190250
     5
     6        Reviewed by Alex Christensen.
     7
     8        * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
     9          and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
     10
     11        * WTF.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
     12
     13        * wtf/MathExtras.h:
     14        (WTF::fastLog2): Addressed newly-enabled CLANG_WARN_COMMA by splitting some comma-separated
     15          expressions into individual statements.
     16
    1172018-10-03  Mark Lam  <mark.lam@apple.com>
    218

  • trunk/Source/WTF/Configurations/Base.xcconfig

    r235412 r236805  
    3939CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
    4040CLANG_WARN_BOOL_CONVERSION = YES;
     41CLANG_WARN_COMMA = YES;
    4142CLANG_WARN_CONSTANT_CONVERSION = YES;
    4243CLANG_WARN_CXX0X_EXTENSIONS = NO;
    … …  
    8889GCC_WARN_ABOUT_RETURN_TYPE = YES;
    8990GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
     91CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
    9092GCC_WARN_SIGN_COMPARE = YES;
    9193GCC_WARN_UNDECLARED_SELECTOR = YES;
     94CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
    9295GCC_WARN_UNINITIALIZED_AUTOS = YES;
    9396GCC_WARN_UNUSED_FUNCTION = YES;

  • trunk/Source/WTF/WTF.xcodeproj/project.pbxproj

    r236748 r236805  
    14161416                        attributes = {
    14171417                                LastSwiftUpdateCheck = 0700;
    1418                                 LastUpgradeCheck = 0700;
     1418                                LastUpgradeCheck = 1000;
    14191419                        };
    14201420                        buildConfigurationList = 5D247B5C14689B8600E78B76 /* Build configuration list for PBXProject "WTF" */;

  • trunk/Source/WTF/wtf/MathExtras.h

    r236737 r236805  
    359359    if (i & (i - 1))
    360360        log2 += 1;
    361     if (i >> 16)
    362         log2 += 16, i >>= 16;
    363     if (i >> 8)
    364         log2 += 8, i >>= 8;
    365     if (i >> 4)
    366         log2 += 4, i >>= 4;
    367     if (i >> 2)
    368         log2 += 2, i >>= 2;
     361    if (i >> 16) {
     362        log2 += 16;
     363        i >>= 16;
     364    }
     365    if (i >> 8) {
     366        log2 += 8;
     367        i >>= 8;
     368    }
     369    if (i >> 4) {
     370        log2 += 4;
     371        i >>= 4;
     372    }
     373    if (i >> 2) {
     374        log2 += 2;
     375        i >>= 2;
     376    }
    369377    if (i >> 1)
    370378        log2 += 1;

  • trunk/Source/bmalloc/ChangeLog

    r236474 r236805  
     12018-10-03  Dan Bernstein  <mitz@apple.com>
     2
     3        bmalloc part of [Xcode] Update some build settings as recommended by Xcode 10
     4        https://bugs.webkit.org/show_bug.cgi?id=190250
     5
     6        Reviewed by Alex Christensen.
     7
     8        * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
     9          and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
     10
     11        * bmalloc.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
     12
    1132018-09-25  Alex Christensen  <achristensen@webkit.org>
    214

  • trunk/Source/bmalloc/Configurations/Base.xcconfig

    r235412 r236805  
    3737CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
    3838CLANG_WARN_BOOL_CONVERSION = YES;
     39CLANG_WARN_COMMA = YES;
    3940CLANG_WARN_CONSTANT_CONVERSION = YES;
    4041CLANG_WARN_CXX0X_EXTENSIONS = NO;
    … …  
    8586GCC_WARN_ABOUT_RETURN_TYPE = YES;
    8687GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
     88CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
    8789GCC_WARN_SIGN_COMPARE = YES;
    8890GCC_WARN_UNDECLARED_SELECTOR = YES;
     91CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
    8992GCC_WARN_UNINITIALIZED_AUTOS = YES;
    9093GCC_WARN_UNUSED_FUNCTION = YES;

  • trunk/Source/bmalloc/bmalloc.xcodeproj/project.pbxproj

    r234326 r236805  
    726726                        attributes = {
    727727                                LastSwiftUpdateCheck = 0700;
    728                                 LastUpgradeCheck = 0700;
     728                                LastUpgradeCheck = 1000;
    729729                                TargetAttributes = {
    730730                                        0F7EB7EE1F95285300F1ABCB = {

  • trunk/Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme

    r210572 r236805  
    11<?xml version="1.0" encoding="UTF-8"?>
    22<Scheme
    3    LastUpgradeVersion = "0810"
     3   LastUpgradeVersion = "1000"
    44   version = "1.3">
    55   <BuildAction

  • trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme

    r227142 r236805  
    11<?xml version="1.0" encoding="UTF-8"?>
    22<Scheme
    3    version = "1.7">
     3   LastUpgradeVersion = "1000"
     4   version = "1.3">
    45   <BuildAction
    56      parallelizeBuildables = "NO"
    … …  
    138139      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
    139140      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
    140       language = ""
    141141      shouldUseLaunchSchemeArgsEnv = "YES">
    142142      <Testables>
    … …  
    158158      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
    159159      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
    160       language = ""
    161160      launchStyle = "0"
    162161      useCustomWorkingDirectory = "NO"

  • trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme

    r227142 r236805  
    11<?xml version="1.0" encoding="UTF-8"?>
    22<Scheme
    3    version = "1.7">
     3   LastUpgradeVersion = "1000"
     4   version = "1.3">
    45   <BuildAction
    56      parallelizeBuildables = "NO"
    … …  
    7071            <BuildableReference
    7172               BuildableIdentifier = "primary"
    72                BlueprintIdentifier = "A18510171B9ADE0B00744AEB"
     73               BlueprintIdentifier = "A115CCB41B9D769D00E89159"
    7374               BuildableName = "All"
    7475               BlueprintName = "All"
Note: See TracChangeset for help on using the changeset viewer.