Changeset 236811 in webkit


Ignore:
Timestamp:
Oct 3, 2018 2:08:53 PM (6 years ago)
Author:
mitz@apple.com
Message:

ANGLE and libwebrtc parts of [Xcode] Update some build settings as recommended by Xcode 10
​https://bugs.webkit.org/show_bug.cgi?id=190250

Reviewed by Andy Estes.

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj/project.pbxproj: Kept the unreachable code warning off for four files that were generated by tools: glslang_lex.cpp, glslang_tab.cpp, Tokenizer.cpp, and ExpressionParser.cpp. Let Xcode update LastUpgradeCheck.
  • Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_INFINITE_RECURSION, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_SUSPICIOUS_MOVE, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.

Source/ThirdParty/libwebrtc:

  • Configurations/Base.xcconfig: Removed a duplicate reference to x_all.c and let Xcode update LastUpgradeCheck.
  • libwebrtc.xcodeproj/project.pbxproj: Enabled CLANG_WARN_INFINITE_RECURSION, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, and CLANG_WARN_SUSPICIOUS_MOVE. Other warnings that Xcode 10 recommended were incompatible with one or more source files in the project.
Location:
trunk/Source/ThirdParty
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj

    r235443 r236811  
    2121                31012E2A18B97B9B0039062F /* ExtensionBehavior.h in Headers */ = {isa = PBXBuildFile; fileRef = 31012DB918B97B9B0039062F /* ExtensionBehavior.h */; };
    2222                31012E2D18B97B9B0039062F /* glslang.h in Headers */ = {isa = PBXBuildFile; fileRef = 31012DBD18B97B9B0039062F /* glslang.h */; };
    23                 31012E3018B97B9B0039062F /* glslang_lex.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 31012DC018B97B9B0039062F /* glslang_lex.cpp */; };
    24                 31012E3118B97B9B0039062F /* glslang_tab.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 31012DC118B97B9B0039062F /* glslang_tab.cpp */; };
     23                31012E3018B97B9B0039062F /* glslang_lex.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 31012DC018B97B9B0039062F /* glslang_lex.cpp */; settings = {COMPILER_FLAGS = "-Wno-unreachable-code"; }; };
     24                31012E3118B97B9B0039062F /* glslang_tab.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 31012DC118B97B9B0039062F /* glslang_tab.cpp */; settings = {COMPILER_FLAGS = "-Wno-unreachable-code"; }; };
    2525                31012E3218B97B9B0039062F /* glslang_tab.h in Headers */ = {isa = PBXBuildFile; fileRef = 31012DC218B97B9B0039062F /* glslang_tab.h */; };
    2626                31012E3318B97B9B0039062F /* HashNames.h in Headers */ = {isa = PBXBuildFile; fileRef = 31012DC318B97B9B0039062F /* HashNames.h */; };
    … …  
    517517                5CCD81C31DBFEAD9006066B8 /* EmulateGLFragColorBroadcast.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5CCD81C11DBFEAD9006066B8 /* EmulateGLFragColorBroadcast.cpp */; };
    518518                5CCD81C41DBFEAD9006066B8 /* EmulateGLFragColorBroadcast.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CCD81C21DBFEAD9006066B8 /* EmulateGLFragColorBroadcast.h */; };
    519                 72309A56183C27DE00370B93 /* Tokenizer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 72309A55183C27DB00370B93 /* Tokenizer.cpp */; };
    520                 72309A58183C27F300370B93 /* ExpressionParser.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 72309A57183C27F100370B93 /* ExpressionParser.cpp */; };
     519                72309A56183C27DE00370B93 /* Tokenizer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 72309A55183C27DB00370B93 /* Tokenizer.cpp */; settings = {COMPILER_FLAGS = "-Wno-unreachable-code"; }; };
     520                72309A58183C27F300370B93 /* ExpressionParser.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 72309A57183C27F100370B93 /* ExpressionParser.cpp */; settings = {COMPILER_FLAGS = "-Wno-unreachable-code"; }; };
    521521                A08C3CDC16D6CB61003F0B83 /* ArrayBoundsClamper.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A08C3CDA16D6CB61003F0B83 /* ArrayBoundsClamper.cpp */; };
    522522                A08C3CDD16D6CB61003F0B83 /* ArrayBoundsClamper.h in Headers */ = {isa = PBXBuildFile; fileRef = A08C3CDB16D6CB61003F0B83 /* ArrayBoundsClamper.h */; };
    … …  
    22832283                        attributes = {
    22842284                                LastSwiftUpdateCheck = 0700;
    2285                                 LastUpgradeCheck = 0700;
     2285                                LastUpgradeCheck = 1000;
    22862286                        };
    22872287                        buildConfigurationList = FB39D0731200ED9200088E69 /* Build configuration list for PBXProject "ANGLE" */;

  • trunk/Source/ThirdParty/ANGLE/ChangeLog

    r236349 r236811  
     12018-10-03  Dan Bernstein  <mitz@apple.com>
     2
     3        ANGLE part of [Xcode] Update some build settings as recommended by Xcode 10
     4        https://bugs.webkit.org/show_bug.cgi?id=190250
     5
     6        Reviewed by Andy Estes.
     7
     8        * ANGLE.xcodeproj/project.pbxproj: Kept the unreachable code warning off for four files that
     9          were generated by tools: glslang_lex.cpp, glslang_tab.cpp, Tokenizer.cpp, and
     10          ExpressionParser.cpp. Let Xcode update LastUpgradeCheck.
     11
     12        * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_INFINITE_RECURSION,
     13          CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_SUSPICIOUS_MOVE,
     14          CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and
     15          CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
     16
    1172018-09-21  Adrian Perez de Castro  <aperez@igalia.com>
    218

  • trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig

    r235412 r236811  
    1515CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
    1616CLANG_WARN_BOOL_CONVERSION = YES;
     17CLANG_WARN_COMMA = YES;
    1718CLANG_WARN_CONSTANT_CONVERSION = YES;
    1819CLANG_WARN_EMPTY_BODY = YES;
    1920CLANG_WARN_ENUM_CONVERSION = YES;
     21CLANG_WARN_INFINITE_RECURSION = YES;
    2022CLANG_WARN_INT_CONVERSION = YES;
    2123CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
     24CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
    2225CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
    2326CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
     27CLANG_WARN_SUSPICIOUS_MOVE = YES;
    2428CLANG_WARN_STRICT_PROTOTYPES = YES;
     29CLANG_WARN_UNREACHABLE_CODE = YES;
    2530CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
    2631DEAD_CODE_STRIPPING = YES;
    … …  
    4853GCC_WARN_ABOUT_RETURN_TYPE = YES;
    4954GCC_WARN_UNDECLARED_SELECTOR = YES;
     55CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
     56CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
    5057GCC_WARN_UNINITIALIZED_AUTOS = YES;
    5158GCC_WARN_UNUSED_FUNCTION = YES;

  • trunk/Source/ThirdParty/libwebrtc/ChangeLog

    r236792 r236811  
     12018-10-03  Dan Bernstein  <mitz@apple.com>
     2
     3        libwebrtc part of [Xcode] Update some build settings as recommended by Xcode 10
     4        https://bugs.webkit.org/show_bug.cgi?id=190250
     5
     6        Reviewed by Andy Estes.
     7
     8        * Configurations/Base.xcconfig: Removed a duplicate reference to x_all.c and let Xcode
     9          update LastUpgradeCheck.
     10
     11        * libwebrtc.xcodeproj/project.pbxproj: Enabled CLANG_WARN_INFINITE_RECURSION,
     12          CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, and
     13          CLANG_WARN_SUSPICIOUS_MOVE. Other warnings that Xcode 10 recommended were incompatible
     14          with one or more source files in the project.
     15
    1162018-10-03  Youenn Fablet  <youenn@apple.com>
    217

  • trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig

    r235430 r236811  
    1919CLANG_WARN_EMPTY_BODY = YES;
    2020CLANG_WARN_ENUM_CONVERSION = YES;
     21CLANG_WARN_INFINITE_RECURSION = YES;
    2122CLANG_WARN_INT_CONVERSION = YES;
    2223CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
    … …  
    4849GCC_WARN_ABOUT_RETURN_TYPE = YES;
    4950GCC_WARN_UNDECLARED_SELECTOR = YES;
     51CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
     52CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
    5053GCC_WARN_UNINITIALIZED_AUTOS = YES;
    5154GCC_WARN_UNUSED_FUNCTION = YES;
    5255GCC_WARN_UNUSED_VARIABLE = YES;
     56CLANG_WARN_SUSPICIOUS_MOVE = YES;
    5357PREBINDING = NO;
    5458STRIP_INSTALLED_PRODUCT = NO;

  • trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj

    r236792 r236811  
    14531453                5C4B467F1E42AA3C002651C8 /* vpm_int.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C4B44BE1E42A6F7002651C8 /* vpm_int.h */; };
    14541454                5C4B46801E42AA3C002651C8 /* x_algor.c in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B44BF1E42A6F7002651C8 /* x_algor.c */; };
    1455                 5C4B46811E42AA3C002651C8 /* x_all.c in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B44C01E42A6F7002651C8 /* x_all.c */; };
    14561455                5C4B46821E42AA3C002651C8 /* x_attrib.c in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B44C11E42A6F7002651C8 /* x_attrib.c */; };
    14571456                5C4B46831E42AA3C002651C8 /* x_crl.c in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B44C21E42A6F7002651C8 /* x_crl.c */; };
    … …  
    1459814597                                DefaultBuildSystemTypeForWorkspace = Original;
    1459914598                                LastSwiftUpdateCheck = 0700;
    14600                                 LastUpgradeCheck = 0700;
     14599                                LastUpgradeCheck = 1000;
    1460114600                                TargetAttributes = {
    1460214601                                        41F77D15215BE45E00E72967 = {
    … …  
    1527615275                                5C4B46801E42AA3C002651C8 /* x_algor.c in Sources */,
    1527715276                                41A391CC1EFC46DE00C4516A /* x_all.c in Sources */,
    15278                                 5C4B46811E42AA3C002651C8 /* x_all.c in Sources */,
    1527915277                                5C4B46821E42AA3C002651C8 /* x_attrib.c in Sources */,
    1528015278                                5C4B46831E42AA3C002651C8 /* x_crl.c in Sources */,
Note: See TracChangeset for help on using the changeset viewer.