Changeset 236832 in webkit
- Timestamp:
- Oct 4, 2018 9:46:49 AM (6 years ago)
- Location:
- trunk/Source
- Files:
-
- 10 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r236831 r236832 1 2018-10-04 Dan Bernstein <mitz@apple.com> 2 3 WebCore part of [Xcode] Update some build settings as recommended by Xcode 10 4 https://bugs.webkit.org/show_bug.cgi?id=190250 5 6 Reviewed by Andy Estes. 7 8 * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, 9 CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, and CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS. 10 11 * WebCore.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck and remove a 12 duplicate reference in a Compile Sources build phase. 13 14 * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Suppress -Wdeprecated-implementations 15 around implementations of deprecated accessibility methods. 16 17 * loader/TextResourceDecoder.cpp: 18 (WebCore::TextResourceDecoder::checkForBOM): Addressed CLANG_WARN_COMMA. 19 20 * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm: 21 (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveAuthenticationChallenge:]): 22 Suppress -Wdeprecated-implementations around implementations of this deprecated delegate method. 23 (-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]): Ditto. 24 1 25 2018-10-02 Darin Adler <darin@apple.com> 2 26 -
trunk/Source/WebCore/Configurations/Base.xcconfig
r235412 r236832 38 38 CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; 39 39 CLANG_WARN_BOOL_CONVERSION = YES; 40 CLANG_WARN_COMMA = YES; 40 41 CLANG_WARN_CONSTANT_CONVERSION = YES; 41 42 CLANG_WARN_CXX0X_EXTENSIONS = NO; … … 52 53 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; 53 54 GCC_WARN_UNDECLARED_SELECTOR = YES; 55 CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; 56 CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES; 54 57 COMBINE_HIDPI_IMAGES = NO; 55 58 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym; … … 80 83 GCC_WARN_ABOUT_RETURN_TYPE = YES; 81 84 GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES; 85 CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES; 82 86 GCC_WARN_SIGN_COMPARE = YES; 83 87 GCC_WARN_UNINITIALIZED_AUTOS = YES; -
trunk/Source/WebCore/PAL/ChangeLog
r236750 r236832 1 2018-10-04 Dan Bernstein <mitz@apple.com> 2 3 PAL part of [Xcode] Update some build settings as recommended by Xcode 10 4 https://bugs.webkit.org/show_bug.cgi?id=190250 5 6 Reviewed by Andy Estes. 7 8 * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, 9 CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, and CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS. 10 11 * PAL.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck. 12 1 13 2018-10-01 Dean Jackson <dino@apple.com> 2 14 -
trunk/Source/WebCore/PAL/Configurations/Base.xcconfig
r235412 r236832 38 38 CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; 39 39 CLANG_WARN_BOOL_CONVERSION = YES; 40 CLANG_WARN_COMMA = YES; 40 41 CLANG_WARN_CONSTANT_CONVERSION = YES; 41 42 CLANG_WARN_CXX0X_EXTENSIONS = NO; … … 52 53 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; 53 54 GCC_WARN_UNDECLARED_SELECTOR = YES; 55 CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; 56 CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES; 54 57 COMBINE_HIDPI_IMAGES = NO; 55 58 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym; … … 80 83 GCC_WARN_ABOUT_RETURN_TYPE = YES; 81 84 GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES; 85 CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES; 82 86 GCC_WARN_SIGN_COMPARE = YES; 83 87 GCC_WARN_UNINITIALIZED_AUTOS = YES; -
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
r236481 r236832 783 783 isa = PBXProject; 784 784 attributes = { 785 LastUpgradeCheck = 0830;785 LastUpgradeCheck = 1000; 786 786 TargetAttributes = { 787 787 1C09D03C1E31C32800725F18 = { -
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
r236828 r236832 201 201 07B7116F1D899E63009F0FFB /* CaptureDeviceManager.h in Headers */ = {isa = PBXBuildFile; fileRef = 07B7116C1D899E63009F0FFB /* CaptureDeviceManager.h */; settings = {ATTRIBUTES = (Private, ); }; }; 202 202 07C046C41E42508B007201E7 /* CAAudioStreamDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 073B87581E40DCFD0071C0EC /* CAAudioStreamDescription.h */; settings = {ATTRIBUTES = (Private, ); }; }; 203 07C046C81E425155007201E7 /* AudioTrackPrivateMediaStreamCocoa.h in Headers */ = {isa = PBXBuildFile; fileRef = 07C046C61E42512F007201E7 /* AudioTrackPrivateMediaStreamCocoa.h */; };204 203 07C046CB1E426413007201E7 /* AudioStreamDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 073B87561E40DCE50071C0EC /* AudioStreamDescription.h */; settings = {ATTRIBUTES = (Private, ); }; }; 205 204 07C1C0E21BFB600100BD2256 /* MediaTrackSupportedConstraints.h in Headers */ = {isa = PBXBuildFile; fileRef = 07C1C0E01BFB600100BD2256 /* MediaTrackSupportedConstraints.h */; }; … … 1003 1002 372ADA38197F47B900FC501E /* ProtectionSpaceCocoa.h in Headers */ = {isa = PBXBuildFile; fileRef = 372ADA37197F47B900FC501E /* ProtectionSpaceCocoa.h */; settings = {ATTRIBUTES = (Private, ); }; }; 1004 1003 372C00D9129619F8005C9575 /* FindOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 372C00D8129619F8005C9575 /* FindOptions.h */; settings = {ATTRIBUTES = (Private, ); }; }; 1004 372D3E54216578AE00C5E021 /* DataURLDecoder.h in Headers */ = {isa = PBXBuildFile; fileRef = E4A007821B820EC8002C5A6E /* DataURLDecoder.h */; }; 1005 372D3E55216578AE00C5E021 /* ScriptModuleLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = E38838951BAD145F00D62EE3 /* ScriptModuleLoader.h */; }; 1006 372D3E56216578AE00C5E021 /* AudioTrackPrivateMediaStreamCocoa.h in Headers */ = {isa = PBXBuildFile; fileRef = 07C046C61E42512F007201E7 /* AudioTrackPrivateMediaStreamCocoa.h */; }; 1007 372D3E57216578AE00C5E021 /* NavigatorCredentials.h in Headers */ = {isa = PBXBuildFile; fileRef = 57D846261FE895F800CA3682 /* NavigatorCredentials.h */; }; 1005 1008 375CD232119D43C800A2A859 /* Hyphenation.h in Headers */ = {isa = PBXBuildFile; fileRef = 375CD231119D43C800A2A859 /* Hyphenation.h */; }; 1006 1009 3774ABA50FA21EB400AD7DE9 /* OverlapTestRequestClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 3774ABA30FA21EB400AD7DE9 /* OverlapTestRequestClient.h */; settings = {ATTRIBUTES = (Private, ); }; }; … … 1722 1725 555B87ED1CAAF0AB00349425 /* ImageDecoderCG.h in Headers */ = {isa = PBXBuildFile; fileRef = 555B87EB1CAAF0AB00349425 /* ImageDecoderCG.h */; }; 1723 1726 5576A5651D88A70800CCC04C /* ImageFrame.h in Headers */ = {isa = PBXBuildFile; fileRef = 5576A5631D88A70800CCC04C /* ImageFrame.h */; settings = {ATTRIBUTES = (Private, ); }; }; 1724 55A336F71D8209F40022C4C7 /* NativeImage.h in Headers */ = {isa = PBXBuildFile; fileRef = 55A336F61D8209F40022C4C7 /* NativeImage.h */; };1725 1727 55A336F91D821E3C0022C4C7 /* ImageBackingStore.h in Headers */ = {isa = PBXBuildFile; fileRef = 55A336F81D821E3C0022C4C7 /* ImageBackingStore.h */; settings = {ATTRIBUTES = (Private, ); }; }; 1726 1728 55AF14E61EAAC59B0026EEAA /* UTIRegistry.h in Headers */ = {isa = PBXBuildFile; fileRef = 55AF14E41EAAC59B0026EEAA /* UTIRegistry.h */; settings = {ATTRIBUTES = (Private, ); }; }; … … 1787 1789 57C7A69F1E57917800C67D71 /* JSBasicCredential.h in Headers */ = {isa = PBXBuildFile; fileRef = 57C7A69D1E57910D00C67D71 /* JSBasicCredential.h */; }; 1788 1790 57D0018D1DD5413200ED19D9 /* JSCryptoKeyUsage.h in Headers */ = {isa = PBXBuildFile; fileRef = 57D0018C1DD5413200ED19D9 /* JSCryptoKeyUsage.h */; }; 1789 57D846281FE8960500CA3682 /* NavigatorCredentials.h in Headers */ = {isa = PBXBuildFile; fileRef = 57D846261FE895F800CA3682 /* NavigatorCredentials.h */; };1790 1791 57D8462E1FEAF69900CA3682 /* PublicKeyCredential.h in Headers */ = {isa = PBXBuildFile; fileRef = 57D8462B1FEAF68F00CA3682 /* PublicKeyCredential.h */; settings = {ATTRIBUTES = (Private, ); }; }; 1791 1792 57D846351FEAFCD300CA3682 /* JSPublicKeyCredential.h in Headers */ = {isa = PBXBuildFile; fileRef = 57D846301FEAFC2F00CA3682 /* JSPublicKeyCredential.h */; }; … … 4716 4717 E377FE4D1DADE16500CDD025 /* NodeConstants.h in Headers */ = {isa = PBXBuildFile; fileRef = E3D049931DADC04500718F3C /* NodeConstants.h */; settings = {ATTRIBUTES = (Private, ); }; }; 4717 4718 E37C86501EB63E3F0087C6CA /* JSDOMPromise.h in Headers */ = {isa = PBXBuildFile; fileRef = E37C864F1EB63E2D0087C6CA /* JSDOMPromise.h */; settings = {ATTRIBUTES = (Private, ); }; }; 4718 E38838991BAD145F00D62EE3 /* ScriptModuleLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = E38838951BAD145F00D62EE3 /* ScriptModuleLoader.h */; };4719 4719 E3A776671DC85D2800B690D8 /* DOMJITIDLConvert.h in Headers */ = {isa = PBXBuildFile; fileRef = E3A776651DC85D2200B690D8 /* DOMJITIDLConvert.h */; settings = {ATTRIBUTES = (Private, ); }; }; 4720 4720 E3A776681DC85D2800B690D8 /* DOMJITIDLType.h in Headers */ = {isa = PBXBuildFile; fileRef = E3A776661DC85D2200B690D8 /* DOMJITIDLType.h */; settings = {ATTRIBUTES = (Private, ); }; }; … … 4782 4782 E4946EAF156E64DD00D3297F /* StyleRuleImport.h in Headers */ = {isa = PBXBuildFile; fileRef = E4946EAD156E64DD00D3297F /* StyleRuleImport.h */; settings = {ATTRIBUTES = (Private, ); }; }; 4783 4783 E49BD9FA131FD2ED003C56F0 /* CSSValuePool.h in Headers */ = {isa = PBXBuildFile; fileRef = E49BD9F9131FD2ED003C56F0 /* CSSValuePool.h */; }; 4784 E4A007831B820EC8002C5A6E /* DataURLDecoder.h in Headers */ = {isa = PBXBuildFile; fileRef = E4A007821B820EC8002C5A6E /* DataURLDecoder.h */; };4785 4784 E4A7995220EE4B1400C19568 /* CSSParserContext.h in Headers */ = {isa = PBXBuildFile; fileRef = E4A7994E20EE4AE100C19568 /* CSSParserContext.h */; settings = {ATTRIBUTES = (Private, ); }; }; 4786 4785 E4A814D41C6DEC4000BF85AC /* ClassChangeInvalidation.h in Headers */ = {isa = PBXBuildFile; fileRef = E4A814D31C6DEC4000BF85AC /* ClassChangeInvalidation.h */; }; … … 27322 27321 CD54A763180F9F7000B076C9 /* AudioTrackPrivateMediaSourceAVFObjC.h in Headers */, 27323 27322 07D6A4F81BF2307D00174146 /* AudioTrackPrivateMediaStream.h in Headers */, 27324 07C046C81E425155007201E7 /* AudioTrackPrivateMediaStreamCocoa.h in Headers */, 27325 07C046C81E425155007201E7 /* AudioTrackPrivateMediaStreamCocoa.h in Headers */, 27323 372D3E56216578AE00C5E021 /* AudioTrackPrivateMediaStreamCocoa.h in Headers */, 27326 27324 FD31608B12B026F700C1A359 /* AudioUtilities.h in Headers */, 27327 27325 7EE6846112D26E3800E79415 /* AuthenticationChallenge.h in Headers */, … … 27799 27797 81AC5999131636E60009A7E0 /* DataTransferItem.h in Headers */, 27800 27798 81AC599A131636E60009A7E0 /* DataTransferItemList.h in Headers */, 27801 E4A007831B820EC8002C5A6E /* DataURLDecoder.h in Headers */, 27802 E4A007831B820EC8002C5A6E /* DataURLDecoder.h in Headers */, 27799 372D3E54216578AE00C5E021 /* DataURLDecoder.h in Headers */, 27803 27800 A5732B0B136A161D005C8D7C /* DateComponents.h in Headers */, 27804 27801 F55B3DB61251F12D003EF269 /* DateInputType.h in Headers */, … … 29671 29668 A818721E0977D3C0005826D9 /* NameNodeList.h in Headers */, 29672 29669 6B3480940EEF50D400AC1B41 /* NativeImage.h in Headers */, 29673 55A336F71D8209F40022C4C7 /* NativeImage.h in Headers */,29674 29670 83B2D1751B8BCD6A00A02E47 /* NativeNodeFilter.h in Headers */, 29675 29671 E10B9B6C0B747599003ED890 /* NativeXPathNSResolver.h in Headers */, … … 29679 29675 E12719C70EEEC16800F61213 /* NavigatorBase.h in Headers */, 29680 29676 8321507E1F27EA1B0095B136 /* NavigatorBeacon.h in Headers */, 29681 57D846281FE8960500CA3682 /* NavigatorCredentials.h in Headers */, 29682 57D846281FE8960500CA3682 /* NavigatorCredentials.h in Headers */, 29677 372D3E57216578AE00C5E021 /* NavigatorCredentials.h in Headers */, 29683 29678 9711460414EF009A00674FD9 /* NavigatorGeolocation.h in Headers */, 29684 29679 5EA725D61ACABD5700EAD17B /* NavigatorMediaDevices.h in Headers */, … … 30253 30248 E3E4E2A81E3B17100023BB8A /* ScriptElementCachedScriptFetcher.h in Headers */, 30254 30249 E11C9D9B0EB3681200E409DB /* ScriptExecutionContext.h in Headers */, 30255 E38838991BAD145F00D62EE3 /* ScriptModuleLoader.h in Headers */, 30256 E38838991BAD145F00D62EE3 /* ScriptModuleLoader.h in Headers */, 30250 372D3E55216578AE00C5E021 /* ScriptModuleLoader.h in Headers */, 30257 30251 FD31603612B0267600C1A359 /* ScriptProcessorNode.h in Headers */, 30258 30252 8A413AE01207BBA50082016E /* ScriptRunner.h in Headers */, … … 31325 31319 BuildIndependentTargetsInParallel = YES; 31326 31320 LastSwiftUpdateCheck = 0700; 31327 LastUpgradeCheck = 0700;31321 LastUpgradeCheck = 1000; 31328 31322 }; 31329 31323 buildConfigurationList = 149C284308902B11008A9EFC /* Build configuration list for PBXProject "WebCore" */; -
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
r235935 r236832 1118 1118 } 1119 1119 1120 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 1120 1121 - (NSArray*)accessibilityActionNames 1122 IGNORE_WARNINGS_END 1121 1123 { 1122 1124 if (![self updateObjectBackingStore]) … … 1252 1254 } 1253 1255 1256 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 1254 1257 - (NSArray*)accessibilityAttributeNames 1258 IGNORE_WARNINGS_END 1255 1259 { 1256 1260 if (![self updateObjectBackingStore]) … … 2427 2431 // suggestions: Use a hash table that maps attribute names to function calls, 2428 2432 // or maybe pointers to member functions 2433 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 2429 2434 - (id)accessibilityAttributeValue:(NSString*)attributeName 2435 IGNORE_WARNINGS_END 2430 2436 { 2431 2437 if (![self updateObjectBackingStore]) … … 3302 3308 } 3303 3309 3310 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 3304 3311 - (BOOL)accessibilityIsAttributeSettable:(NSString*)attributeName 3312 IGNORE_WARNINGS_END 3305 3313 { 3306 3314 if (![self updateObjectBackingStore]) … … 3355 3363 // 3356 3364 // Registering an object is also required for observing notifications. Only registered objects can be observed. 3365 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 3357 3366 - (BOOL)accessibilityIsIgnored 3367 IGNORE_WARNINGS_END 3358 3368 { 3359 3369 if (![self updateObjectBackingStore]) … … 3365 3375 } 3366 3376 3377 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 3367 3378 - (NSArray* )accessibilityParameterizedAttributeNames 3379 IGNORE_WARNINGS_END 3368 3380 { 3369 3381 if (![self updateObjectBackingStore]) … … 3585 3597 } 3586 3598 3599 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 3587 3600 - (void)accessibilityPerformAction:(NSString*)action 3601 IGNORE_WARNINGS_END 3588 3602 { 3589 3603 if (![self updateObjectBackingStore]) … … 3616 3630 } 3617 3631 3632 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 3618 3633 - (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attributeName 3634 IGNORE_WARNINGS_END 3619 3635 { 3620 3636 #if PLATFORM(MAC) … … 3759 3775 } 3760 3776 3777 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 3761 3778 - (NSString*)accessibilityActionDescription:(NSString*)action 3779 IGNORE_WARNINGS_END 3762 3780 { 3763 3781 // we have no custom actions … … 3888 3906 #endif 3889 3907 3908 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 3890 3909 - (id)accessibilityAttributeValue:(NSString*)attribute forParameter:(id)parameter 3910 IGNORE_WARNINGS_END 3891 3911 { 3892 3912 id textMarker = nil; -
trunk/Source/WebCore/loader/TextResourceDecoder.cpp
r236565 r236832 416 416 const unsigned char* buf1 = reinterpret_cast<const unsigned char*>(m_buffer.data()); 417 417 const unsigned char* buf2 = reinterpret_cast<const unsigned char*>(data); 418 unsigned char c1 = buf1Len ? ( --buf1Len, *buf1++) : buf2Len ? (--buf2Len, *buf2++) : 0;419 unsigned char c2 = buf1Len ? ( --buf1Len, *buf1++) : buf2Len ? (--buf2Len, *buf2++) : 0;420 unsigned char c3 = buf1Len ? ( --buf1Len, *buf1++) : buf2Len ? (--buf2Len, *buf2++) : 0;418 unsigned char c1 = buf1Len ? (static_cast<void>(--buf1Len), *buf1++) : buf2Len ? (static_cast<void>(--buf2Len), *buf2++) : 0; 419 unsigned char c2 = buf1Len ? (static_cast<void>(--buf1Len), *buf1++) : buf2Len ? (static_cast<void>(--buf2Len), *buf2++) : 0; 420 unsigned char c3 = buf1Len ? (static_cast<void>(--buf1Len), *buf1++) : buf2Len ? (static_cast<void>(--buf2Len), *buf2++) : 0; 421 421 422 422 // Check for the BOM. -
trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm
r236101 r236832 162 162 } 163 163 164 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 164 165 - (void)connection:(NSURLConnection *)connection didReceiveAuthenticationChallenge:(NSURLAuthenticationChallenge *)challenge 166 IGNORE_WARNINGS_END 165 167 { 166 168 ASSERT(!isMainThread()); … … 180 182 } 181 183 184 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 182 185 - (BOOL)connection:(NSURLConnection *)connection canAuthenticateAgainstProtectionSpace:(NSURLProtectionSpace *)protectionSpace 186 IGNORE_WARNINGS_END 183 187 { 184 188 ASSERT(!isMainThread()); -
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
r236773 r236832 10107 10107 runOnlyForDeploymentPostprocessing = 0; 10108 10108 shellPath = /bin/sh; 10109 shellScript = "if [ \"${ACTION}\" = \"build\" -o \"${ACTION}\" = \"install\" -o \"${ACTION}\" = \"installhdrs\" -o \"${ACTION}\" = \"installapi\" ]; then\n exec ${SRCROOT}/mac/postprocess-framework-headers.sh\nfi ";10109 shellScript = "if [ \"${ACTION}\" = \"build\" -o \"${ACTION}\" = \"install\" -o \"${ACTION}\" = \"installhdrs\" -o \"${ACTION}\" = \"installapi\" ]; then\n exec ${SRCROOT}/mac/postprocess-framework-headers.sh\nfi\n"; 10110 10110 }; 10111 10111 1A2180161B5454620046AEC4 /* Add Symlink in /System/Library/PrivateFrameworks */ = {
Note: See TracChangeset
for help on using the changeset viewer.