Changeset 236902 in webkit


Ignore:
Timestamp:
Oct 6, 2018 6:29:52 PM (5 years ago)
Author:
mitz@apple.com
Message:

WebKit part of [Xcode] Update some build settings as recommended by Xcode 10
https://bugs.webkit.org/show_bug.cgi?id=190250

Reviewed by Andy Estes.

  • Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:
  • UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:
  • UIProcess/API/Cocoa/WKConnection.mm:
  • UIProcess/API/Cocoa/WKNavigationData.mm:
  • UIProcess/API/Cocoa/WKProcessGroup.mm:
  • UIProcess/API/Cocoa/WKTypeRefWrapper.mm:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
  • UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
  • UIProcess/API/mac/WKView.mm:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

Suppressed -Wdeprecated-implementations around some class, category and method
implementations the above files.

Location:
trunk/Source/WebKit
Files:
18 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r236886 r236902  
     12018-10-06  Dan Bernstein  <mitz@apple.com>
     2
     3        WebKit part of [Xcode] Update some build settings as recommended by Xcode 10
     4        https://bugs.webkit.org/show_bug.cgi?id=190250
     5
     6        Reviewed by Andy Estes.
     7
     8        * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
     9          CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and
     10          CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
     11
     12        * WebKit.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
     13
     14        * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
     15        * UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:
     16        * UIProcess/API/Cocoa/WKConnection.mm:
     17        * UIProcess/API/Cocoa/WKNavigationData.mm:
     18        * UIProcess/API/Cocoa/WKProcessGroup.mm:
     19        * UIProcess/API/Cocoa/WKTypeRefWrapper.mm:
     20        * UIProcess/API/Cocoa/WKWebView.mm:
     21        * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
     22        * UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
     23        * UIProcess/API/mac/WKView.mm:
     24        * WebProcess/Plugins/PDF/PDFPlugin.mm:
     25        * WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
     26
     27          Suppressed -Wdeprecated-implementations around some class, category and method
     28          implementations the above files.
     29
    1302018-10-05  Alex Christensen  <achristensen@webkit.org>
    231
  • trunk/Source/WebKit/Configurations/Base.xcconfig

    r235412 r236902  
    3636CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
    3737CLANG_WARN_BOOL_CONVERSION = YES;
     38CLANG_WARN_COMMA = YES;
    3839CLANG_WARN_CONSTANT_CONVERSION = YES;
    3940CLANG_WARN_CXX0X_EXTENSIONS = NO;
     
    7576GCC_WARN_ABOUT_RETURN_TYPE = YES;
    7677GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
     78CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
    7779GCC_WARN_SIGN_COMPARE = YES;
    7880GCC_WARN_UNDECLARED_SELECTOR = YES;
     81CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
     82CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
    7983GCC_WARN_UNINITIALIZED_AUTOS = YES;
    8084GCC_WARN_UNUSED_FUNCTION = YES;
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm

    r236665 r236902  
    7373NSString * const WKActionCanShowMIMETypeKey = @"WKActionCanShowMIMETypeKey";
    7474
     75IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    7576@implementation WKBrowsingContextController {
     77IGNORE_WARNINGS_END
    7678    RefPtr<WebKit::WebPageProxy> _page;
    7779    std::unique_ptr<WebKit::PageLoadStateObserver> _pageLoadStateObserver;
     
    619621
    620622ALLOW_DEPRECATED_DECLARATIONS_BEGIN
     623IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    621624@implementation WKBrowsingContextController (Private)
     625IGNORE_WARNINGS_END
    622626
    623627- (WKPageRef)_pageRef
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.mm

    r236665 r236902  
    4343#import <wtf/Vector.h>
    4444
     45IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    4546@implementation WKBrowsingContextGroup {
     47IGNORE_WARNINGS_END
    4648    API::ObjectStorage<WebKit::WebPageGroup> _pageGroup;
    4749}
     
    177179
    178180ALLOW_DEPRECATED_DECLARATIONS_BEGIN
     181IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    179182@implementation WKBrowsingContextGroup (Private)
     183IGNORE_WARNINGS_END
    180184
    181185- (WKPageGroupRef)_pageGroupRef
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm

    r236775 r236902  
    3737#import <wtf/text/WTFString.h>
    3838
     39IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    3940@implementation WKConnection {
     41IGNORE_WARNINGS_END
    4042    WeakObjCPtr<id <WKConnectionDelegate>> _delegate;
    4143}
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.mm

    r235828 r236902  
    3333#import <WebCore/ResourceResponse.h>
    3434
     35IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    3536@implementation WKNavigationData {
     37IGNORE_WARNINGS_END
    3638    API::ObjectStorage<API::NavigationData> _data;
    3739}
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.mm

    r236665 r236902  
    5353#endif
    5454
     55IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    5556@implementation WKProcessGroup {
     57IGNORE_WARNINGS_END
    5658    RefPtr<WebKit::WebProcessPool> _processPool;
    5759
     
    221223
    222224ALLOW_DEPRECATED_DECLARATIONS_BEGIN
     225IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    223226@implementation WKProcessGroup (Private)
     227IGNORE_WARNINGS_END
    224228
    225229- (WKContextRef)_contextRef
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKTypeRefWrapper.mm

    r159874 r236902  
    3737@end
    3838
     39IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    3940@implementation WKTypeRefWrapper
     41IGNORE_WARNINGS_END
    4042
    4143- (id)initWithObject:(WKTypeRef)object
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm

    r236867 r236902  
    32963296}
    32973297
     3298IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    32983299- (void)renewGState
     3300IGNORE_WARNINGS_END
    32993301{
    33003302    _impl->renewGState();
     
    37903792
    37913793#if ENABLE(DRAG_SUPPORT)
     3794IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    37923795- (void)draggedImage:(NSImage *)image endedAt:(NSPoint)endPoint operation:(NSDragOperation)operation
     3796IGNORE_WARNINGS_END
    37933797{
    37943798    _impl->draggedImage(image, NSPointToCGPoint(endPoint), operation);
     
    38813885}
    38823886
     3887IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    38833888- (BOOL)accessibilityIsIgnored
     3889IGNORE_WARNINGS_END
    38843890{
    38853891    return _impl->accessibilityIsIgnored();
     
    38913897}
    38923898
     3899IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    38933900- (id)accessibilityAttributeValue:(NSString *)attribute
     3901IGNORE_WARNINGS_END
    38943902{
    38953903    return _impl->accessibilityAttributeValue(attribute);
     
    39613969}
    39623970
     3971IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    39633972- (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination
     3973IGNORE_WARNINGS_END
    39643974{
    39653975    return _impl->namesOfPromisedFilesDroppedAtDestination(dropDestination);
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm

    r236822 r236902  
    503503ALLOW_DEPRECATED_DECLARATIONS_BEGIN
    504504
     505IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    505506- (_WKWebsiteDataStore *)_websiteDataStore
     507IGNORE_WARNINGS_END
    506508{
    507509    return self.websiteDataStore ? adoptNS([[_WKWebsiteDataStore alloc] initWithDataStore:self.websiteDataStore]).autorelease() : nullptr;
    508510}
    509511
     512IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    510513- (void)_setWebsiteDataStore:(_WKWebsiteDataStore *)websiteDataStore
     514IGNORE_WARNINGS_END
    511515{
    512516    self.websiteDataStore = websiteDataStore ? websiteDataStore->_dataStore.get() : nullptr;
  • trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.mm

    r235935 r236902  
    4343ALLOW_DEPRECATED_DECLARATIONS_BEGIN
    4444
     45IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    4546@implementation _WKWebsiteDataStore
     47IGNORE_WARNINGS_END
    4648
    4749- (instancetype)initWithDataStore:(WKWebsiteDataStore *)dataStore
  • trunk/Source/WebKit/UIProcess/API/mac/WKView.mm

    r236665 r236902  
    7171#endif
    7272
     73IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    7374@implementation WKView
     75IGNORE_WARNINGS_END
    7476
    7577#if WK_API_ENABLED
     
    181183}
    182184
     185IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    183186- (void)renewGState
     187IGNORE_WARNINGS_END
    184188{
    185189    _data->_impl->renewGState();
     
    694698
    695699#if ENABLE(DRAG_SUPPORT)
     700IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    696701- (void)draggedImage:(NSImage *)image endedAt:(NSPoint)endPoint operation:(NSDragOperation)operation
     702IGNORE_WARNINGS_END
    697703{
    698704    _data->_impl->draggedImage(image, NSPointToCGPoint(endPoint), operation);
     
    785791}
    786792
     793IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    787794- (BOOL)accessibilityIsIgnored
     795IGNORE_WARNINGS_END
    788796{
    789797    return _data->_impl->accessibilityIsIgnored();
     
    795803}
    796804
     805IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    797806- (id)accessibilityAttributeValue:(NSString *)attribute
     807IGNORE_WARNINGS_END
    798808{
    799809    return _data->_impl->accessibilityAttributeValue(attribute);
     
    865875}
    866876
     877IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    867878- (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination
     879IGNORE_WARNINGS_END
    868880{
    869881    return _data->_impl->namesOfPromisedFilesDroppedAtDestination(dropDestination);
     
    11221134
    11231135ALLOW_DEPRECATED_DECLARATIONS_BEGIN
     1136IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    11241137@implementation WKView (Private)
     1138IGNORE_WARNINGS_END
    11251139
    11261140- (void)saveBackForwardSnapshotForCurrentItem
  • trunk/Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm

    r235935 r236902  
    7474}
    7575
     76IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    7677- (void)popoverControllerDidDismissPopover:(UIPopoverController *)popoverController
     78IGNORE_WARNINGS_END
    7779{
    7880    if (popoverController != _popoverController)
  • trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm

    r235935 r236902  
    466466#pragma mark - UIPopoverControllerDelegate
    467467
     468IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    468469- (void)popoverControllerDidDismissPopover:(UIPopoverController *)popoverController
     470IGNORE_WARNINGS_END
    469471{
    470472    [self _cancel];
     
    487489#pragma mark - UIDocumentPickerControllerDelegate implementation
    488490
     491IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    489492- (void)documentPicker:(UIDocumentPickerViewController *)documentPicker didPickDocumentAtURL:(NSURL *)url
     493IGNORE_WARNINGS_END
    490494{
    491495    [self _dismissDisplayAnimated:YES];
  • trunk/Source/WebKit/UIProcess/ios/forms/WKFormPopover.mm

    r235935 r236902  
    168168}
    169169
     170IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    170171- (void)popoverControllerDidDismissPopover:(UIPopoverController *)popoverController
     172IGNORE_WARNINGS_END
    171173{
    172174    if (_isRotating)
  • trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj

    r236832 r236902  
    99859985                        attributes = {
    99869986                                LastSwiftUpdateCheck = 0700;
    9987                                 LastUpgradeCheck = 0700;
     9987                                LastUpgradeCheck = 1000;
    99889988                                TargetAttributes = {
    99899989                                        E1AC2E2720F7B94C00B0897D = {
  • trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm

    r236066 r236902  
    162162}
    163163
     164IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    164165- (BOOL)accessibilityIsIgnored
     166IGNORE_WARNINGS_END
    165167{
    166168    return NO;
     
    173175}
    174176
     177IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    175178- (id)accessibilityAttributeValue:(NSString *)attribute
     179IGNORE_WARNINGS_END
    176180{
    177181    if ([attribute isEqualToString:NSAccessibilityParentAttribute])
     
    215219}
    216220
     221IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    217222- (id)accessibilityAttributeValue:(NSString *)attribute forParameter:(id)parameter
     223IGNORE_WARNINGS_END
    218224{
    219225    if ([attribute isEqualToString:NSAccessibilityBoundsForRangeParameterizedAttribute]) {
     
    238244}
    239245
     246IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    240247- (NSArray *)accessibilityAttributeNames
     248IGNORE_WARNINGS_END
    241249{
    242250    static NSArray *attributeNames = 0;
     
    270278}
    271279
     280IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    272281- (NSArray *)accessibilityActionNames
     282IGNORE_WARNINGS_END
    273283{
    274284#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
     
    284294}
    285295
     296IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    286297- (void)accessibilityPerformAction:(NSString *)action
     298IGNORE_WARNINGS_END
    287299{
    288300    if ([action isEqualToString:NSAccessibilityShowMenuAction])
     
    290302}
    291303
     304IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    292305- (BOOL)accessibilityIsAttributeSettable:(NSString *)attribute
     306IGNORE_WARNINGS_END
    293307{
    294308    return [_pdfLayerController accessibilityIsAttributeSettable:attribute];
    295309}
    296310
     311IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    297312- (void)accessibilitySetValue:(id)value forAttribute:(NSString *)attribute
     313IGNORE_WARNINGS_END
    298314{
    299315    return [_pdfLayerController accessibilitySetValue:value forAttribute:attribute];
    300316}
    301317
     318IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    302319- (NSArray *)accessibilityParameterizedAttributeNames
     320IGNORE_WARNINGS_END
    303321{
    304322#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
  • trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm

    r235935 r236902  
    6161}
    6262
     63IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    6364- (BOOL)accessibilityIsIgnored
     65IGNORE_WARNINGS_END
    6466{
    6567    return NO;
    6668}
    6769
     70IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    6871- (NSArray *)accessibilityAttributeNames
     72IGNORE_WARNINGS_END
    6973{
    7074    if (!m_attributeNames)
     
    7781}
    7882
     83IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    7984- (NSArray *)accessibilityParameterizedAttributeNames
     85IGNORE_WARNINGS_END
    8086{
    8187    Vector<String> result = m_page->corePage()->pageOverlayController().copyAccessibilityAttributesNames(true);
     
    9096}
    9197
     98IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    9299- (BOOL)accessibilityIsAttributeSettable:(NSString *)attribute
     100IGNORE_WARNINGS_END
    93101{
    94102    return NO;
    95103}
    96104
     105IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    97106- (void)accessibilitySetValue:(id)value forAttribute:(NSString *)attribute
     107IGNORE_WARNINGS_END
    98108{
    99109}
     
    104114}
    105115
     116IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    106117- (NSArray *)accessibilityActionNames
     118IGNORE_WARNINGS_END
    107119{
    108120    return [NSArray array];
     
    118130}
    119131
     132IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    120133- (id)accessibilityAttributeValue:(NSString *)attribute
     134IGNORE_WARNINGS_END
    121135{
    122136    if (!WebCore::AXObjectCache::accessibilityEnabled())
     
    163177}
    164178
     179IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    165180- (id)accessibilityAttributeValue:(NSString *)attribute forParameter:(id)parameter
     181IGNORE_WARNINGS_END
    166182{
    167183    WebCore::FloatPoint pageOverlayPoint;
Note: See TracChangeset for help on using the changeset viewer.