Changeset 236902 in webkit
- Timestamp:
- Oct 6, 2018 6:29:52 PM (5 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 18 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r236886 r236902 1 2018-10-06 Dan Bernstein <mitz@apple.com> 2 3 WebKit part of [Xcode] Update some build settings as recommended by Xcode 10 4 https://bugs.webkit.org/show_bug.cgi?id=190250 5 6 Reviewed by Andy Estes. 7 8 * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, 9 CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and 10 CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED. 11 12 * WebKit.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck. 13 14 * UIProcess/API/Cocoa/WKBrowsingContextController.mm: 15 * UIProcess/API/Cocoa/WKBrowsingContextGroup.mm: 16 * UIProcess/API/Cocoa/WKConnection.mm: 17 * UIProcess/API/Cocoa/WKNavigationData.mm: 18 * UIProcess/API/Cocoa/WKProcessGroup.mm: 19 * UIProcess/API/Cocoa/WKTypeRefWrapper.mm: 20 * UIProcess/API/Cocoa/WKWebView.mm: 21 * UIProcess/API/Cocoa/WKWebViewConfiguration.mm: 22 * UIProcess/API/Cocoa/_WKWebsiteDataStore.mm: 23 * UIProcess/API/mac/WKView.mm: 24 * WebProcess/Plugins/PDF/PDFPlugin.mm: 25 * WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm: 26 27 Suppressed -Wdeprecated-implementations around some class, category and method 28 implementations the above files. 29 1 30 2018-10-05 Alex Christensen <achristensen@webkit.org> 2 31 -
trunk/Source/WebKit/Configurations/Base.xcconfig
r235412 r236902 36 36 CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; 37 37 CLANG_WARN_BOOL_CONVERSION = YES; 38 CLANG_WARN_COMMA = YES; 38 39 CLANG_WARN_CONSTANT_CONVERSION = YES; 39 40 CLANG_WARN_CXX0X_EXTENSIONS = NO; … … 75 76 GCC_WARN_ABOUT_RETURN_TYPE = YES; 76 77 GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES; 78 CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES; 77 79 GCC_WARN_SIGN_COMPARE = YES; 78 80 GCC_WARN_UNDECLARED_SELECTOR = YES; 81 CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; 82 CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES; 79 83 GCC_WARN_UNINITIALIZED_AUTOS = YES; 80 84 GCC_WARN_UNUSED_FUNCTION = YES; -
trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm
r236665 r236902 73 73 NSString * const WKActionCanShowMIMETypeKey = @"WKActionCanShowMIMETypeKey"; 74 74 75 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 75 76 @implementation WKBrowsingContextController { 77 IGNORE_WARNINGS_END 76 78 RefPtr<WebKit::WebPageProxy> _page; 77 79 std::unique_ptr<WebKit::PageLoadStateObserver> _pageLoadStateObserver; … … 619 621 620 622 ALLOW_DEPRECATED_DECLARATIONS_BEGIN 623 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 621 624 @implementation WKBrowsingContextController (Private) 625 IGNORE_WARNINGS_END 622 626 623 627 - (WKPageRef)_pageRef -
trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.mm
r236665 r236902 43 43 #import <wtf/Vector.h> 44 44 45 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 45 46 @implementation WKBrowsingContextGroup { 47 IGNORE_WARNINGS_END 46 48 API::ObjectStorage<WebKit::WebPageGroup> _pageGroup; 47 49 } … … 177 179 178 180 ALLOW_DEPRECATED_DECLARATIONS_BEGIN 181 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 179 182 @implementation WKBrowsingContextGroup (Private) 183 IGNORE_WARNINGS_END 180 184 181 185 - (WKPageGroupRef)_pageGroupRef -
trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm
r236775 r236902 37 37 #import <wtf/text/WTFString.h> 38 38 39 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 39 40 @implementation WKConnection { 41 IGNORE_WARNINGS_END 40 42 WeakObjCPtr<id <WKConnectionDelegate>> _delegate; 41 43 } -
trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.mm
r235828 r236902 33 33 #import <WebCore/ResourceResponse.h> 34 34 35 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 35 36 @implementation WKNavigationData { 37 IGNORE_WARNINGS_END 36 38 API::ObjectStorage<API::NavigationData> _data; 37 39 } -
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.mm
r236665 r236902 53 53 #endif 54 54 55 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 55 56 @implementation WKProcessGroup { 57 IGNORE_WARNINGS_END 56 58 RefPtr<WebKit::WebProcessPool> _processPool; 57 59 … … 221 223 222 224 ALLOW_DEPRECATED_DECLARATIONS_BEGIN 225 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 223 226 @implementation WKProcessGroup (Private) 227 IGNORE_WARNINGS_END 224 228 225 229 - (WKContextRef)_contextRef -
trunk/Source/WebKit/UIProcess/API/Cocoa/WKTypeRefWrapper.mm
r159874 r236902 37 37 @end 38 38 39 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 39 40 @implementation WKTypeRefWrapper 41 IGNORE_WARNINGS_END 40 42 41 43 - (id)initWithObject:(WKTypeRef)object -
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
r236867 r236902 3296 3296 } 3297 3297 3298 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 3298 3299 - (void)renewGState 3300 IGNORE_WARNINGS_END 3299 3301 { 3300 3302 _impl->renewGState(); … … 3790 3792 3791 3793 #if ENABLE(DRAG_SUPPORT) 3794 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 3792 3795 - (void)draggedImage:(NSImage *)image endedAt:(NSPoint)endPoint operation:(NSDragOperation)operation 3796 IGNORE_WARNINGS_END 3793 3797 { 3794 3798 _impl->draggedImage(image, NSPointToCGPoint(endPoint), operation); … … 3881 3885 } 3882 3886 3887 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 3883 3888 - (BOOL)accessibilityIsIgnored 3889 IGNORE_WARNINGS_END 3884 3890 { 3885 3891 return _impl->accessibilityIsIgnored(); … … 3891 3897 } 3892 3898 3899 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 3893 3900 - (id)accessibilityAttributeValue:(NSString *)attribute 3901 IGNORE_WARNINGS_END 3894 3902 { 3895 3903 return _impl->accessibilityAttributeValue(attribute); … … 3961 3969 } 3962 3970 3971 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 3963 3972 - (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination 3973 IGNORE_WARNINGS_END 3964 3974 { 3965 3975 return _impl->namesOfPromisedFilesDroppedAtDestination(dropDestination); -
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
r236822 r236902 503 503 ALLOW_DEPRECATED_DECLARATIONS_BEGIN 504 504 505 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 505 506 - (_WKWebsiteDataStore *)_websiteDataStore 507 IGNORE_WARNINGS_END 506 508 { 507 509 return self.websiteDataStore ? adoptNS([[_WKWebsiteDataStore alloc] initWithDataStore:self.websiteDataStore]).autorelease() : nullptr; 508 510 } 509 511 512 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 510 513 - (void)_setWebsiteDataStore:(_WKWebsiteDataStore *)websiteDataStore 514 IGNORE_WARNINGS_END 511 515 { 512 516 self.websiteDataStore = websiteDataStore ? websiteDataStore->_dataStore.get() : nullptr; -
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.mm
r235935 r236902 43 43 ALLOW_DEPRECATED_DECLARATIONS_BEGIN 44 44 45 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 45 46 @implementation _WKWebsiteDataStore 47 IGNORE_WARNINGS_END 46 48 47 49 - (instancetype)initWithDataStore:(WKWebsiteDataStore *)dataStore -
trunk/Source/WebKit/UIProcess/API/mac/WKView.mm
r236665 r236902 71 71 #endif 72 72 73 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 73 74 @implementation WKView 75 IGNORE_WARNINGS_END 74 76 75 77 #if WK_API_ENABLED … … 181 183 } 182 184 185 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 183 186 - (void)renewGState 187 IGNORE_WARNINGS_END 184 188 { 185 189 _data->_impl->renewGState(); … … 694 698 695 699 #if ENABLE(DRAG_SUPPORT) 700 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 696 701 - (void)draggedImage:(NSImage *)image endedAt:(NSPoint)endPoint operation:(NSDragOperation)operation 702 IGNORE_WARNINGS_END 697 703 { 698 704 _data->_impl->draggedImage(image, NSPointToCGPoint(endPoint), operation); … … 785 791 } 786 792 793 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 787 794 - (BOOL)accessibilityIsIgnored 795 IGNORE_WARNINGS_END 788 796 { 789 797 return _data->_impl->accessibilityIsIgnored(); … … 795 803 } 796 804 805 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 797 806 - (id)accessibilityAttributeValue:(NSString *)attribute 807 IGNORE_WARNINGS_END 798 808 { 799 809 return _data->_impl->accessibilityAttributeValue(attribute); … … 865 875 } 866 876 877 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 867 878 - (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination 879 IGNORE_WARNINGS_END 868 880 { 869 881 return _data->_impl->namesOfPromisedFilesDroppedAtDestination(dropDestination); … … 1122 1134 1123 1135 ALLOW_DEPRECATED_DECLARATIONS_BEGIN 1136 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 1124 1137 @implementation WKView (Private) 1138 IGNORE_WARNINGS_END 1125 1139 1126 1140 - (void)saveBackForwardSnapshotForCurrentItem -
trunk/Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm
r235935 r236902 74 74 } 75 75 76 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 76 77 - (void)popoverControllerDidDismissPopover:(UIPopoverController *)popoverController 78 IGNORE_WARNINGS_END 77 79 { 78 80 if (popoverController != _popoverController) -
trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm
r235935 r236902 466 466 #pragma mark - UIPopoverControllerDelegate 467 467 468 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 468 469 - (void)popoverControllerDidDismissPopover:(UIPopoverController *)popoverController 470 IGNORE_WARNINGS_END 469 471 { 470 472 [self _cancel]; … … 487 489 #pragma mark - UIDocumentPickerControllerDelegate implementation 488 490 491 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 489 492 - (void)documentPicker:(UIDocumentPickerViewController *)documentPicker didPickDocumentAtURL:(NSURL *)url 493 IGNORE_WARNINGS_END 490 494 { 491 495 [self _dismissDisplayAnimated:YES]; -
trunk/Source/WebKit/UIProcess/ios/forms/WKFormPopover.mm
r235935 r236902 168 168 } 169 169 170 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 170 171 - (void)popoverControllerDidDismissPopover:(UIPopoverController *)popoverController 172 IGNORE_WARNINGS_END 171 173 { 172 174 if (_isRotating) -
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
r236832 r236902 9985 9985 attributes = { 9986 9986 LastSwiftUpdateCheck = 0700; 9987 LastUpgradeCheck = 0700;9987 LastUpgradeCheck = 1000; 9988 9988 TargetAttributes = { 9989 9989 E1AC2E2720F7B94C00B0897D = { -
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
r236066 r236902 162 162 } 163 163 164 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 164 165 - (BOOL)accessibilityIsIgnored 166 IGNORE_WARNINGS_END 165 167 { 166 168 return NO; … … 173 175 } 174 176 177 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 175 178 - (id)accessibilityAttributeValue:(NSString *)attribute 179 IGNORE_WARNINGS_END 176 180 { 177 181 if ([attribute isEqualToString:NSAccessibilityParentAttribute]) … … 215 219 } 216 220 221 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 217 222 - (id)accessibilityAttributeValue:(NSString *)attribute forParameter:(id)parameter 223 IGNORE_WARNINGS_END 218 224 { 219 225 if ([attribute isEqualToString:NSAccessibilityBoundsForRangeParameterizedAttribute]) { … … 238 244 } 239 245 246 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 240 247 - (NSArray *)accessibilityAttributeNames 248 IGNORE_WARNINGS_END 241 249 { 242 250 static NSArray *attributeNames = 0; … … 270 278 } 271 279 280 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 272 281 - (NSArray *)accessibilityActionNames 282 IGNORE_WARNINGS_END 273 283 { 274 284 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 … … 284 294 } 285 295 296 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 286 297 - (void)accessibilityPerformAction:(NSString *)action 298 IGNORE_WARNINGS_END 287 299 { 288 300 if ([action isEqualToString:NSAccessibilityShowMenuAction]) … … 290 302 } 291 303 304 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 292 305 - (BOOL)accessibilityIsAttributeSettable:(NSString *)attribute 306 IGNORE_WARNINGS_END 293 307 { 294 308 return [_pdfLayerController accessibilityIsAttributeSettable:attribute]; 295 309 } 296 310 311 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 297 312 - (void)accessibilitySetValue:(id)value forAttribute:(NSString *)attribute 313 IGNORE_WARNINGS_END 298 314 { 299 315 return [_pdfLayerController accessibilitySetValue:value forAttribute:attribute]; 300 316 } 301 317 318 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 302 319 - (NSArray *)accessibilityParameterizedAttributeNames 320 IGNORE_WARNINGS_END 303 321 { 304 322 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 -
trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm
r235935 r236902 61 61 } 62 62 63 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 63 64 - (BOOL)accessibilityIsIgnored 65 IGNORE_WARNINGS_END 64 66 { 65 67 return NO; 66 68 } 67 69 70 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 68 71 - (NSArray *)accessibilityAttributeNames 72 IGNORE_WARNINGS_END 69 73 { 70 74 if (!m_attributeNames) … … 77 81 } 78 82 83 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 79 84 - (NSArray *)accessibilityParameterizedAttributeNames 85 IGNORE_WARNINGS_END 80 86 { 81 87 Vector<String> result = m_page->corePage()->pageOverlayController().copyAccessibilityAttributesNames(true); … … 90 96 } 91 97 98 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 92 99 - (BOOL)accessibilityIsAttributeSettable:(NSString *)attribute 100 IGNORE_WARNINGS_END 93 101 { 94 102 return NO; 95 103 } 96 104 105 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 97 106 - (void)accessibilitySetValue:(id)value forAttribute:(NSString *)attribute 107 IGNORE_WARNINGS_END 98 108 { 99 109 } … … 104 114 } 105 115 116 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 106 117 - (NSArray *)accessibilityActionNames 118 IGNORE_WARNINGS_END 107 119 { 108 120 return [NSArray array]; … … 118 130 } 119 131 132 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 120 133 - (id)accessibilityAttributeValue:(NSString *)attribute 134 IGNORE_WARNINGS_END 121 135 { 122 136 if (!WebCore::AXObjectCache::accessibilityEnabled()) … … 163 177 } 164 178 179 IGNORE_WARNINGS_BEGIN("deprecated-implementations") 165 180 - (id)accessibilityAttributeValue:(NSString *)attribute forParameter:(id)parameter 181 IGNORE_WARNINGS_END 166 182 { 167 183 WebCore::FloatPoint pageOverlayPoint;
Note: See TracChangeset
for help on using the changeset viewer.