Changeset 236913 in webkit


Ignore:
Timestamp:
Oct 8, 2018 6:55:14 AM (6 years ago)
Author:
mitz@apple.com
Message:

Source/ThirdParty:
gtest part of [Xcode] Update some build settings as recommended by Xcode 10
​https://bugs.webkit.org/show_bug.cgi?id=190250

Reviewed by Anders Carlsson.

Didn’t turn on any of the warnings Xcode recommended for this third-party test support
library.

  • gtest/xcode/Config/DebugProject.xcconfig: Set the deployment target in engineering builds like we do in other projects. This addresses a build-time warning when building clients of the library that its deployment target doesn’t match theirs.
  • gtest/xcode/Config/ReleaseProject.xcconfig: Ditto.
  • gtest/xcode/gtest.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.

Tools:
Tools part of [Xcode] Update some build settings as recommended by Xcode 10
​https://bugs.webkit.org/show_bug.cgi?id=190250

Reviewed by Anders Carlsson.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
  • DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
  • DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
  • DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning around deprecated methods or categories on deprecated classes.
  • DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.

(-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):

  • DumpRenderTree/mac/TestRunnerMac.mm: Ditto.

(-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):

  • MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
  • MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
  • MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
  • MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo), CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
  • MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
  • TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED. Made the WebKit headers be treated as system headers to avoid dealing with the fact that many C SPI headers trigger the strict prototypes warning.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
(-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
(-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
(-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):

  • TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):

  • TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:

(-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):

  • TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:

(-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
(-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):

  • TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:

(-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
(-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
(-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):

  • TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:

(-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):

  • TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:

(-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):

  • TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:

(-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
(-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.

  • TestWebKitAPI/mac/TestDraggingInfo.mm:

(-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):

In all of the above, suppressed the deprecated implementations warning where needed.

  • WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION, CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION, CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARNDUPLICATE_METHOD_MATCH, GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and GCC_NO_COMMON_BLOCKS.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed

the deprecated implementations warning.

  • WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.

Location:
trunk
Files:
32 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/ThirdParty/ChangeLog

    r235718 r236913  
     12018-10-08  Dan Bernstein  <mitz@apple.com>
     2
     3        gtest part of [Xcode] Update some build settings as recommended by Xcode 10
     4        https://bugs.webkit.org/show_bug.cgi?id=190250
     5
     6        Reviewed by Anders Carlsson.
     7
     8        Didn’t turn on any of the warnings Xcode recommended for this third-party test support
     9        library.
     10
     11        * gtest/xcode/Config/DebugProject.xcconfig: Set the deployment target in engineering builds
     12          like we do in other projects. This addresses a build-time warning when building clients
     13          of the library that its deployment target doesn’t match theirs.
     14        * gtest/xcode/Config/ReleaseProject.xcconfig: Ditto.
     15
     16        * gtest/xcode/gtest.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
     17
    1182018-09-05  Don Olmstead  <don.olmstead@sony.com>
    219

  • trunk/Source/ThirdParty/gtest/xcode/Config/DebugProject.xcconfig

    r235613 r236913  
    1616// Deployment postprocessing is what triggers Xcode to strip, turn it off
    1717DEPLOYMENT_POSTPROCESSING = NO
     18
     19MACOSX_DEPLOYMENT_TARGET = $(MACOSX_DEPLOYMENT_TARGET_$(TARGET_MAC_OS_X_VERSION_MAJOR));
     20MACOSX_DEPLOYMENT_TARGET_101200 = 10.12;
     21MACOSX_DEPLOYMENT_TARGET_101300 = 10.13;
     22MACOSX_DEPLOYMENT_TARGET_101400 = 10.14;
     23MACOSX_DEPLOYMENT_TARGET_101500 = 10.15;
    1824
    1925// Dead code stripping off

  • trunk/Source/ThirdParty/gtest/xcode/Config/ReleaseProject.xcconfig

    r235613 r236913  
    1919DEPLOYMENT_POSTPROCESSING = YES
    2020
     21MACOSX_DEPLOYMENT_TARGET = $(MACOSX_DEPLOYMENT_TARGET_$(TARGET_MAC_OS_X_VERSION_MAJOR));
     22MACOSX_DEPLOYMENT_TARGET_101200 = 10.12;
     23MACOSX_DEPLOYMENT_TARGET_101300 = 10.13;
     24MACOSX_DEPLOYMENT_TARGET_101400 = 10.14;
     25MACOSX_DEPLOYMENT_TARGET_101500 = 10.15;
     26
    2127// No symbols
    2228GCC_GENERATE_DEBUGGING_SYMBOLS = NO
    … …  
    3743SDKROOT_ = macosx;
    3844SDKROOT_YES = macosx.internal;
     45
     46MACOSX_DEPLOYMENT_TARGET = $(MACOSX_DEPLOYMENT_TARGET_$(TARGET_MAC_OS_X_VERSION_MAJOR));
     47MACOSX_DEPLOYMENT_TARGET_101200 = 10.12;
     48MACOSX_DEPLOYMENT_TARGET_101300 = 10.13;
     49MACOSX_DEPLOYMENT_TARGET_101400 = 10.14;
     50MACOSX_DEPLOYMENT_TARGET_101500 = 10.15;

  • trunk/Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj

    r235613 r236913  
    626626                        attributes = {
    627627                                LastSwiftUpdateCheck = 0700;
    628                                 LastUpgradeCheck = 0600;
     628                                LastUpgradeCheck = 1000;
    629629                        };
    630630                        buildConfigurationList = 4FADC24608B4156D00ABE55E /* Build configuration list for PBXProject "gtest" */;

  • trunk/Tools/ChangeLog

    r236911 r236913  
     12018-10-08  Dan Bernstein  <mitz@apple.com>
     2
     3        Tools part of [Xcode] Update some build settings as recommended by Xcode 10
     4        https://bugs.webkit.org/show_bug.cgi?id=190250
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
     9
     10        * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
     11          CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
     12          CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
     13
     14        * DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
     15
     16        * DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning
     17          around deprecated methods or categories on deprecated classes.
     18        * DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.
     19        (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
     20        * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
     21        (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
     22
     23        * MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
     24          CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
     25          CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
     26
     27        * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
     28
     29        * MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
     30        * MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to
     31          address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
     32
     33        * MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
     34          CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo),
     35          CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
     36
     37        * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update
     38          LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
     39
     40        * TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
     41          CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
     42          CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
     43          Made the WebKit headers be treated as system headers to avoid dealing with the fact that
     44          many C SPI headers trigger the strict prototypes warning.
     45
     46        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
     47
     48        * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
     49        (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
     50        (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
     51        (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
     52        (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
     53        * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
     54        (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
     55        (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
     56        * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
     57        (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
     58        * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
     59        (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
     60        (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
     61        * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
     62        (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
     63        (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
     64        (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
     65        * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
     66        (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
     67        * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
     68        (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
     69        * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
     70        (-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
     71        (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.
     72        * TestWebKitAPI/mac/TestDraggingInfo.mm:
     73        (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
     74
     75        In all of the above, suppressed the deprecated implementations warning where needed.
     76
     77        * WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND,
     78          CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION,
     79          CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
     80          CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH,
     81          GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
     82          CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
     83          and GCC_NO_COMMON_BLOCKS.
     84
     85        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
     86
     87        * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
     88        (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed
     89          the deprecated implementations warning.
     90
     91        * WebKitTestRunner/mac/UIScriptControllerMac.mm:
     92        (WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.
     93
    1942018-10-07  Yacine Bandou  <yacine.bandou@softathome.com>
    295

  • trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

    r235439 r236913  
    953953                        attributes = {
    954954                                LastSwiftUpdateCheck = 0700;
    955                                 LastUpgradeCheck = 0700;
     955                                LastUpgradeCheck = 1000;
    956956                        };
    957957                        buildConfigurationList = 149C29C308902C6D008A9EFC /* Build configuration list for PBXProject "DumpRenderTree" */;

  • trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig

    r232665 r236913  
    5959CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
    6060CLANG_WARN_BOOL_CONVERSION = YES;
     61CLANG_WARN_COMMA = YES;
    6162CLANG_WARN_CONSTANT_CONVERSION = YES;
    6263CLANG_WARN_EMPTY_BODY = YES;
    … …  
    6566CLANG_WARN_INT_CONVERSION = YES;
    6667CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
     68CLANG_WARN_STRICT_PROTOTYPES = YES;
    6769CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
    6870CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
    6971CLANG_WARN_SUSPICIOUS_MOVE = YES;
     72CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
    7073CLANG_WARN_UNREACHABLE_CODE = YES;
    7174GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
    … …  
    7780CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
    7881GCC_WARN_UNDECLARED_SELECTOR = YES;
     82CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
     83CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
    7984// FIXME: <http://webkit.org/b/118590> DumpRenderTree should build with -Wshorten-64-to-32
    8085GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64*] = NO;

  • trunk/Tools/DumpRenderTree/mac/DumpRenderTreeMac.h

    r211662 r236913  
    5858
    5959void setWaitToDumpWatchdog(CFRunLoopTimerRef);
    60 bool shouldSetWaitToDumpWatchdog();
     60bool shouldSetWaitToDumpWatchdog(void);
    6161
    6262#ifdef __OBJC__
    63 WebView *createWebViewAndOffscreenWindow() NS_RETURNS_RETAINED;
     63WebView *createWebViewAndOffscreenWindow(void) NS_RETURNS_RETAINED;
    6464#endif
    6565

  • trunk/Tools/DumpRenderTree/mac/EditingDelegate.mm

    r175647 r236913  
    3838@end
    3939
     40IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    4041@implementation DOMNode (dumpPath)
     42IGNORE_WARNINGS_END
    4143- (NSString *)dumpPath
    4244{
    … …  
    5557@end
    5658
     59IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    5760@implementation DOMRange (dump)
     61IGNORE_WARNINGS_END
    5862- (NSString *)dump
    5963{

  • trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm

    r236032 r236913  
    8686@end
    8787
     88IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    8889@implementation WebFrame (DRTExtras)
     90IGNORE_WARNINGS_END
    8991- (NSString *)_drt_descriptionSuitableForTestResult
    9092{
    … …  
    276278}
    277279
     280IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    278281- (void)webView:(WebView *)webView windowScriptObjectAvailable:(WebScriptObject *)windowScriptObject
     282IGNORE_WARNINGS_END
    279283{
    280284    if (!done && gTestRunner->dumpFrameLoadCallbacks()) {

  • trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm

    r236032 r236913  
    10821082}
    10831083
     1084IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    10841085- (void)connection:(NSURLConnection *)connection didReceiveAuthenticationChallenge:(NSURLAuthenticationChallenge *)challenge
     1086IGNORE_WARNINGS_END
    10851087{
    10861088    if ([challenge previousFailureCount] == 0) {

  • trunk/Tools/MiniBrowser/Configurations/Base.xcconfig

    r232665 r236913  
    4343CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
    4444CLANG_WARN_BOOL_CONVERSION = YES;
     45CLANG_WARN_COMMA = YES;
    4546CLANG_WARN_CONSTANT_CONVERSION = YES;
    4647CLANG_WARN_EMPTY_BODY = YES;
    … …  
    4950CLANG_WARN_INT_CONVERSION = YES;
    5051CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
     52CLANG_WARN_STRICT_PROTOTYPES = YES;
    5153CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
    5254CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
    5355CLANG_WARN_SUSPICIOUS_MOVE = YES;
     56CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
    5457CLANG_WARN_UNREACHABLE_CODE = YES;
    5558GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
    … …  
    6164CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
    6265GCC_WARN_UNDECLARED_SELECTOR = YES;
     66CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
     67CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
    6368GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
    6469WARNING_CFLAGS = -Wall -W -Wno-unused-parameter

  • trunk/Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj

    r235665 r236913  
    251251                        attributes = {
    252252                                LastSwiftUpdateCheck = 0700;
    253                                 LastUpgradeCheck = 0700;
     253                                LastUpgradeCheck = 1000;
    254254                                TargetAttributes = {
    255255                                        8D1107260486CEB800E47090 = {

  • trunk/Tools/MiniBrowser/mac/AppDelegate.h

    r210483 r236913  
    4949
    5050#if WK_API_ENABLED
    51 WKPreferences *defaultPreferences();
     51WKPreferences *defaultPreferences(void);
    5252#endif

  • trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m

    r236548 r236913  
    3434#import <WebKit/WKNavigationActionPrivate.h>
    3535#import <WebKit/WKNavigationDelegate.h>
    36 #import <WebKit/WKPage.h>
    3736#import <WebKit/WKPreferencesPrivate.h>
    3837#import <WebKit/WKUIDelegate.h>

  • trunk/Tools/MobileMiniBrowser/Configurations/Base.xcconfig

    r232069 r236913  
    3636CLANG_ENABLE_OBJC_ARC = YES;
    3737CLANG_WARN_BOOL_CONVERSION = YES;
     38CLANG_WARN_COMMA = YES;
    3839CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
    3940CLANG_WARN_CONSTANT_CONVERSION = YES;
    … …  
    4647CLANG_WARN_INT_CONVERSION = YES;
    4748CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
     49CLANG_WARN_STRICT_PROTOTYPES = YES;
    4850CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
    4951CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
    5052CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
    51 CLANG_WARN_SUSPICIOUS_MOVES = YES;
     53CLANG_WARN_SUSPICIOUS_MOVE = YES;
     54CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
    5255CLANG_WARN_UNREACHABLE_CODE = YES;
    5356CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
    … …  
    6871GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
    6972GCC_WARN_UNDECLARED_SELECTOR = YES;
     73CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
    7074GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
    7175GCC_WARN_UNUSED_FUNCTION = YES

  • trunk/Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj

    r235541 r236913  
    2626                CD498B521D763D8800681FA7 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = CD1DAFA11D709E3600017CF0 /* Assets.xcassets */; };
    2727                CD498B531D763D9300681FA7 /* Info.plist in Resources */ = {isa = PBXBuildFile; fileRef = CD498B471D7634C700681FA7 /* Info.plist */; };
    28                 CD4DEEE51D78C6FF00625986 /* Base.xcconfig in Resources */ = {isa = PBXBuildFile; fileRef = CD4DEEE21D78C6FF00625986 /* Base.xcconfig */; };
    29                 CD4DEEE61D78C6FF00625986 /* DebugRelease.xcconfig in Resources */ = {isa = PBXBuildFile; fileRef = CD4DEEE31D78C6FF00625986 /* DebugRelease.xcconfig */; };
    30                 CD4DEEE71D78C6FF00625986 /* MobileMiniBrowser.xcconfig in Resources */ = {isa = PBXBuildFile; fileRef = CD4DEEE41D78C6FF00625986 /* MobileMiniBrowser.xcconfig */; };
    3128                CDA985191D76483400EBC399 /* test.mp4 in Resources */ = {isa = PBXBuildFile; fileRef = CDA985151D76477900EBC399 /* test.mp4 */; };
    3229                CDA9851A1D76483400EBC399 /* index.html in Resources */ = {isa = PBXBuildFile; fileRef = CDA985131D76474100EBC399 /* index.html */; };
    … …  
    291288                        isa = PBXProject;
    292289                        attributes = {
    293                                 LastUpgradeCheck = 0800;
     290                                LastUpgradeCheck = 1000;
    294291                                ORGANIZATIONNAME = WebKit;
    295292                                TargetAttributes = {
    … …  
    332329                        buildActionMask = 2147483647;
    333330                        files = (
    334                                 CD4DEEE51D78C6FF00625986 /* Base.xcconfig in Resources */,
    335                                 CD4DEEE61D78C6FF00625986 /* DebugRelease.xcconfig in Resources */,
    336331                                CD1DAFA51D709E3600017CF0 /* LaunchScreen.storyboard in Resources */,
    337                                 CD4DEEE71D78C6FF00625986 /* MobileMiniBrowser.xcconfig in Resources */,
    338332                        );
    339333                        runOnlyForDeploymentPostprocessing = 0;

  • trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig

    r235613 r236913  
    4949CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
    5050CLANG_WARN_BOOL_CONVERSION = YES;
     51CLANG_WARN_COMMA = YES;
    5152CLANG_WARN_CONSTANT_CONVERSION = YES;
    5253CLANG_WARN_EMPTY_BODY = YES;
    … …  
    5556CLANG_WARN_INT_CONVERSION = YES;
    5657CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
     58CLANG_WARN_STRICT_PROTOTYPES = YES;
    5759CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
    5860CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
    5961CLANG_WARN_SUSPICIOUS_MOVE = YES;
     62CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
    6063CLANG_WARN_UNREACHABLE_CODE = YES;
    6164GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO
    … …  
    6669CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
    6770GCC_WARN_UNDECLARED_SELECTOR = YES;
     71CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
     72CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
    6873GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64*] = NO;
    6974GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
    … …  
    96101EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = *Mac.h *Mac.cpp *Mac.mm */mac/*;
    97102
    98 OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS);
     103OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS) --system-header-prefix=WebKit/;
    99104OTHER_CFLAGS[sdk=macosx*] = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Carbon.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
    100105OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);

  • trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

    r236875 r236913  
    35433543                        attributes = {
    35443544                                LastSwiftUpdateCheck = 0700;
    3545                                 LastUpgradeCheck = 0700;
     3545                                LastUpgradeCheck = 1000;
    35463546                                TargetAttributes = {
    35473547                                        7C83E02B1D0A5E1000FEBCF3 = {

  • trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm

    r224371 r236913  
    8888}
    8989
     90IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    9091- (NSString *)_download:(_WKDownload *)download decideDestinationWithSuggestedFilename:(NSString *)filename allowOverwrite:(BOOL *)allowOverwrite
     92IGNORE_WARNINGS_END
    9193{
    9294    EXPECT_TRUE(hasReceivedResponse);
    … …  
    389391}
    390392
     393IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    391394- (NSString *)_download:(_WKDownload *)download decideDestinationWithSuggestedFilename:(NSString *)filename allowOverwrite:(BOOL *)allowOverwrite
     395IGNORE_WARNINGS_END
    392396{
    393397    EXPECT_TRUE(hasReceivedResponse);
    … …  
    441445@implementation UIDownloadAsFileTestDelegate
    442446
     447IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    443448- (NSMenu *)_webView:(WKWebView *)webView contextMenu:(NSMenu *)menu forElement:(_WKContextMenuElementInfo *)element
     449IGNORE_WARNINGS_END
    444450{
    445451    static const long downloadLinkedFileTag = 2;
    … …  
    465471}
    466472
     473IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    467474- (NSString *)_download:(_WKDownload *)download decideDestinationWithSuggestedFilename:(NSString *)filename allowOverwrite:(BOOL *)allowOverwrite
     475IGNORE_WARNINGS_END
    468476{
    469477    WebCore::FileSystem::PlatformFileHandle fileHandle;

  • trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm

    r234705 r236913  
    779779@implementation CustomHeaderFieldsDelegate
    780780
     781IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    781782- (void)_webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigationAction *)navigationAction decisionHandler:(void (^)(WKNavigationActionPolicy, _WKWebsitePolicies *))decisionHandler
     783IGNORE_WARNINGS_END
    782784{
    783785    _WKWebsitePolicies *websitePolicies = [[[_WKWebsitePolicies alloc] init] autorelease];
    … …  
    920922@implementation WebsitePoliciesWebsiteDataStoreDelegate
    921923
     924IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    922925- (void)_webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigationAction *)navigationAction decisionHandler:(void (^)(WKNavigationActionPolicy, _WKWebsitePolicies *))decisionHandler
     926IGNORE_WARNINGS_END
    923927{
    924928    NSURL *url = navigationAction.request.URL;

  • trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm

    r234547 r236913  
    4747
    4848@implementation AudioSessionCategoryUIWebViewDelegate
     49IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    4950- (BOOL)webView:(UIWebView *)webView shouldStartLoadWithRequest:(NSURLRequest *)request navigationType:(UIWebViewNavigationType)navigationType
     51IGNORE_WARNINGS_END
    5052{
    5153    if ([request.URL.scheme isEqualToString:@"callback"] && [request.URL.resourceSpecifier isEqualToString:@"playing"]) {

  • trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm

    r221505 r236913  
    4141@implementation RenderInContextWebViewDelegate
    4242
     43IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    4344- (void)webViewDidFinishLoad:(UIWebView *)webView
     45IGNORE_WARNINGS_END
    4446{
    4547    loadComplete = true;
    4648}
    4749
     50IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    4851- (void)webView:(UIWebView *)webView didFailLoadWithError:(NSError *)error
     52IGNORE_WARNINGS_END
    4953{
    5054    loadComplete = true;

  • trunk/Tools/TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm

    r231776 r236913  
    4242@implementation SetTimeoutFunctionWebViewDelegate
    4343
     44IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    4445- (void)webViewDidFinishLoad:(UIWebView *)webView
     46IGNORE_WARNINGS_END
    4547{
    4648    loadComplete = true;
    4749}
    4850
     51IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    4952- (void)webView:(UIWebView *)webView didFailLoadWithError:(NSError *)error
     53IGNORE_WARNINGS_END
    5054{
    5155    loadComplete = true;
    … …  
    5357}
    5458
     59IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    5560- (BOOL)webView:(UIWebView *)webView shouldStartLoadWithRequest:(NSURLRequest *)request navigationType:(UIWebViewNavigationType)navigationType
     61IGNORE_WARNINGS_END
    5662{
    5763    NSString *prefix = @"fired-";

  • trunk/Tools/TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm

    r234816 r236913  
    156156}
    157157
     158IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    158159- (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination
     160IGNORE_WARNINGS_END
    159161{
    160162    return nil;

  • trunk/Tools/TestWebKitAPI/mac/DragAndDropSimulatorMac.mm

    r235392 r236913  
    5757}
    5858
     59IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    5960- (void)dragImage:(NSImage *)image at:(NSPoint)viewLocation offset:(NSSize)initialOffset event:(NSEvent *)event pasteboard:(NSPasteboard *)pboard source:(id)sourceObj slideBack:(BOOL)slideFlag
     61IGNORE_WARNINGS_END
    6062{
    6163    [_dragAndDropSimulator performDragInWebView:self atLocation:viewLocation withImage:image pasteboard:pboard source:sourceObj];

  • trunk/Tools/TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m

    r196982 r236913  
    5252}
    5353
     54IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    5455- (CGFloat)userSpaceScaleFactor
     56IGNORE_WARNINGS_END
    5557{
    5658    return _backingScaleFactor;

  • trunk/Tools/TestWebKitAPI/mac/TestDraggingInfo.mm

    r234976 r236913  
    151151}
    152152
     153IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    153154- (NSArray<NSString *> *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination
     155IGNORE_WARNINGS_END
    154156{
    155157    return @[ ];

  • trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig

    r235837 r236913  
    3232CLANG_CXX_LIBRARY = libc++;
    3333CLANG_ENABLE_OBJC_WEAK = YES;
     34ENABLE_STRICT_OBJC_MSGSEND = YES;
    3435CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
     36CLANG_WARN_BOOL_CONVERSION = YES;
     37CLANG_WARN_COMMA = YES;
     38CLANG_WARN_CONSTANT_CONVERSION = YES;
     39CLANG_WARN_EMPTY_BODY = YES;
     40CLANG_WARN_ENUM_CONVERSION = YES;
    3541CLANG_WARN_CXX0X_EXTENSIONS = NO;
    3642CLANG_WARN_INFINITE_RECURSION = YES;
     43CLANG_WARN_INT_CONVERSION = YES;
    3744CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
     45CLANG_WARN_STRICT_PROTOTYPES = YES;
     46CLANG_WARN_UNREACHABLE_CODE = YES;
    3847CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
     48CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
     49GCC_WARN_UNDECLARED_SELECTOR = YES;
     50CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
     51CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
    3952CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
    4053CLANG_WARN_SUSPICIOUS_MOVE = YES;
     54CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
    4155HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport $(WEBCORE_PRIVATE_HEADERS_DIR)/ForwardingHeaders $(NEXT_ROOT)/usr/local/include/WebCoreTestSupport;
     56GCC_NO_COMMON_BLOCKS = YES;
    4257GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) U_DISABLE_RENAMING=1 U_SHOW_CPLUSPLUS_API=0 ENABLE_DASHBOARD_SUPPORT;
    4358DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
    … …  
    5065GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
    5166GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO
     67GCC_WARN_ABOUT_RETURN_TYPE = YES;
     68GCC_WARN_UNINITIALIZED_AUTOS = YES;
    5269GCC_WARN_UNUSED_FUNCTION = YES
    5370GCC_WARN_UNUSED_VARIABLE = YES

  • trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj

    r236481 r236913  
    942942                        attributes = {
    943943                                LastSwiftUpdateCheck = 0700;
     944                                LastUpgradeCheck = 1000;
    944945                                TargetAttributes = {
    945946                                        A115CCB41B9D769D00E89159 = {

  • trunk/Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm

    r235837 r236913  
    6262
    6363#if PLATFORM(MAC)
     64IGNORE_WARNINGS_BEGIN("deprecated-implementations")
    6465- (void)dragImage:(NSImage *)anImage at:(NSPoint)viewLocation offset:(NSSize)initialOffset event:(NSEvent *)event pasteboard:(NSPasteboard *)pboard source:(id)sourceObj slideBack:(BOOL)slideFlag
     66IGNORE_WARNINGS_END
    6567{
    6668    RetainPtr<WebKitTestRunnerDraggingInfo> draggingInfo = adoptNS([[WebKitTestRunnerDraggingInfo alloc] initWithImage:anImage offset:initialOffset pasteboard:pboard source:sourceObj]);

  • trunk/Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm

    r233866 r236913  
    7979{
    8080#if WK_API_ENABLED
    81     if (location == -1)
    82         location = NSNotFound;
    83 
    84     auto* webView = TestController::singleton().mainWebView()->platformView();
    85     [webView _insertText:nsString(text) replacementRange:NSMakeRange(location, length)];
     81    auto* webView = TestController::singleton().mainWebView()->platformView();
     82    [webView _insertText:nsString(text) replacementRange:NSMakeRange(location == -1 ? NSNotFound : location, length)];
    8683#else
    8784    UNUSED_PARAM(text);
Note: See TracChangeset for help on using the changeset viewer.