Changeset 236972 in webkit

Timestamp:

Oct 9, 2018 12:04:18 PM (6 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION: fix canvas test failures after r236952 and r236954
​https://bugs.webkit.org/show_bug.cgi?id=190403

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

• UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype._removeCanvas):
Clear the shaderProgramCollection when a WI.Canvas is removed so that a remove event is
fired for each WI.ShaderProgram.

LayoutTests:

• inspector/canvas/create-context-webmetal.html:

Fix missing parenthesis.

• inspector/canvas/resources/shaderProgram-utilities.js:

(createProgram):
(TestPage.registerInitializer.awaitProgramAdded):
(TestPage.registerInitializer):
(TestPage.registerInitializer.window.initializeTestSuite):
Replace the WI.CanvasManager events (which were removed) with listeners for events on the
specific WI.Canvas.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/canvas/create-context-webmetal.html (modified) (1 diff)
• LayoutTests/inspector/canvas/resources/shaderProgram-utilities.js (modified) (4 diffs)
• Source/WebInspectorUI/ChangeLog (modified) (1 diff)
• Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-10-09  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION: fix canvas test failures after r236952 and r236954
+        https://bugs.webkit.org/show_bug.cgi?id=190403
+
+        Reviewed by Joseph Pecoraro.
+
+        * inspector/canvas/create-context-webmetal.html:
+        Fix missing parenthesis.
+
+        * inspector/canvas/resources/shaderProgram-utilities.js:
+        (createProgram):
+        (TestPage.registerInitializer.awaitProgramAdded):
+        (TestPage.registerInitializer):
+        (TestPage.registerInitializer.window.initializeTestSuite):
+        Replace the `WI.CanvasManager` events (which were removed) with listeners for events on the
+        specific `WI.Canvas`.
+
 2018-10-09  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/inspector/canvas/create-context-webmetal.html

@@ -24 +24 @@
     });
 
-    addCSSCanvasTestCase(WI.Canvas.ContextType.WebMetal;
+    addCSSCanvasTestCase(WI.Canvas.ContextType.WebMetal);
 
     suite.runTestCasesAndFinish();

trunk/LayoutTests/inspector/canvas/resources/shaderProgram-utilities.js

@@ -3 +3 @@
 
 function createProgram(contextType) {
-    context = document.createElement("canvas").getContext(contextType);
+    if (!context)
+        context = document.createElement("canvas").getContext(contextType);
+
     program = context.createProgram();
 }
@@ -46 +48 @@
 
     function awaitProgramAdded() {
-        return WI.canvasManager.awaitEvent(WI.CanvasManager.Event.ShaderProgramAdded)
+        InspectorTest.assert(WI.canvasManager.canvases.length === 1, "There should only be one canvas.");
+        return WI.canvasManager.canvases[0].shaderProgramCollection.awaitEvent(WI.Collection.Event.ItemAdded)
         .then((event) => {
-            let program = event.data.program;
+            let program = event.data.item;
             InspectorTest.expectThat(program instanceof WI.ShaderProgram, "Added ShaderProgram.");
             InspectorTest.expectThat(program.canvas instanceof WI.Canvas, "ShaderProgram should have a parent Canvas.");
@@ -56 +59 @@
 
     function awaitProgramRemoved() {
-        return WI.canvasManager.awaitEvent(WI.CanvasManager.Event.ShaderProgramRemoved)
+        InspectorTest.assert(WI.canvasManager.canvases.length === 1, "There should only be one canvas.");
+        return WI.canvasManager.canvases[0].shaderProgramCollection.awaitEvent(WI.Collection.Event.ItemRemoved)
         .then((event) => {
-            let program = event.data.program;
+            let program = event.data.item;
             InspectorTest.expectThat(program instanceof WI.ShaderProgram, "Removed ShaderProgram.");
             InspectorTest.expectThat(program.canvas instanceof WI.Canvas, "ShaderProgram should have a parent Canvas.");
@@ -72 +76 @@
             description: "Check that ShaderProgramAdded is sent for a program created before CanvasAgent is enabled.",
             test(resolve, reject) {
-                awaitProgramAdded().then(resolve, reject);
+                // This can't use `awaitEvent` since the promise resolution happens on the next tick.
+                WI.canvasManager.singleFireEventListener(WI.CanvasManager.Event.CanvasAdded, (event) => {
+                    awaitProgramAdded().then(resolve, reject);
+                });
 
                 InspectorTest.reloadPage();

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-10-09  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION: fix canvas test failures after r236952 and r236954
+        https://bugs.webkit.org/show_bug.cgi?id=190403
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Controllers/CanvasManager.js:
+        (WI.CanvasManager.prototype._removeCanvas):
+        Clear the `shaderProgramCollection` when a `WI.Canvas` is removed so that a remove event is
+        fired for each `WI.ShaderProgram`.
+
 2018-10-08  Justin Fan  <justin_fan@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js

@@ -200 +200 @@
             this._shaderProgramIdentifierMap.delete(program.identifier);
 
+        canvas.shaderProgramCollection.clear();
+
         for (let recording of canvas.recordingCollection) {
             recording.source = null;