Changeset 237007 in webkit
- Timestamp:
- Oct 10, 2018 11:20:08 AM (5 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r237002 r237007 1 2018-10-10 Daniel Bates <dabates@apple.com> 2 3 [iOS] Compare input string to UIKeyInput constants using string comparison instead of pointer comparison 4 https://bugs.webkit.org/show_bug.cgi?id=190432 5 6 Reviewed by Tim Horton. 7 8 Pointer comparision is brittle. We should be more forgiving and perform string comparision 9 of an input string to a UIKeyInput constant. 10 11 * platform/ios/WebEvent.mm: 12 (normalizedStringWithAppKitCompatibilityMapping): 13 1 14 2018-10-10 Chris Dumez <cdumez@apple.com> 2 15 -
trunk/Source/WebCore/platform/ios/WebEvent.mm
r236982 r237007 147 147 auto makeNSStringWithCharacter = [] (unichar c) { return [NSString stringWithCharacters:&c length:1]; }; 148 148 149 if ( characters == UIKeyInputUpArrow)149 if ([characters isEqualToString:UIKeyInputUpArrow]) 150 150 return makeNSStringWithCharacter(NSUpArrowFunctionKey); 151 if ( characters == UIKeyInputDownArrow)151 if ([characters isEqualToString:UIKeyInputDownArrow]) 152 152 return makeNSStringWithCharacter(NSDownArrowFunctionKey); 153 if ( characters == UIKeyInputLeftArrow)153 if ([characters isEqualToString:UIKeyInputLeftArrow]) 154 154 return makeNSStringWithCharacter(NSLeftArrowFunctionKey); 155 if ( characters == UIKeyInputRightArrow)155 if ([characters isEqualToString:UIKeyInputRightArrow]) 156 156 return makeNSStringWithCharacter(NSRightArrowFunctionKey); 157 if ( characters == UIKeyInputPageUp)157 if ([characters isEqualToString:UIKeyInputPageUp]) 158 158 return makeNSStringWithCharacter(NSPageUpFunctionKey); 159 if ( characters == UIKeyInputPageDown)159 if ([characters isEqualToString:UIKeyInputPageDown]) 160 160 return makeNSStringWithCharacter(NSPageDownFunctionKey); 161 if ( characters == UIKeyInputEscape)161 if ([characters isEqualToString:UIKeyInputEscape]) 162 162 return @"\x1B"; 163 163 if ([characters isEqualToString:@"\x1B"]) // Num Lock / Clear
Note: See TracChangeset
for help on using the changeset viewer.