Changeset 237377 in webkit
- Timestamp:
- Oct 24, 2018 2:10:24 AM (5 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r237367 r237377 1 2018-10-24 Claudio Saavedra <csaavedra@igalia.com> 2 3 [WPE][GTK] Cleanups to the certificate encoder 4 https://bugs.webkit.org/show_bug.cgi?id=190865 5 6 Reviewed by Žan Doberšek. 7 8 * Shared/soup/WebCoreArgumentCodersSoup.cpp: 9 (IPC::ArgumentCoder<CertificateInfo>::encode): 10 1 11 2018-10-23 Ryan Haddad <ryanhaddad@apple.com> 2 12 -
trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp
r237351 r237377 57 57 } 58 58 59 uint32_t chainLength = 0;60 59 GTlsCertificate* certificate = certificateInfo.certificate(); 61 GByteArray* certificateData = 0; 62 Vector<GByteArray*> certificatesDataList; 63 60 Vector<GRefPtr<GByteArray>> certificatesDataList; 64 61 do { 65 g_object_get(G_OBJECT(certificate), "certificate", &certificateData, NULL); 62 GByteArray* certificateData = nullptr; 63 g_object_get(G_OBJECT(certificate), "certificate", &certificateData, nullptr); 66 64 67 65 if (!certificateData) … … 69 67 70 68 certificatesDataList.append(certificateData); 71 chainLength++;72 69 73 70 certificate = g_tls_certificate_get_issuer(certificate); 74 71 } while (certificate); 75 72 76 encoder << chainLength;77 78 if ( !chainLength)73 encoder << static_cast<uint32_t>(certificatesDataList.size()); 74 75 if (certificatesDataList.isEmpty()) 79 76 return; 80 77 81 78 // Encode starting from the root certificate. 82 for ( uint32_t i = chainLength; i > 0; i--) {83 GRefPtr<GByteArray> certificate = adoptGRef(certificatesDataList[i - 1]);79 for (size_t i = certificatesDataList.size(); i > 0; --i) { 80 auto& certificate = certificatesDataList[i - 1]; 84 81 encoder.encodeVariableLengthByteArray(IPC::DataReference(certificate->data, certificate->len)); 85 82 }
Note: See TracChangeset
for help on using the changeset viewer.