Changeset 237435 in webkit

Timestamp:

Oct 25, 2018 4:55:12 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

JSContext Inspector: Broken frontend, DOMAgent is used but does not exist
​https://bugs.webkit.org/show_bug.cgi?id=190922
<rdar://problem/45569827>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-10-25
Reviewed by Devin Rousso.

• UserInterface/Controllers/DOMManager.js:

(WI.DOMManager.prototype.requestDocument):
Feature check for agents that may not exist in a JSContext.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/DOMManager.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
+
+        JSContext Inspector: Broken frontend, DOMAgent is used but does not exist
+        https://bugs.webkit.org/show_bug.cgi?id=190922
+        <rdar://problem/45569827>
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Controllers/DOMManager.js:
+        (WI.DOMManager.prototype.requestDocument):
+        Feature check for agents that may not exist in a JSContext.
+
 2018-10-25  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js

@@ -83 +83 @@
         }
 
-        DOMAgent.getDocument(onDocumentAvailable.bind(this));
+        if (window.DOMAgent)
+            DOMAgent.getDocument(onDocumentAvailable.bind(this));
     }